- 23 Aug, 2016 28 commits
-
-
epertoso authored
Drive-by fix: the order of parameters in the BinaryOpWithFeedback TurboFan code stubs now reflects the convention of having the context at the end. BUG=v8:5273 Review-Url: https://codereview.chromium.org/2263253002 Cr-Commit-Position: refs/heads/master@{#38832}
-
franzih authored
BUG=v8:5260 Review-Url: https://codereview.chromium.org/2263363002 Cr-Commit-Position: refs/heads/master@{#38831}
-
jbroman authored
BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2265603002 Cr-Commit-Position: refs/heads/master@{#38830}
-
mic.besace authored
On FreeBSD, sem_t is a struct with a couple of uint32_t fields. It only needs dword alignment on 64 bits architectures, not the qword (pointer) alignment that the CHECK currently enforces. BUG= Review-Url: https://codereview.chromium.org/2268993002 Cr-Commit-Position: refs/heads/master@{#38829}
-
verwaest authored
This flag was only set on receiver scopes (declaration scopes) already. This makes it statically obvious. BUG=v8:5209 Review-Url: https://codereview.chromium.org/2268333002 Cr-Commit-Position: refs/heads/master@{#38828}
-
mlippautz authored
Revert of [heap] Tracer: Handle incremental marking scopes (patchset #4 id:100001 of https://codereview.chromium.org/2264033002/ ) Reason for revert: Unittest fails on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/4188/steps/Check/logs/GCTracerTest.Incremen.. Original issue's description: > [heap] Tracer: Handle incremental marking scopes > > Before this patch all tracing scopes in incremental marking would be reset > during a gc tracer start/stop cycle. This patch handles scopes the same way it > does other incremental marking metrics. > > Also: > - Align finalization metric with regular marking metric. > - Smaller cleanups > > BUG=chromium:639818 > R=jochen@chromium.org > > Committed: https://crrev.com/300a8f97472b88ff2f94eb977c36b4bf1bedabf1 > Cr-Commit-Position: refs/heads/master@{#38822} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:639818 Review-Url: https://codereview.chromium.org/2275583002 Cr-Commit-Position: refs/heads/master@{#38827}
-
franzih authored
BUG=v8:5260 Review-Url: https://codereview.chromium.org/2262313002 Cr-Commit-Position: refs/heads/master@{#38826}
-
slan authored
Non-CrOS builds should use clang for snapshot_toolchain, even on builds which use gcc for the target device. Change the default value for snapshot_toolchain to always use clang, except on ChromeOS gcc builds. In practice, every platform except ChromeOS always uses clang, so this should not affect any platform except non-CrOS gcc builds (like Cast) BUG= internal b/30873074 Review-Url: https://codereview.chromium.org/2265983002 Cr-Commit-Position: refs/heads/master@{#38825}
-
vogelheim authored
- The static method CopyChars was actually used and has been extracted. - It was used in tests, where it's been replaced w/ ExternalOneByteString... - Only one test actually relied on Utf8 handling (as opposed to ASCII only), and that was the test testing Utf8ToUtf16CharacterStream itself. +66 -277 LOC :) BUG=v8:4947 Review-Url: https://codereview.chromium.org/2256273002 Cr-Commit-Position: refs/heads/master@{#38824}
-
franzih authored
BUG=v8:5260 Review-Url: https://codereview.chromium.org/2268673002 Cr-Commit-Position: refs/heads/master@{#38823}
-
mlippautz authored
Before this patch all tracing scopes in incremental marking would be reset during a gc tracer start/stop cycle. This patch handles scopes the same way it does other incremental marking metrics. Also: - Align finalization metric with regular marking metric. - Smaller cleanups BUG=chromium:639818 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2264033002 Cr-Commit-Position: refs/heads/master@{#38822}
-
franzih authored
BUG= Review-Url: https://codereview.chromium.org/2269033002 Cr-Commit-Position: refs/heads/master@{#38821}
-
mstarzinger authored
This makes sure the check of the return value of an inlined constructor call is properly wired into the control chain. The check only happens on successful completion of the underlying call and hence is wired into the success latch of the control projections. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2272633002 Cr-Commit-Position: refs/heads/master@{#38820}
-
nikolaos authored
This patch applies an adaptation of the Curiously Recurring Template Pattern to the parser objects. The result is roughly: // Common denominator, needed to avoid cyclic dependency. // Instances of this template will end up with very minimal // definitions, ideally containing just typedefs. template <typename Impl> class ParserBaseTraits; // The parser base object, which should just implement pure // parser behavior. The Impl parameter is the actual derived // class (according to CRTP), which implements impure parser // behavior. template <typename Impl> class ParserBase : public ParserBaseTraits<Impl> { ... }; // And then, for each parser variant: class Parser; template <> class ParserBaseTraits<Parser> { ... }; class Parser : public ParserBase<Parser> { ... }; Using the CRTP, we will ultimately achieve two goals: (1) clean up the traits objects, but most importantly (2) clearly separate pure/impure parser implementation and facilitate experimentation with different parser variants. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2267663002 Cr-Commit-Position: refs/heads/master@{#38819}
-
marja authored
Rebuilding (after touching certain files) is crazy slow because includes are out of control. Fixing it: - Don't include stuff in headers unless necessary. - Include the stuff you need, not some other stuff that happens to include the stuff you need. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2268303002 Cr-Commit-Position: refs/heads/master@{#38818}
-
jochen authored
When preparing compilation, we can't delay error reporting either. Also put handles during internalization into a deferred handle scope. BUG=v8:5215 R=marja@chromium.org,rmcilory@chromium.org Review-Url: https://codereview.chromium.org/2268983002 Cr-Commit-Position: refs/heads/master@{#38817}
-
jochen authored
Also, clarify comments about how semaphores work BUG=none R=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2270703002 Cr-Commit-Position: refs/heads/master@{#38816}
-
mstarzinger authored
This makes sure the deoptimizer picks bytecode prepared for debugging when materializing an interpreted frame if one is available. This is normally done by the interpreter entry trampoline and hence needs to be replicated by the deoptimizer. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2271443003 Cr-Commit-Position: refs/heads/master@{#38815}
-
jochen authored
Even though there is no scope chain, just the empty outer scope. R=marja@chromium.org BUG= Review-Url: https://codereview.chromium.org/2273553003 Cr-Commit-Position: refs/heads/master@{#38814}
-
nikolaos authored
This patch const-qualifies some methods of ParserBase. It also unqualifies some methods of Parser and Preparser. The reason for the latter is that, in principle, the methods of AstNodeFactory should be allowed to change the factory's state, therefore should not be const and should not be used from const-qualified parser/pre-parser methods. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2263973003 Cr-Commit-Position: refs/heads/master@{#38813}
-
verwaest authored
This avoids checking for outer_scope == nullptr in Scope::Scope BUG=v8:5209 Review-Url: https://codereview.chromium.org/2266973002 Cr-Commit-Position: refs/heads/master@{#38812}
-
Miran.Karic authored
Port 28e3467a (r38361) original commit message: Adding new methods to the code stub assembler and interpreter assembler to combine loading and untagging SMIs, so that on 64-bit architectures we can avoid loading the full 64 bits and load the 32 interesting bits directly instead. BUG= Review-Url: https://codereview.chromium.org/2265043002 Cr-Commit-Position: refs/heads/master@{#38811}
-
verwaest authored
This avoids needing to allocate a zonelist on the fly later, sorting variables_, for which we also need to keep track of order in the hashmap. In a later phase we can make sure that Variable is always uniquely in either of params_, temps_ and ordered_variables_. In that case we can use a linked list through Variable. BUG=v8:5209 Review-Url: https://codereview.chromium.org/2264053003 Cr-Commit-Position: refs/heads/master@{#38810}
-
mstarzinger authored
This changes the compilation pipeline so that mixed stacks are allowed when bytecode is preserved. This means there can be activations of both, "baseline" as well as "unoptimized" code active on the stack at the same time for any single given function. R=rmcilroy@chromium.org BUG=v8:4280 Review-Url: https://codereview.chromium.org/2267693002 Cr-Commit-Position: refs/heads/master@{#38809}
-
keishi authored
BUG=chromium:570268,chromium:621829 Review-Url: https://codereview.chromium.org/2233683002 Cr-Commit-Position: refs/heads/master@{#38808}
-
mtrofin authored
Clone the indirect function table(s) when instantiating. This is in preparation to avoiding having a compiled code template. BUG= Review-Url: https://codereview.chromium.org/2273483002 Cr-Commit-Position: refs/heads/master@{#38807}
-
bradnelson authored
Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm, in order to reduce the surface area of the Wasm object, and to focus on testing asm.js coming in via the parser. Ignore extra CONST_LEGACY assignment introduced by the parser when modules have the form: (function Foo(a, b, c) {..}); This requires both a validator and AsmWasmBuilder change. Move stdlib use collection to import time, to reject modules that import a function, even if not used. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=jpp@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2264913002 Cr-Commit-Position: refs/heads/master@{#38806}
-
v8-autoroll authored
Rolling v8/build to 59daf502c36f20b5c9292f4bd9af85791f8a5884 Rolling v8/third_party/WebKit/Source/platform/inspector_protocol to 547960151fb364dd9a382fa79ffc9abfb184e3d1 Rolling v8/tools/clang to 3afb04a8153e40ff00f9eaa14337851c3ab4a368 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2264413002 Cr-Commit-Position: refs/heads/master@{#38805}
-
- 22 Aug, 2016 12 commits
-
-
littledan authored
This flag was shipped on in 52, so it's due for removal. The patch includes removing the deprecated and unused-in-Blink API Promise::Chain, and many test updates. R=adamk@chromium.org BUG=v8:4633 Review-Url: https://codereview.chromium.org/2267033002 Cr-Commit-Position: refs/heads/master@{#38804}
-
bjaideep authored
Port 2027b0be Original commit message: The new operators are implemented similar to the Float64(Max|Min) which already exist. The purpose of the new operators is the implementation of the F32Max and F32Min instructions in WebAssembly. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2263383002 Cr-Commit-Position: refs/heads/master@{#38803}
-
adamk authored
The following code was previously accepted: async function f() { let g = (await) => {}; } But per the spec, using 'await' is disallowed in arrow parameters by an early error rule (just as 'yield' is disallowed in arrow params inside generators). There was special logic in ParseUnaryExpression which seems to have been there only to allow that case. Having removed it, we get a SyntaxError in the right cases anyway when ParseUnaryExpression chokes on whatever illegal token follows 'await' in the cases this code previously handled. Also removes the unnecessary AsyncBindingPatternProduction enum value. R=caitp@igalia.com, littledan@chromium.org BUG=v8:4483 Review-Url: https://codereview.chromium.org/2258313002 Cr-Commit-Position: refs/heads/master@{#38802}
-
jyan authored
R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Review-Url: https://codereview.chromium.org/2265073003 Cr-Commit-Position: refs/heads/master@{#38801}
-
mattloring authored
Includes fast paths in the runtime for DictionaryElementsAccessor, FastSmiOrObjectElementsAccessor, FastDoubleElementsAccessor, TypedElementsAccessor, and SloppyArgumentsElementsAccessor. BUG= Review-Url: https://codereview.chromium.org/2232063002 Cr-Commit-Position: refs/heads/master@{#38800}
-
bjaideep authored
Port 4598d913 Original commit message: This fixes the self-healing mechanism for closures in the interpreter entry trampoline not that bytecode can be preserved even when baseline code is already available. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:638225 LOG=N Review-Url: https://codereview.chromium.org/2265193002 Cr-Commit-Position: refs/heads/master@{#38799}
-
adamk authored
Also lots of cleanup around the checking for 'await' as an identifier throughout the parser and preparser. R=caitp@igalia.com, littledan@chromium.org BUG=v8:4483,v8:5298 Review-Url: https://codereview.chromium.org/2267493002 Cr-Commit-Position: refs/heads/master@{#38798}
-
verwaest authored
- Now "inner_scope_uses_eval_" is also set of scopes that call eval themselves. - AllowLazyParsing doesn't check force_eager_compilation_ anymore. - Both inner_scope_uses_eval_ and force_eager_compilation_ are propagated outwards immediately when set. BUG=v8:5209 Review-Url: https://codereview.chromium.org/2269603002 Cr-Commit-Position: refs/heads/master@{#38797}
-
bradnelson authored
Check remaining asm.js stdlib functions for validitity at instatiation. Fail when a member is referenced, even if not used. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=jpp@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2267633002 Cr-Commit-Position: refs/heads/master@{#38796}
-
jbroman authored
BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2255973005 Cr-Commit-Position: refs/heads/master@{#38795}
-
vogelheim authored
(40B -> 32B, due to alignment rules. Should be neutral on 32b platforms.) BUG=v8:4947 Review-Url: https://codereview.chromium.org/2256183005 Cr-Commit-Position: refs/heads/master@{#38794}
-
jochen authored
When doing a component build, some test binaries link against the object files directly, bypassing the components. This results, however, and rightly so, in linker warnings. In gyp, we just suppressed them. During the transition to gn, this was dropped for two binaries. Here I add the suppressions back in. Long term, we should either change the tests to go through the public API, or export the required symbols. BUG=chromium:633688 R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2261123003 Cr-Commit-Position: refs/heads/master@{#38793}
-