Commit 24cb21e3 authored by jochen's avatar jochen Committed by Commit bot

[gn] add missing suppressions for linker warnings on windows

When doing a component build, some test binaries link against the object
files directly, bypassing the components. This results, however, and
rightly so, in linker warnings. In gyp, we just suppressed them. During
the transition to gn, this was dropped for two binaries.

Here I add the suppressions back in.

Long term, we should either change the tests to go through the public
API, or export the required symbols.

BUG=chromium:633688
R=jkummerow@chromium.org

Review-Url: https://codereview.chromium.org/2261123003
Cr-Commit-Position: refs/heads/master@{#38793}
parent f93ac896
......@@ -2456,6 +2456,16 @@ v8_executable("v8_parser_shell") {
if (v8_enable_i18n_support) {
deps += [ "//third_party/icu" ]
}
if (is_win) {
# Suppress warnings about importing locally defined symbols.
if (is_component_build) {
ldflags = [
"/ignore:4049",
"/ignore:4217",
]
}
}
}
if (want_v8_shell) {
......
......@@ -160,4 +160,14 @@ v8_executable("generate-bytecode-expectations") {
} else {
deps += [ "../..:v8" ]
}
if (is_win) {
# Suppress warnings about importing locally defined symbols.
if (is_component_build) {
ldflags = [
"/ignore:4049",
"/ignore:4217",
]
}
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment