• nikolaos's avatar
    [parser] Apply an adaptation of the CRTP · 6c2c17cd
    nikolaos authored
    This patch applies an adaptation of the Curiously Recurring Template
    Pattern to the parser objects.  The result is roughly:
    
        // Common denominator, needed to avoid cyclic dependency.
        // Instances of this template will end up with very minimal
        // definitions, ideally containing just typedefs.
        template <typename Impl>
        class ParserBaseTraits;
    
        // The parser base object, which should just implement pure
        // parser behavior.  The Impl parameter is the actual derived
        // class (according to CRTP), which implements impure parser
        // behavior.
        template <typename Impl>
        class ParserBase : public ParserBaseTraits<Impl> { ... };
    
        // And then, for each parser variant:
        class Parser;
    
        template <>
        class ParserBaseTraits<Parser> { ... };
    
        class Parser : public ParserBase<Parser> { ... };
    
    Using the CRTP, we will ultimately achieve two goals:
    (1) clean up the traits objects, but most importantly
    (2) clearly separate pure/impure parser implementation and facilitate
    experimentation with different parser variants.
    
    R=adamk@chromium.org, marja@chromium.org
    BUG=
    LOG=N
    
    Review-Url: https://codereview.chromium.org/2267663002
    Cr-Commit-Position: refs/heads/master@{#38819}
    6c2c17cd
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...