Skip to content

V
V8
Switch branch/tag
  1. 16 Apr, 2013 1 commit
  3. 20 Mar, 2013 1 commit
  5. 11 Mar, 2013 1 commit
  7. 06 Mar, 2013 1 commit
  9. 05 Mar, 2013 1 commit
  11. 13 Feb, 2013 1 commit
  13. 23 Jan, 2013 1 commit
  15. 09 Jan, 2013 1 commit
  17. 07 Jan, 2013 1 commit
  19. 04 Jan, 2013 1 commit
  21. 22 Nov, 2012 1 commit
  23. 15 Nov, 2012 1 commit
  25. 12 Nov, 2012 1 commit
  27. 09 Nov, 2012 1 commit
  29. 22 Oct, 2012 1 commit
  31. 17 Oct, 2012 1 commit
  33. 04 Oct, 2012 1 commit
    • danno@chromium.org's avatar
      MIPS: Changed "marked" nops to use sll(zero_reg, at, type). · a92a9c8a
      danno@chromium.org authored 
      We use marking bits in nops (in the 'sa' field) for debug markers, and for some IC stuff. A normal NOP in mips is sll(zero_reg, zero_reg, 0), where the 0 is a 5 bit immediate field in 'sa'.

See enum NopMarkerTypes at around line 654 of assembler-mips.h

The problem is that these markers use encodings that are reserved for the 'ssnop' and 'ehb' instructions. These are instructions used for hazard barriers.

It does not break anything, but it will slow things down a little bit as some pipeline stages are cleared, etc.

This commit changes the "marked" NOPs to sll(zero_reg, at, type) instructions, which is also a NOP operation on MIPS.

BUG=
TEST=

Review URL: https://codereview.chromium.org/10990110
Patch from Akos Palfi <palfia@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12657 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      a92a9c8a
  35. 06 Aug, 2012 1 commit
  37. 31 Jul, 2012 1 commit
  39. 12 Apr, 2012 1 commit
  41. 05 Apr, 2012 1 commit
    • danno@chromium.org's avatar
      MIPS: Remove static initializers in v8. · a897e6e2
      danno@chromium.org authored 
      Port r11010 (1daa81bc).

MIPS-specific changes:
-register codes and registers are defined using a macro to avoid redundancy
-renamed s8_fp to fp, removed the "fp" alias
-removed kSavedValueRegister (found by check-static-initializers.sh)

Original commit message:

Landing for pliard@chromium.org: Remove static initializers in v8.

This change includes two CLs by pliard@chromium.org:

1. http://codereview.chromium.org/9447052/ (Add CallOnce() and simple LazyInstance implementation):

Note that this implementation of LazyInstance does not handle global destructors (i.e. the lazy instances a

This CL was initially reviewed on codereview.appspot.com:
http://codereview.appspot.com/5687064/

2.  http://codereview.chromium.org/9455088/ (Remove static initializers in v8):
This CL depends on CL 9447052 (adding CallOnce and LazyInstance).
It is based on a patch sent by Digit.

With this patch applied, we have only one static initializer left (in atomicops_internals_x86_gcc.cc). This

This CL also modifies the presubmit script to check the number of static initializers.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/9689069
Patch from Daniel Kalmar <kalmard@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11241 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      a897e6e2
  43. 21 Mar, 2012 1 commit
  45. 19 Jan, 2012 1 commit
  47. 16 Jan, 2012 1 commit
  49. 26 Oct, 2011 1 commit
  51. 13 Sep, 2011 1 commit
  53. 08 Sep, 2011 1 commit
  55. 29 Aug, 2011 1 commit
  57. 18 Jul, 2011 1 commit
  59. 11 Jul, 2011 1 commit
    • sgjesse@chromium.org's avatar
      MIPS: Cleaned up calling-related methods in the assembler. · 5528ce70
      sgjesse@chromium.org authored 
      Patterned after r8482, Cleaned up calling-related methods in the ARM assembler.

On MIPS I completely refactored the Jump and Call methods.
All the Jump and Call macro helpers have been replaced with overloaded functions
(matching the ARM version) and using default parameter values where possible.
The previously mostly-unused CallSize function is utilized as well (same as on ARM).
The unused Jump(Operand, ...) and Call(Operand, ...) versions have been completely removed.
I also removed the Jump(BranchDelaySlot, ...) and Call(BranchDelaySlot,...) methods as
they were unused and declaring them would either result in a lot of unused code or the
previously experienced macro-hell. The only exception to this is for Ret() where the
branch delay slot is often used.

This fixes the failing debug tests for example cctest test-debug/DebugStepFor.

Ported r8482 (41cb9ed)

Patch by Daniel Kalmar <kalmard@homejinni.com>

BUG=
TEST=

Review URL: http://codereview.chromium.org//7328013
Patch from Paul Lind <plind44@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8585 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      5528ce70
  61. 28 Jun, 2011 1 commit
  63. 27 Jun, 2011 1 commit
  65. 07 Jun, 2011 1 commit
  67. 26 May, 2011 1 commit
    • sgjesse@chromium.org's avatar
      MIPS: Added the stop() instruction with same behavior as on Arm simulator. · 64c61072
      sgjesse@chromium.org authored 
      The already working watchpoint break mechanism has been extended to handle "stop" instructions, with text messages.

Explanation (also in constants-mips.h):
On MIPS Simulator breakpoints can have different codes:
- Breaks between 0 and kMaxWatchpointCode are treated as simple watchpoints, the simulator will run through them and print the registers.
- Breaks between kMaxWatchpointCode and kMaxStopCode are treated as stop() instructions (see Assembler::stop()).
- Breaks larger than kMaxStopCode are simple breaks, dropping you into the debugger.

The current values are 31 for kMaxWatchpointCode and 127 for kMaxStopCode.
From the user's point of view this works the same way as the ARM stop instruction except for the break code usage detailed above.

Ported commits: r5723 (3ba78d24)

BUG=
TEST=

Review URL: http://codereview.chromium.org//7062014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8069 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      64c61072
  69. 17 May, 2011 1 commit
  71. 09 May, 2011 1 commit
  73. 28 Mar, 2011 1 commit
  75. 24 Sep, 2010 1 commit
  77. 08 Jun, 2010 1 commit
    • sgjesse@chromium.org's avatar
      More precise break points and stepping when debugging · 634fb915
      sgjesse@chromium.org authored 
      Added support for more precise break points when debugging and stepping. To achieve that additional nop instructions are inserted where breaking would otherwise be impossible. The number of nop instructions inserted are sufficient to make place for patching with a call to a debug break code stub. On Intel that is 5 nop's for 32-bit and 13 for 64-bit. Om ARM 3 nop instructions (12 bytes) are required.

In order to avoid inserting nop's in to many places a simple ast checker have been added to check whether there are breakable code in a statement or expression. If it is possible to break in an expression no additional break enabeling code is inserted.

Added break locations to the true and false part of a conditional expression.

Added stepping tests to cover more constructs.

These changes are only in the full compiler.

Changed the default value for the option --debugger in teh d8 shell from true to false. The reason for this is that with --debugger turned on the full compiler will be used for all code in when running d8, which can be unexpeceted.

Review URL: http://codereview.chromium.org/2693002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4820 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      634fb915
  79. 21 Apr, 2010 1 commit