- 09 Apr, 2021 13 commits
-
-
Michael Achenbach authored
This reverts commit dcdaf42f. Reason for revert: This has problems on mac-arm64: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/3591 Original change's description: > [wasm] Add CPU time metrics > > This adds CPU time metrics to the WasmModuleDecoded (except for streaming), > WasmModuleCompiled and WasmModuleTieredUp events. This can later be used > to provide this information as UKMs or UMAs. > > Bug: v8:11611 > Change-Id: I36818f5efbdcae2d3ed6f27c16db21f9d8440d98 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796952 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73882} Bug: v8:11611 Change-Id: I1c82c3e4f19b3a486538fd62665669f6c5b98438 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2818380 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73884}
-
Junliang Yan authored
Change-Id: I03462b0632da3846b53047588597eb16a098b057 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2815561Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73883}
-
Emanuel Ziegler authored
This adds CPU time metrics to the WasmModuleDecoded (except for streaming), WasmModuleCompiled and WasmModuleTieredUp events. This can later be used to provide this information as UKMs or UMAs. Bug: v8:11611 Change-Id: I36818f5efbdcae2d3ed6f27c16db21f9d8440d98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796952Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#73882}
-
Benedikt Meurer authored
Previously the inspector was trying to add a special `__proto__` property to every JSObject, which looked and behaved like a real data property on the object. But this is confusing to developers since `__proto__` is not a real data property, but usually an accessor property on the `Object.prototype`. Additionally all other internal properties are reported using the [[Name]] notation, with the [[Prototype]] having been the strange outlier. Drive-by-cleanup: Use an ArrayList to collect the name/value pairs inside Runtime::GetInternalProperties(), which makes this function more readable and easier to add things. Bug: chromuium:1162229 Fixed: chromium:1197019 Screenshot: https://imgur.com/a/b7TZ32s.png Change-Id: Ic4c1e35e2e65f90619fcc12bf3a72806cadb0794 Doc: http://doc/1Xetnc9s6r0yy4LnPbqeCwsnsOtBlvJsV4OCdXMZ1wCM Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814565 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#73881}
-
Michael Lippautz authored
This is a reland of 62ff82e4 Original change's description: > cppgc: Add tests for in-construction during ctor > > Adds explicit tests that check that an object is marked as in > construction while running the constructor. > > Bug: chromium:1056170 > Change-Id: I7f7340832e1bc31cec98784c261ed86deb402e72 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811238 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73869} Bug: chromium:1056170 Change-Id: I38c8579dc2ed437f2ad530bd552b5ef037ba8621 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2817603 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73880}
-
Jakob Kummerow authored
The primary reason for this change is that this fixes a race condition when one scavenger thread moves a WasmTypeInfo object that another scavenger thread needs to read for visiting a Wasm struct. Aside from that, since these objects are long-lived, it also generally makes sense to pretenure them. Fixed: v8:11618 Change-Id: I61e81752306dd6f29e0d26a0c40120a6301b0c12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814561Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73879}
-
Benedikt Meurer authored
These tests unnecessarily rely on the `//# sourceURL` annotation. This is preparatory work to eventually move the treatment of `sourceURL` to the DevTools front-end. Bug: chromium:1183990 Change-Id: I934eb1580f503b7b9f8d97c250b7c798bc67e268 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814568 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#73878}
-
Maya Lekova authored
This CL temporarily skips the fast-api-calls mjsunit test, as it fails on GC stress bots for unrelated CLs (see https://chromium-review.googlesource.com/c/v8/v8/+/2814740). Change-Id: I884827a0a5fb030d676f9ded738f644cd4086ec6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814564 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73877}
-
Frank Tang authored
Use the newer method getBestMatchResult() and makeResolvedLocale() to resolve the locale instead. Bug: v8:11584 Change-Id: Ifbd7a9b0d05506d83c2603c301b4d9e4caf2d689 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783662 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73876}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/77edba1..0006b44 Rolling v8/third_party/aemu-linux-x64: SeLS6a0f6IL-PCOUKbMTN5LYgjjJbDSnb3DGf5q9pwsC..SCU6888HuyC5TF12MrqnyC2eTRFiqzg1KUCITYThpxIC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/41a5e5e..868d5d0 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/98a52e2..1cabb17 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a387faa..3b0c35b Rolling v8/tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87 Rolling v8/tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87 Rolling v8/tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84f879faeaf0ab23dd1ae37976dbb8e822a85c34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2816303Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73875}
-
Shu-yu Guo authored
For consistency with the PtrComprCageBase struct and the upcoming PtrComprCage. Bug: v8:11460 Change-Id: I2e393331c36481ee911edeaf9fb3ff971cfdba83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2787701 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73874}
-
Yahan Lu authored
Port: 3e689a7d Bug: v8:11421 Change-Id: I733a68d8ce6d4cbc11a63e82ccb6bd951f5e5870 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763963Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#73873}
-
Liu Yu authored
Port: 064ca18c Bug: v8:11420 Change-Id: I4a8051b10fa2c1eab316f8a8d7928a5e134b59e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814119 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#73872}
-
- 08 Apr, 2021 25 commits
-
-
Antoine du Hamel authored
Bug: v8:8179 Change-Id: I7f699073807d1874d0c10a4f1641de6bfb0efe6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#73871}
-
Francis McCabe authored
This reverts commit 62ff82e4. Reason for revert: compilation failure: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20msvc/b8850484852067442832/overview Original change's description: > cppgc: Add tests for in-construction during ctor > > Adds explicit tests that check that an object is marked as in > construction while running the constructor. > > Bug: chromium:1056170 > Change-Id: I7f7340832e1bc31cec98784c261ed86deb402e72 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811238 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73869} Bug: chromium:1056170 Change-Id: If9e75ab6da3762553e8e34e851cbf1120cd49925 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2816100 Auto-Submit: Francis McCabe <fgm@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73870}
-
Michael Lippautz authored
Adds explicit tests that check that an object is marked as in construction while running the constructor. Bug: chromium:1056170 Change-Id: I7f7340832e1bc31cec98784c261ed86deb402e72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811238 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73869}
-
Milad Fa authored
Implantation now includes using a combination of multiplly even and odd flowed by a vector merge low or high. vector merge instructions are also added to the simulator. Change-Id: I144c5d07e5e6bd978788a70aacabd61463f93289 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2815562 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73868}
-
Milad Fa authored
input needs to be casted into the result type before doing the multiplication. Change-Id: I797e8d3586678508f35c51d7890ad0d31fc7f1ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2815559Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73867}
-
Lutz Vahl authored
TBR=hablich@chromium.org, vahl@chromium.org Change-Id: I6c77e5de7a7c0222f01ee237f125a97538dd8cc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814558Reviewed-by: Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/master@{#73866}
-
Michael Achenbach authored
This is a reland of f41bc94b The remaining test failures where fixed. Original change's description: > Reland "[test] Extend testing on Mac on arm64" > > This is a reland of f187d0a1 > > The cctest breakage got fixed in the meantime. > > Original change's description: > > [test] Extend testing on Mac on arm64 > > > > Ensure more testing of --future for different test types on Mac. > > > > No-Try: true > > Bug: v8:11527 > > Change-Id: Iac499dc48dde3342ad2057f86ef1ad5fa43b4eac > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772981 > > Reviewed-by: Igor Sheludko <ishell@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#73514} > > No-Try: true > Bug: v8:11527 > Change-Id: Ie82c69e652f84a7ac43436d28806e70f27aa3e72 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807601 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73806} No-Try: true Bug: v8:11527 Change-Id: I6ca48bb0917d9bf2950302127d108d844bd6eebc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814559 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#73865}
-
Milad Fa authored
Port 05265d88 Original Commit Message: This removes all wasm-related flags in no-wasm builds. We could have made them read-only, but fully removing them actually forces us to consider the no-wasm case at every use site, which often hints at further cleanups. R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ib68968683023f602f2226f0fa8d7c26bcc04b170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814899Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73864}
-
Almothana Athamneh authored
Bug: v8:11594 Change-Id: I29dd481a22ee3c131807293664154865e7990098 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810781 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73863}
-
Michael Achenbach authored
This reverts commit d5457f5f. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/32999 Original change's description: > [api] JSFunction PromiseHook for v8::Context > > This will enable Node.js to get much better performance from async_hooks > as currently PromiseHook delegates to C++ for the hook function and then > Node.js delegates it right back to JavaScript, introducing several > unnecessary barrier hops in code that gets called very, very frequently > in modern, promise-heavy applications. > > This API mirrors the form of the original C++ function based PromiseHook > API, however it is intentionally separate to allow it to use JSFunctions > triggered within generated code to, as much as possible, avoid entering > runtime functions entirely. > > Because PromiseHook has internal use also, beyond just the Node.js use, > I have opted to leave the existing API intact and keep this separate to > avoid conflicting with any possible behaviour expectations of other API > users. > > The design ideas for this new API stemmed from discussion with some V8 > team members at a previous Node.js Diagnostics Summit hosted by Google > in Munich, and the relevant documentation of the discussion can be found > here: https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/edit#heading=h.w1bavzz80l1e > > A summary of the reasons for why this new design is important can be > found here: https://docs.google.com/document/d/1vtgoT4_kjgOr-Bl605HR2T6_SC-C8uWzYaOPDK5pmRo/edit?usp=sharing > > Bug: v8:11025 > Change-Id: I0b403b00c37d3020b5af07b654b860659d3a7697 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759188 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73858} Bug: v8:11025 Change-Id: Ie7345c4505f39c973f9f0dbca745b591cff63f3f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814740 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73862}
-
Ulan Degenbaev authored
Flushing of the builtins code needs to happen while the code pages are writeable. Bug: 889460, v8:11619 Change-Id: Iaff40d66f3f1bd36ec0f3017684e236f9e4b773e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810786 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73861}
-
Clemens Backes authored
There are fives bytes total which are expected to be different from zero. We were only handling one of them when checking random positions in the array. This was leading to random failures. R=manoskouk@chromium.org Bug: v8:11621 Change-Id: Iac231d8b35fcbfbbc837c8e9134401cb8a2519ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810783Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73860}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1196558 Change-Id: Iffbf6de44caaea0215cbfe33fd28108e9ca4c715 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808947Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73859}
-
Stephen Belanger authored
This will enable Node.js to get much better performance from async_hooks as currently PromiseHook delegates to C++ for the hook function and then Node.js delegates it right back to JavaScript, introducing several unnecessary barrier hops in code that gets called very, very frequently in modern, promise-heavy applications. This API mirrors the form of the original C++ function based PromiseHook API, however it is intentionally separate to allow it to use JSFunctions triggered within generated code to, as much as possible, avoid entering runtime functions entirely. Because PromiseHook has internal use also, beyond just the Node.js use, I have opted to leave the existing API intact and keep this separate to avoid conflicting with any possible behaviour expectations of other API users. The design ideas for this new API stemmed from discussion with some V8 team members at a previous Node.js Diagnostics Summit hosted by Google in Munich, and the relevant documentation of the discussion can be found here: https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/edit#heading=h.w1bavzz80l1e A summary of the reasons for why this new design is important can be found here: https://docs.google.com/document/d/1vtgoT4_kjgOr-Bl605HR2T6_SC-C8uWzYaOPDK5pmRo/edit?usp=sharing Bug: v8:11025 Change-Id: I0b403b00c37d3020b5af07b654b860659d3a7697 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759188Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73858}
-
Thibaud Michaud authored
The test doesn't fail anymore after it was updated to check platforms with page size > 4096: 402806e8 ("[cppgc][unittests] Only expect guard pages support on 4k platforms.") R=jkummerow@chromium.org Bug: v8:11587 Change-Id: I6be93e9561b9db0d0f948c5e12fea6a067eb0a76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2813538Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73857}
-
Sara Tang authored
This CL implements the equivalent of ETW in macos (called Signposts) Bug: v8:11043 Change-Id: Ifa72cfd17fca81b18e3e8b1003fd6ab72de3c986 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807157 Commit-Queue: Sara Tang <sartang@microsoft.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73856}
-
Victor Gomes authored
https://github.com/tc39/proposal-error-cause Bug: chromium:1192162 Change-Id: If6e2d1f105bb520104bb832ccbc7f660bb8115a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784681 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73855}
-
Michael Lippautz authored
The only valid way to define a GCed type T is by inheriting from GarbageCollected<T>. Since this is prone to typos (see tests), add a simple check that covers most interesting use cases. The static assert covers A -> B -> GarbageCollected<C> The static assert does not cover A -> B -> C -> GarbageCollected<B> (In order to do so, we would need __direct_bases() support which is not yet available for C++.) Bug: pdfium:1670, chromium:1056170 Change-Id: I494de48992f8ba9a1f0f9daad60584d828717403 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810415Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73854}
-
Thibaud Michaud authored
This is a reland of f645d0b8 The issue was that converting an i64 to an i32 didn't clear the upper bits on arm64. This was not necessary before because we did the zero extension as part of the load operand, but this is required now that we use the full register. Original change's description: > [liftoff][arm64] Use 64 bit offset reg in mem op > > Accessing the Wasm memory with a 64 bit offset was truncated to 32 bit, > which is fine if we check bounds first, but not if we rely on the > trap handler to catch the OOB. > > R=clemensb@chromium.org > > Bug: v8:11587 > Change-Id: I82a3a2906e55d9d640c30e770a5c93532e3a442c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808942 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73829} Bug: v8:11587 Change-Id: Ibc182475745c6f697a0ba6d75c260b74ddf8fe52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810846Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73853}
-
Maya Lekova authored
This CL adds handling of unexpected argument types to the functions provided by d8.test.fast_c_api. Bug: chromium:1196598 Change-Id: I7c62280f168817b73e89fdb7457ee9054b51a318 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808948Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#73852}
-
Jakob Gruber authored
This is part of moving towards MapUpdater as the bottleneck for map updates. Drive-by: Move helpers. Drive-by: Use a plain std::queue instead of a ZoneQueue in UpdateFieldType. Bug: v8:7790 Change-Id: Iff80a6e9bf3390a010305f7998d6f6dad2bce09f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807602 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73851}
-
Igor Sheludko authored
This CL fixes a segfault when Wasm tried to generate a builtin call from background compilation job when the Isolate was already teared down by the main thread. Drive-by: Use CallBuiltin in RegExpMacroAssemblerARM64. Bug: v8:11527, chromium:1195552 Change-Id: I8048ffcb212bda4d19d07b5ec6b487d6fb16b30d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811739 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73850}
-
Jakob Gruber authored
Lookarounds rewind the position after matching, and thus don't play well with eats_at_least (EAL). This CL disables EAL propagation from lookarounds. In the future we could be a bit smarter by skipping over lookarounds instead of resetting to 0. Bug: v8:11290 Change-Id: I935400a7f9cda96d9c5a80e412ba7d04de70a84f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808944Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73849}
-
Jakob Gruber authored
The eats_at_least (EAL) value is applied in forward-directions only. Two reasons for that which are relevant to this CL: - EAL's of neighboring nodes are combined additively, irrespective of their read_backward value. - EatsAtLeastPropagator::VisitText uses the successor's eats_at_least_from_not_start value, which doesn't work properly for read_backwards successors (which may end at the start). A symptom of this bug was that we applied an incorrect EAL of 255 starting at the initial 'x' of /x(?<=^x{4})/); for subject strings shorter than 255 chars, this would result in an incorrect failure result. Bug: v8:11616 Change-Id: I4b2b1b78f0cea8f59e4beb1037ee46035d83c927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807596Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73848}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/52bfb9d..77edba1 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/a136a3b..d0f3388 Rolling v8/third_party/aemu-linux-x64: RQd3qSR12Rp6wgHjC31u-jwbITCfk3M-ZJyL6s1ju4sC..SeLS6a0f6IL-PCOUKbMTN5LYgjjJbDSnb3DGf5q9pwsC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3f562c0..98a52e2 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/d879aac..81d6568 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/6900bf4..084aee0 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6c9e9ef51ca70bdab1bf6cd0b5d1c178177fb137 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811464Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73847}
-
- 07 Apr, 2021 2 commits
-
-
Z Nguyen-Huu authored
Change-Id: I8ea9403fa2ae8d45300c291a6d9a55b9293e7c1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2805731 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73846}
-
Junliang Yan authored
Change-Id: Id5dd7a33b4d64cb73ccc4f5c1457f8a28905d814 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810885Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73845}
-