• Jakob Gruber's avatar
    [regexp] Don't use eats_at_least for backwards loops · c977b65b
    Jakob Gruber authored
    The eats_at_least (EAL) value is applied in forward-directions only.
    Two reasons for that which are relevant to this CL:
    
    - EAL's of neighboring nodes are combined additively, irrespective of
      their read_backward value.
    - EatsAtLeastPropagator::VisitText uses the successor's
      eats_at_least_from_not_start value, which doesn't work properly for
      read_backwards successors (which may end at the start).
    
    A symptom of this bug was that we applied an incorrect EAL of 255
    starting at the initial 'x' of /x(?<=^x{4})/); for subject strings
    shorter than 255 chars, this would result in an incorrect failure
    result.
    
    Bug: v8:11616
    Change-Id: I4b2b1b78f0cea8f59e4beb1037ee46035d83c927
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807596Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73848}
    c977b65b
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...