• Benedikt Meurer's avatar
    [inspector] Report [[Prototype]] as internal property. · 2b94e567
    Benedikt Meurer authored
    Previously the inspector was trying to add a special `__proto__`
    property to every JSObject, which looked and behaved like a real
    data property on the object. But this is confusing to developers
    since `__proto__` is not a real data property, but usually an
    accessor property on the `Object.prototype`.
    
    Additionally all other internal properties are reported using the
    [[Name]] notation, with the [[Prototype]] having been the strange
    outlier.
    
    Drive-by-cleanup: Use an ArrayList to collect the name/value pairs
    inside Runtime::GetInternalProperties(), which makes this function
    more readable and easier to add things.
    
    Bug: chromuium:1162229
    Fixed: chromium:1197019
    Screenshot: https://imgur.com/a/b7TZ32s.png
    Change-Id: Ic4c1e35e2e65f90619fcc12bf3a72806cadb0794
    Doc: http://doc/1Xetnc9s6r0yy4LnPbqeCwsnsOtBlvJsV4OCdXMZ1wCM
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814565
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73881}
    2b94e567
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...