- 05 Mar, 2018 1 commit
-
-
Clemens Hammacher authored
On ia32, support for vsqrtss and vsqrtsd was missing, so I add the implementation of these instructions and disassembly support. On x64, disassembly support for vsqrtss was missing, while vsqrtsd was implemented. Now both are implemented. The implementation of f32.sqrt and f64.sqrt is very straight-forward on ia32 and x64, we can immediately emit the {v}sqrtss or {v}sqrtsd instruction. R=ahaas@chromium.org Bug: v8:6600 Change-Id: Icf3ec05a97a23e94cdf70f4a72f30dd02fbddd13 Reviewed-on: https://chromium-review.googlesource.com/944221Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51724}
-
- 01 Mar, 2018 1 commit
-
-
jing.bao authored
Also Add vhaddps to x64 Fix haddps for SSE3 scope and disassembler on ia32/x64 Change-Id: If511e6428fa1ce034b4281943dfee1405c9d4ffc Reviewed-on: https://chromium-review.googlesource.com/939265Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#51642}
-
- 08 Feb, 2018 1 commit
-
-
Deepti Gandluri authored
Change-Id: I1fe7ba0a942c6da2d1c85c2391762cb434098cf1 Reviewed-on: https://chromium-review.googlesource.com/907346Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#51165}
-
- 15 Jan, 2018 1 commit
-
-
Tobias Tebbi authored
Bug: Change-Id: Icf0c43ef5bd3b3d3055d9606f22d3126b31016e3 Reviewed-on: https://chromium-review.googlesource.com/866930 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50595}
-
- 11 Dec, 2017 2 commits
-
-
Deepti Gandluri authored
The haddps instruction is needed to implement wasm SIMD F32x4 horizontal add. BUG=V8:6020 Change-Id: Ifff78f6c697b46e621f0fd6b7bb1b0e7824a3088 Reviewed-on: https://chromium-review.googlesource.com/820098Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#50013}
-
jing.bao authored
Implement IA32Movdqu Add vmovdqu and Movdqu macro Bug: Change-Id: Idc2b5c99adf38d6120ff451bde40d4ad8f2046de Reviewed-on: https://chromium-review.googlesource.com/815944Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#49981}
-
- 06 Dec, 2017 1 commit
-
-
jing.bao authored
Add vshufps, vmovaps, insertps/vinsertps Bug: Change-Id: I178cde529b5309a5221086ab916e5485a8b67d5a Reviewed-on: https://chromium-review.googlesource.com/802999Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#49880}
-
- 02 Dec, 2017 1 commit
-
-
Mathias Bynens authored
This patch normalizes the casing of hexadecimal digits in escape sequences of the form `\xNN` and integer literals of the form `0xNNNN`. Previously, the V8 code base used an inconsistent mixture of uppercase and lowercase. Google’s C++ style guide uses uppercase in its examples: https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters Moreover, uppercase letters more clearly stand out from the lowercase `x` (or `u`) characters at the start, as well as lowercase letters elsewhere in strings. BUG=v8:7109 TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6 Reviewed-on: https://chromium-review.googlesource.com/804294 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49810}
-
- 18 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
This CL fixes all occurences that don't require special OWNER reviews, or can be reviewed by Michi. After this one, we should be able to reenable the readability/check cpplint check. R=mstarzinger@chromium.org Bug: v8:6837, v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ic81d68d5534eaa795b7197fed5c41ed158361d62 Reviewed-on: https://chromium-review.googlesource.com/721120 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48670}
-
- 17 Oct, 2017 2 commits
-
-
Michael Achenbach authored
This reverts commit 2857e783. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/20965 Original change's description: > [ia32][wasm] Add I32x4AddHoriz and I16x8AddHoriz > > Add phaddd, phaddw and AVX version > Add vmovdqu and Movdqu macro > > Bug: > Change-Id: I4f5c0cf96ab481fc18f0a0d554101a996a16c954 > Reviewed-on: https://chromium-review.googlesource.com/715677 > Commit-Queue: Jing Bao <jing.bao@intel.com> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48621} TBR=bbudge@chromium.org,mtrofin@chromium.org,bmeurer@chromium.org,jing.bao@intel.com Change-Id: Icaf36b46134e77e46180fc1671d0c6569b729a89 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/722679Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48622}
-
jing.bao authored
Add phaddd, phaddw and AVX version Add vmovdqu and Movdqu macro Bug: Change-Id: I4f5c0cf96ab481fc18f0a0d554101a996a16c954 Reviewed-on: https://chromium-review.googlesource.com/715677 Commit-Queue: Jing Bao <jing.bao@intel.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48621}
-
- 13 Oct, 2017 1 commit
-
-
Mathias Bynens authored
New code should use nullptr instead of NULL. This patch updates existing use of NULL to nullptr where applicable, making the code base more consistent. BUG=v8:6928,v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4687f5b96fcfd88b41fa970a2b937b4f6538777c Reviewed-on: https://chromium-review.googlesource.com/718338 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48557}
-
- 08 Aug, 2017 1 commit
-
-
jing.bao authored
Reconstruct pshufb using macro Bug: Change-Id: I5556ce1108378fc7a7658443cd09c3f676c16aa7 Reviewed-on: https://chromium-review.googlesource.com/603907Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#47228}
-
- 13 Jun, 2017 1 commit
-
-
jing.bao authored
Also add vpinsrw BUG= Review-Url: https://codereview.chromium.org/2931333002 Cr-Commit-Position: refs/heads/master@{#45883}
-
- 12 Jun, 2017 1 commit
-
-
jing.bao authored
Add vpinsrd, vpextrd, vmovd. Supplement pshufd and add vpshufd. Add Movd and Pshufd macro. Add AVX support to Pextrd. Fix disassembler to recognize "pinsrd/pextrd xmm,[mem],imm8". BUG= Review-Url: https://codereview.chromium.org/2916093002 Cr-Commit-Position: refs/heads/master@{#45833}
-
- 22 May, 2017 1 commit
-
-
Wiktor Garbacz authored
Change-Id: I20ed35a7fb5104a9cc66bb54fa8966589c43d7f9 Reviewed-on: https://chromium-review.googlesource.com/507287Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#45458}
-
- 15 May, 2017 1 commit
-
-
jing.bao authored
instr(xmm, xmm/mem) vinstr(xmm, xmm/mem) BUG= Review-Url: https://codereview.chromium.org/2870253003 Cr-Commit-Position: refs/heads/master@{#45293}
-
- 28 Apr, 2017 1 commit
-
-
jing.bao authored
BUG= Review-Url: https://codereview.chromium.org/2847683002 Cr-Commit-Position: refs/heads/master@{#44955}
-
- 15 Mar, 2017 1 commit
-
-
jing.bao authored
Also use vinstr for vps/vpd/vss/vsd BUG= Review-Url: https://codereview.chromium.org/2747103002 Cr-Commit-Position: refs/heads/master@{#43809}
-
- 14 Mar, 2017 2 commits
-
-
jing.bao authored
psll/rl/raw(xmm, imm) psrad(xmm, imm) vpsll/rl/raw(xmm, xmm, imm) vpsll/rl/rad(xmm, xmm, imm) BUG= Review-Url: https://codereview.chromium.org/2747783004 Cr-Commit-Position: refs/heads/master@{#43762}
-
jing.bao authored
Add instructions in following format: instr(xmm, xmm/mem) vinstr(xmm, xmm, xmm/mem) BUG= Review-Url: https://codereview.chromium.org/2744643004 Cr-Commit-Position: refs/heads/master@{#43760}
-
- 10 Mar, 2017 1 commit
-
-
jing.bao authored
CreateInt32x4, Int32x4ExtractLane, Int32x4ReplaceLane Int32x4Add, Int32x4Sub Also add paddd, psubd, vpaddd, vpsubd, pinsrw to ia32-assembler BUG= Review-Url: https://codereview.chromium.org/2695613004 Cr-Original-Commit-Position: refs/heads/master@{#43483} Committed: https://chromium.googlesource.com/v8/v8/+/4deb9ffdecf121c69a3db7eae6698eae23a80a15 Review-Url: https://codereview.chromium.org/2695613004 Cr-Commit-Position: refs/heads/master@{#43708}
-
- 28 Feb, 2017 2 commits
-
-
machenbach authored
Revert of Add several SIMD opcodes to IA32 (patchset #9 id:160001 of https://codereview.chromium.org/2695613004/ ) Reason for revert: Fails with nosse4: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/13853 Original issue's description: > Add several SIMD opcodes to IA32 > > CreateInt32x4, Int32x4ExtractLane, Int32x4ReplaceLane > Int32x4Add, Int32x4Sub > > Also add paddd and psubd to ia32-assembler > > BUG= > > Review-Url: https://codereview.chromium.org/2695613004 > Cr-Commit-Position: refs/heads/master@{#43483} > Committed: https://chromium.googlesource.com/v8/v8/+/4deb9ffdecf121c69a3db7eae6698eae23a80a15 TBR=bbudge@chromium.org,gdeepti@chromium.org,bmeurer@chromium.org,jing.bao@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2717423003 Cr-Commit-Position: refs/heads/master@{#43489}
-
jing.bao authored
CreateInt32x4, Int32x4ExtractLane, Int32x4ReplaceLane Int32x4Add, Int32x4Sub Also add paddd and psubd to ia32-assembler BUG= Review-Url: https://codereview.chromium.org/2695613004 Cr-Commit-Position: refs/heads/master@{#43483}
-
- 13 Jul, 2016 1 commit
-
-
bbudge authored
- Adds move/swap handling for 4 and 16 bytes to ia32. - Register allocator now only requests 4 bytes for floats on ia32 and arm. - We probably need similar support in mips. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2027043002 Cr-Commit-Position: refs/heads/master@{#37714}
-
- 28 Jun, 2016 3 commits
-
-
epertoso authored
The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. Adds a regression test. BUG=621926 Committed: https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0 Review-Url: https://codereview.chromium.org/2103713003 Cr-Original-Commit-Position: refs/heads/master@{#37339} Cr-Commit-Position: refs/heads/master@{#37345}
-
epertoso authored
Revert of [ia32] Fixes a bug in cmpw. (patchset #3 id:40001 of https://codereview.chromium.org/2103713003/ ) Reason for revert: Causes "buildbot failure in V8 on V8 Linux gcc 4.8, Check" Original issue's description: > [ia32] Fixes a bug in cmpw. > > The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. > > Adds a regression test. > > BUG=621926 > > Committed: https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0 > Cr-Commit-Position: refs/heads/master@{#37339} TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621926 Review-Url: https://codereview.chromium.org/2106913002 Cr-Commit-Position: refs/heads/master@{#37342}
-
epertoso authored
The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. Adds a regression test. BUG=621926 Review-Url: https://codereview.chromium.org/2103713003 Cr-Commit-Position: refs/heads/master@{#37339}
-
- 24 May, 2016 1 commit
-
-
machenbach authored
For cross-compiler-compatibility and standards compliance %p requires a void*, rather than any pointer type. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2001073002 Cr-Commit-Position: refs/heads/master@{#36466}
-
- 19 May, 2016 3 commits
-
-
machenbach authored
Revert of Adding ia32 simd assembler changes. (patchset #2 id:20001 of https://codereview.chromium.org/1991713002/ ) Reason for revert: Crashes on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/2305/steps/Check/logs/stdio Also, would be nice if the test output could be a bit shorter and only print what's necessary to trace a failure. Or split things into more smaller tests. Like that, these logs must be processed, json-encoded/decoded and sent around through the infrastructure. Some chars in the output make the json encoder unhappy, therefore the infrastructure can't nicely display the failures. Original issue's description: > Adding ia32 simd assembler support. > > Based on assembler changes from this patch: > https://codereview.chromium.org/90643003/ > > BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 > R=titzer@chromium.org > LOG=N > > Committed: https://crrev.com/fbf58a5af1d07a7fbb3763aa15f8ba26e2ce7d11 > Cr-Commit-Position: refs/heads/master@{#36349} TBR=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,aseemgarg@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 Review-Url: https://codereview.chromium.org/1992163002 Cr-Commit-Position: refs/heads/master@{#36353}
-
bradnelson authored
Based on assembler changes from this patch: https://codereview.chromium.org/90643003/ BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 R=titzer@chromium.org LOG=N Review-Url: https://codereview.chromium.org/1991713002 Cr-Commit-Position: refs/heads/master@{#36349}
-
binji authored
Review-Url: https://codereview.chromium.org/1986113004 Cr-Commit-Position: refs/heads/master@{#36341}
-
- 03 May, 2016 1 commit
-
-
binji authored
https://codereview.chromium.org/1938213002 added xchg_b and xchg_w, but didn't add it to the disassembler, and there were no tests that caught it. BUG=v8:4614 TBR=bmeurer@chromium.org LOG=n Review-Url: https://codereview.chromium.org/1947673002 Cr-Commit-Position: refs/heads/master@{#35998}
-
- 15 Apr, 2016 1 commit
-
-
addaleax authored
The current code for testing the VEX.L flag, indicating whether 128-bit or 256-bit registers are being accessed, was erroneous and always returned true (i.e. indicated 128-bit registers). This patch fixes this behaviour and checks the flag correctly. Ref: https://github.com/nodejs/node/issues/6151 BUG= Review URL: https://codereview.chromium.org/1875323002 Cr-Commit-Position: refs/heads/master@{#35506}
-
- 12 Apr, 2016 1 commit
-
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 Reverted again in: https://codereview.chromium.org/1877823003 Reverts due to non-CQ bots: - First: v8_win_dbg, v8_win64_dbg, v8_mac_dbg - Second: gc mole (added to v8_linux_rel_ng for this patch) R= jochen@chromium.org TBR= ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1872203005 Cr-Commit-Position: refs/heads/master@{#35423}
-
- 11 Apr, 2016 2 commits
-
-
https://codereview.chromium.org/1877453002/machenbach authored
Reason for revert: Breaks gc mole: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/9421 Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > Original CL: https://codereview.chromium.org/1869433004 > Reverted in: https://codereview.chromium.org/1867383002 > > R= jochen@chromium.org > TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/bf505329288e1b75bab0e6800371a9aac40fa5cc > Cr-Commit-Position: refs/heads/master@{#35394} TBR=jochen@chromium.org,ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,jfb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1877823003 Cr-Commit-Position: refs/heads/master@{#35396}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 R= jochen@chromium.org TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Review URL: https://codereview.chromium.org/1877453002 Cr-Commit-Position: refs/heads/master@{#35394}
-
- 08 Apr, 2016 2 commits
-
-
jfb authored
Revert of Fix printf formats (patchset #8 id:140001 of https://codereview.chromium.org/1869433004/ ) Reason for revert: One small issue easily fixed here: https://codereview.chromium.org/1867333003/ But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful: Stderr: f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect format specifier", 0) It's easier to revert for now, I'll dig more into the docs: https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx And then resubmit, making sure I run these bots. Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d > Cr-Commit-Position: refs/heads/master@{#35365} TBR=jochen@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1867383002 Cr-Commit-Position: refs/heads/master@{#35366}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Review URL: https://codereview.chromium.org/1869433004 Cr-Commit-Position: refs/heads/master@{#35365}
-
- 21 Mar, 2016 1 commit
-
-
epertoso authored
This is in preparation for a CL that does the equivalent of http://crrev.com/1780193003 for ia32. BUG= Review URL: https://codereview.chromium.org/1815213002 Cr-Commit-Position: refs/heads/master@{#34925}
-