- 24 Jul, 2019 1 commit
-
-
Frank Tang authored
Add 'fluid-ounce','gallon', 'liter', and 'milliliter' Also roll ICU to 682a2309 Sync with https://github.com/tc39/proposal-unified-intl-numberformat/pull/48 Bug: v8:9475 Change-Id: If45a20f17f5973b860893b0f70e724cc93c6550a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1699759 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62903}
-
- 22 Jul, 2019 1 commit
-
-
Frank Tang authored
1. Fix formatToParts show "plusSign" for -0 by using signbit instead of < 0 2. Fix crash bug of formatToParts while notation is either "engineering" or "scientific". Bug: v8:9513 Change-Id: I36b0b995c157dc642b9c201694d0ac0bb0396988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710148 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#62856}
-
- 19 Jul, 2019 2 commits
-
-
Frank Tang authored
1. Sync with https://github.com/tc39/proposal-unified-intl-numberformat/pull/57 so the formatting of {style: "unit" unit: "percent"} and the formatting of {style: "percent:"} are treated different that simplified the algorithm. 2. Store style into bit flags because we need it quickly during format. 3. Add more unit tests and regression test. Bug: v8:9498 Change-Id: I75ed22fef1feb73ebf624bda70ebe45b80e7bc8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1704948Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#62834}
-
Frank Tang authored
Sync with https://github.com/tc39/proposal-unified-intl-numberformat/pull/54 Bug: v8:9483 Change-Id: I2aec5a78be235bddd4faa568665b73b9b84d7c93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700426Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#62819}
-
- 28 Jun, 2019 1 commit
-
-
Frank Tang authored
1. Move the reading of Notation before calling SetNumberFormatDigitOptions() ( sync after https://github.com/tc39/proposal-unified-intl-numberformat/pull/37) 2. Sync SetNumberFormatDigitOptions to the spec. 3. Consider the case that while RoundingType is "compact-rounding" do not set the precision. 4. correct the tests accordingly. 5. Fix the rounding of notation: "compact" and put regression cases into test/intl/regress-9408.js Bug: v8:9408 Change-Id: I78d66601fe21b1a74a50047b2abe6a2838a58b8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681599 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62450}
-
- 06 Jun, 2019 1 commit
-
-
Frank Tang authored
DesignDoc: https://goo.gl/ZAtL1f Chrome Status: https://www.chromestatus.com/feature/5430420699086848 I2I: http://shorturl.at/sE168 I2S: http://shorturl.at/qsHU9 Bug: v8:8518 Change-Id: Ib9d6ce4782c12745d3d44500991074646254621a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1639698 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62039}
-
- 21 May, 2019 1 commit
-
-
Frank Tang authored
Design Doc: https://goo.gl/ZAtL1f Bug: v8:8515 Change-Id: I543ab704fd3f8b41e396879ebbc581977ec0ff10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612325Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61709}
-
- 29 Apr, 2019 1 commit
-
-
Frank Tang authored
Implement ECMA402 PR https://github.com/tc39/ecma402/pull/175 Add numberingSystem option to NumberFormat And numberingSystem and calendar option to DateTimeFormat Bug: v8:9154 Change-Id: Ic4e85a232a9ad26c17ee20385f839b0e09a56c77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575919Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61061}
-
- 08 Jan, 2019 1 commit
-
-
Frank Tang authored
This is a PARTIAL reland of 8d094249 Only land the newly added tests files Original change's description: > [Intl] Validate u extension type > > Fix intl402/*/ignore-invalid-unicode-ext-values > Add tests for other valid/invalid -u- ext values. > > Bug: v8:7481 > Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 > Reviewed-on: https://chromium-review.googlesource.com/c/1351307 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58173} Bug: v8:7481 Change-Id: I0a1c5701ade330026e2cf7eb554c6390b048a68d Reviewed-on: https://chromium-review.googlesource.com/c/1396737Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58604}
-
- 03 Jan, 2019 1 commit
-
-
Frank Tang authored
This reverts commit 8d094249. Reason for revert: Cause Memory regression TBR=gsathya@chromium.org Original change's description: > [Intl] Validate u extension type > > Fix intl402/*/ignore-invalid-unicode-ext-values > Add tests for other valid/invalid -u- ext values. > > Bug: v8:7481 > Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 > Reviewed-on: https://chromium-review.googlesource.com/c/1351307 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58173} TBR=cira@chromium.org,jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7481 Change-Id: Idabf2183684f264271ebe2b8c0ca10ae8e30d811 Reviewed-on: https://chromium-review.googlesource.com/c/1393499Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58506}
-
- 12 Dec, 2018 1 commit
-
-
Frank Tang authored
Fix intl402/*/ignore-invalid-unicode-ext-values Add tests for other valid/invalid -u- ext values. Bug: v8:7481 Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 Reviewed-on: https://chromium-review.googlesource.com/c/1351307 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58173}
-
- 07 Dec, 2018 1 commit
-
-
Frank Tang authored
Simplified test for default locale under test/intl Remove GetDefaultLocale from runtime Move Intl::DefaultLocale from intl-object.h to internal function inside intl-object.cc Bug: v8:5751 Change-Id: I885abf30ff33d5213ee99c07ac1e92d3c5065d8b Reviewed-on: https://chromium-review.googlesource.com/c/1358022Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58081}
-
- 02 Dec, 2018 1 commit
-
-
Frank Tang authored
Also split out some order check tests. Bug: v8:5751 Change-Id: I1765d1809b456c43e21d9a379f720a0ea12e794e Reviewed-on: https://chromium-review.googlesource.com/c/1352283Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57988}
-
- 13 Sep, 2018 1 commit
-
-
Adam Klein authored
Also fix type-check to check receiver for JSReceiver, not JSObject, and add a test for DateTimeFormat verifying that it already has the proper behavior. Bug: chromium:881023 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I950c86094dfb9634e0b7e49bcbbb022fa81a71f7 Reviewed-on: https://chromium-review.googlesource.com/1225612 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55880}
-
- 11 Sep, 2018 1 commit
-
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I91a7305d82423d3a7b1d2fc44282b6116c4c746c Reviewed-on: https://chromium-review.googlesource.com/1208652 Commit-Queue: Ujjwal Sharma <usharma1998@gmail.com> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55805}
-
- 04 Sep, 2018 1 commit
-
-
Frank Tang authored
Bug: v8:7979 TBR: benedikt@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: I9d5181c15b56de3bc5288d11bd83e55157c7a610 Reviewed-on: https://chromium-review.googlesource.com/1168518 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55621}
-
- 31 Aug, 2018 1 commit
-
-
Sathya Gunasekaran authored
This makes us spec compliant. Bug: chromium:875643 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I489870495fe1d326991c99f0551fe3329268c984 Reviewed-on: https://chromium-review.googlesource.com/1199910 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55567}
-
- 11 Jul, 2018 1 commit
-
-
Jungshik Shin authored
See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 for ICU changes. Fix tests for ICU 61/Unicode 11/CLDR 33.1 * Update mjsunit/harmony/regexp-property-script-extensions.js per ScriptExtensions.txt in Unicode 11 * Update mjsunit/intl-numberformat-formattoparts.js for CLDR 33.1 * Mark an invalid Mozilla test (Georgian uppercasing) * Fix currency format test (U+00A0 instead of U+0020) * Enable Script_Extensions tests (test262) * Add support for Extended_Pictographic in regex Ref. https://github.com/tc39/ecma262/issues/1219. Bug: chromium:850334, v8:7825 Test: intl/*, test262/intl402/* Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I146080cdc1164db4a71f484918723cf302666df8 Reviewed-on: https://chromium-review.googlesource.com/1111857Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54376}
-
- 21 Apr, 2018 1 commit
-
-
Timothy Gu authored
With certain ICU data bundles (such as the Node.js "small-icu"), %GetDefaultICULocale() may return a more specific language tag (e.g. "en-US") than what's available (e.g. "en"). In those cases, consider the more specific language tag supported. This CL also resolves the following Node.js issue: https://github.com/nodejs/node/issues/15223 Bug: v8:7024 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73 Reviewed-on: https://chromium-review.googlesource.com/668350 Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52716}
-
- 07 Nov, 2017 1 commit
-
-
Jungshik Shin authored
Update the expected result for intl/number-format/format-currency to match the output of ICU 60/CLDR 32. Disable the test while ICU is rolled to ICU 60.1. This will be enabled once v8 picks up the ICU roll to 60.1. Bug: chromium:766816 Test: intl/numbuer-format/* Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Id6ffe149e9105ca050c6398d484437e1c88c2794 Reviewed-on: https://chromium-review.googlesource.com/756643Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49206}
-
- 14 Feb, 2017 1 commit
-
-
vabr authored
CreateNumberFormat of src/js/i18n.js implements http://www.ecma-international.org/ecma-402/1.0/#sec-11.1.1.1, but has a typo in step 33a. The spec says that the default value for minimumSignificantDigits should be 1, while the script set it to 0. This CL fixes that typo and adds a test for that. BUG=v8:5554 Review-Url: https://codereview.chromium.org/2694673003 Cr-Commit-Position: refs/heads/master@{#43197}
-
- 15 Sep, 2016 1 commit
-
-
littledan authored
This flag has been flipped off since 52, so it is due for removal. R=adamk@chromium.org,caitp@igalia.com BUG=v8:3785 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2268633002 Cr-Commit-Position: refs/heads/master@{#39435}
-
- 27 May, 2016 1 commit
-
-
jshin authored
intl/number-format/parse-percent.js intl/date-format/parse-mdyhms.js intl/number-format/parse-decimal.js intl/date-format/parse-MMMdy.js Also added a few more test cases. BUG=v8:3454 TEST=The tests listed above. Review-Url: https://codereview.chromium.org/1988073003 Cr-Commit-Position: refs/heads/master@{#36555}
-
- 12 May, 2016 1 commit
-
-
littledan authored
This patch removes the following properties, as their use count is very low, they are V8-only, and not on a standards track. - v8Parse - resolved - pattern v8BreakIterator is left in as it has significantly more usage. BUG=v8:3785 R=adamk,jshin@chromium.org Review-Url: https://codereview.chromium.org/1968893002 Cr-Commit-Position: refs/heads/master@{#36190}
-
- 24 Feb, 2016 1 commit
-
-
littledan authored
The Intl object used to keep around functions which are bound to the receiver and memoized in the object (as required by the ECMA-402 spec) in ordinary properties with names like __boundformat__. This patch instead stores those methods in private symbol properties, so they are not exposed to users. A search in GitHub didn't find any uses of __boundformat__ (whereas the same search found plenty of usages of other V8 Intl features), so I think this should be fine in terms of web compatibility. BUG=v8:3785 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1728823002 Cr-Commit-Position: refs/heads/master@{#34230}
-
- 22 Oct, 2015 1 commit
-
-
littledan authored
The patch in https://crrev.com/ddb5c2d999c5ee6e31c4a9599bb3ddb293cc3f49 moved all fractional digit settings to default values due to a coding error. These were not even correct default values, and users observed errors where percentages were written as "23.0%" instead of "23%". This patch fixes the setting propagation when appropriate and it changes the default max fractional digits of a percentage to 0, per spec. BUG=chromium:544122 R=mnita,jochen CC=hichris123,adamk LOG=Y Review URL: https://codereview.chromium.org/1420883002 Cr-Commit-Position: refs/heads/master@{#31468}
-
- 20 Jul, 2015 1 commit
-
-
yangguo authored
The choice for the symbol seems to be locale-dependent. R=jochen@chromium.org BUG=v8:4314 LOG=N Review URL: https://codereview.chromium.org/1238133003 Cr-Commit-Position: refs/heads/master@{#29750}
-
- 17 Jul, 2015 1 commit
-
-
hichris123 authored
NumberFormat previously just used a min of 0 digits after the decimal and a max of 3. This CL changes it so that we use the ICU currency data, and set the min and max to the number of numbers after the decimal point for each currency. This CL also fixes a small bug where if the minimum fraction digits is above 3 but the maximum fraction digits isn't set, then it returns with only three numbers after the decimal point. BUG=435465,473104,304722 LOG=Y Review URL: https://codereview.chromium.org/1231613006 Cr-Commit-Position: refs/heads/master@{#29734}
-
- 23 Jul, 2014 2 commits
-
-
jochen@chromium.org authored
The intl tests still fail locally. BUG=v8:3454 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/410083004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22558 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Update the following 4 intl tests after ICU 52 roll. date-format/parse-MMMdy.js date-format/parse-mdyhms.js number-format/parse-decimal.js number-format/parse-percent.js BUG=v8:3454 TEST=intl/* tests pass. LOG=Y R=jochen@chromium.org Review URL: https://codereview.chromium.org/410733003 Patch from Jungshik Shin <jshin@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Apr, 2014 3 commits
-
-
jochen@chromium.org authored
There were some tests that are supposed to protect against js messing with the meta data, however, they just didn't try hard enough. BUG=354967 R=dcarney@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=20375 Review URL: https://codereview.chromium.org/215293005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/220673002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
There were some tests that are supposed to protect against js messing with the meta data, however, they just didn't try hard enough. BUG=354967 R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/215293005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20375 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Aug, 2013 1 commit
-
-
jochen@chromium.org authored
It's now available via builtins. BUG=v8:2475 R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/21512002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16016 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jul, 2013 1 commit
-
-
jochen@chromium.org authored
BUG=v8:2745 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18687003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-