• Zhang, Shiyu's avatar
    [runtime] Do not add shadowing key for end prototype · a2e86bf6
    Zhang, Shiyu authored
    Shadowing key is used to exclude non-enumerable keys when iterating
    over the prototype chain. This CL skips adding shadowing key for
    end prototype to improve for-in performance. It can improve the
    performance of below microbench by ~50%.
    
    Object.prototype.foo = function() {};
    let obj = {
    	a:0,
    	b:1
    };
    let start = Date.now();
    for (let i = 0; i<1e6; i++) {
    	for (var j in obj) {}
    }
    console.log(Date.now() - start);
    
    This CL also improves the score of JetStream2-tagcloud-SP case
    by 8% on IA Chromebook.
    
    Contributed by tao.pan@intel.com
    
    Change-Id: I456082c08bf70f1f450ff54f657cdab26eb7bc2b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781113Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
    Cr-Commit-Position: refs/heads/master@{#63587}
    a2e86bf6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...