Skip to content

V
V8
Commit d9f4c84f authored by Jungshik Shin's avatar Jungshik Shin Committed by Commit Bot
Browse files
Options

Roll ICU to ICU 62.1 

See
  https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503
for ICU changes.

Fix tests for ICU 61/Unicode 11/CLDR 33.1

* Update mjsunit/harmony/regexp-property-script-extensions.js per
  ScriptExtensions.txt in Unicode 11
* Update mjsunit/intl-numberformat-formattoparts.js for CLDR 33.1
* Mark an invalid Mozilla test (Georgian uppercasing)
* Fix currency format test (U+00A0 instead of U+0020)
* Enable Script_Extensions tests (test262)
* Add support for Extended_Pictographic in regex

Ref. https://github.com/tc39/ecma262/issues/1219.

Bug: chromium:850334, v8:7825
Test: intl/*, test262/intl402/*
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I146080cdc1164db4a71f484918723cf302666df8
Reviewed-on: https://chromium-review.googlesource.com/1111857Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54376}
parent ebb7ac2b
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 337 additions and 423 deletions
DEPS
View file @ d9f4c84f
......@@ -18,7 +18,7 @@ deps = {
'v8/third_party/depot_tools':
Var('chromium_url') + '/chromium/tools/depot_tools.git' + '@' + 'c3975e55e1465d9d9320ae67889f0b057c7d7ec3',
'v8/third_party/icu':
Var('chromium_url') + '/chromium/deps/icu.git' + '@' + '172d33141cd16df9d027cfd49bfe940b1dc66f1a',
Var('chromium_url') + '/chromium/deps/icu.git' + '@' + 'a9a2bd3ee4f1d313651c5272252aaf2a3e7ed529',
'v8/third_party/instrumented_libraries':
Var('chromium_url') + '/chromium/src/third_party/instrumented_libraries.git' + '@' + '323cf32193caecbf074d1a0cb5b02b905f163e0f',
'v8/buildtools':
......
src/regexp/regexp-parser.cc
View file @ d9f4c84f
......@@ -1291,6 +1291,9 @@ bool IsSupportedBinaryProperty(UProperty property) {
case UCHAR_EMOJI_MODIFIER_BASE:
case UCHAR_EMOJI_MODIFIER:
case UCHAR_EMOJI_PRESENTATION:
#if U_ICU_VERSION_MAJOR_NUM >= 62
case UCHAR_EXTENDED_PICTOGRAPHIC:
#endif
case UCHAR_EXTENDER:
case UCHAR_GRAPHEME_BASE:
case UCHAR_GRAPHEME_EXTEND:
......
test/intl/number-format/format-currency.js
View file @ d9f4c84f
......@@ -12,7 +12,7 @@ assertEquals("$54,306.40", nf_USD.format(parseFloat(54306.4047970)));
var nf_JPY = new Intl.NumberFormat(['ja'],
{style: 'currency', currency: 'JPY', currencyDisplay: "code"});
assertEquals("JPY54,306", nf_JPY.format(parseFloat(54306.4047970)));
assertEquals("JPY\u00a054,306", nf_JPY.format(parseFloat(54306.4047970)));
var nf_EUR = new Intl.NumberFormat(['pt'], {style: 'currency', currency: 'EUR'});
......
test/mjsunit/intl-numberformat-formattoparts.js
View file @ d9f4c84f
......@@ -60,7 +60,7 @@ if (this.Intl) {
var usDollarsCode = new Intl.NumberFormat("en-US", usdCodeOptions);
assertParts(usDollarsCode, 25,
[Currency("USD"), Integer("25")]);
[Currency("USD"), Literal("\u00a0"), Integer("25")]);
// ISO 4217 currency codes are formed from an ISO 3166-1 alpha-2 country code
// followed by a third letter. ISO 3166 guarantees that no country code
......@@ -79,7 +79,7 @@ if (this.Intl) {
var xqqMoneyCode = new Intl.NumberFormat("en-US", xqqCodeOptions);
assertParts(xqqMoneyCode, 25,
[Currency("XQQ"), Integer("25")]);
[Currency("XQQ"), Literal("\u00a0"), Integer("25")]);
// Test currencyDisplay: "name".
var usdNameOptions =
......@@ -187,7 +187,7 @@ if (this.Intl) {
PercentSign("%")]);
assertParts(usPercentFormatter, NaN,
[Nan("NaN")]);
[Nan("NaN"), PercentSign("%")]);
assertParts(usPercentFormatter, Infinity,
[Inf("∞"), PercentSign("%")]);
......
test/mozilla/mozilla.status
View file @ d9f4c84f
......@@ -122,6 +122,10 @@
# (https://chromium-review.googlesource.com/c/546941#message-5dc0f5efe277388501e8870e39ec70383dfc7db8)
'js1_5/Scope/regress-185485': [FAIL],
# Georgina is bicameral as of Unicode 11, but the test assumes that it's unicameral.
# no_i18n build has an old ICU data and Georgian is treated as unicameral.
'ecma/String/15.5.4.12-3': [FAIL, ['no_i18n == True', PASS]],
##################### SKIPPED TESTS #####################
# This test checks that we behave properly in an out-of-memory
......
test/test262/test262.status
View file @ d9f4c84f
......@@ -388,123 +388,6 @@
'built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller': [FAIL_SLOPPY],
'built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments': [FAIL_SLOPPY],
# ICU < 62 doesn't support Unicode v11.
# TODO(mathias): Re-enable these after we've updated to ICU 62.
# https://bugs.chromium.org/p/v8/issues/detail?id=7825
'built-ins/RegExp/property-escapes/generated/Alphabetic': [SKIP],
'built-ins/RegExp/property-escapes/generated/Assigned': [SKIP],
'built-ins/RegExp/property-escapes/generated/Bidi_Mirrored': [SKIP],
'built-ins/RegExp/property-escapes/generated/Cased': [SKIP],
'built-ins/RegExp/property-escapes/generated/Case_Ignorable': [SKIP],
'built-ins/RegExp/property-escapes/generated/Changes_When_Casefolded': [SKIP],
'built-ins/RegExp/property-escapes/generated/Changes_When_Casemapped': [SKIP],
'built-ins/RegExp/property-escapes/generated/Changes_When_Lowercased': [SKIP],
'built-ins/RegExp/property-escapes/generated/Changes_When_NFKC_Casefolded': [SKIP],
'built-ins/RegExp/property-escapes/generated/Changes_When_Titlecased': [SKIP],
'built-ins/RegExp/property-escapes/generated/Changes_When_Uppercased': [SKIP],
'built-ins/RegExp/property-escapes/generated/Diacritic': [SKIP],
'built-ins/RegExp/property-escapes/generated/Emoji': [SKIP],
'built-ins/RegExp/property-escapes/generated/Emoji_Component': [SKIP],
'built-ins/RegExp/property-escapes/generated/Emoji_Modifier_Base': [SKIP],
'built-ins/RegExp/property-escapes/generated/Emoji_Presentation': [SKIP],
'built-ins/RegExp/property-escapes/generated/Extended_Pictographic': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Cased_Letter': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Currency_Symbol': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Decimal_Number': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Format': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Letter': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Lowercase_Letter': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Mark': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Nonspacing_Mark': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Number': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Letter': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Number': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Punctuation': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Symbol': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Punctuation': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Spacing_Mark': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Symbol': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Unassigned': [SKIP],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Uppercase_Letter': [SKIP],
'built-ins/RegExp/property-escapes/generated/Grapheme_Base': [SKIP],
'built-ins/RegExp/property-escapes/generated/Grapheme_Extend': [SKIP],
'built-ins/RegExp/property-escapes/generated/ID_Continue': [SKIP],
'built-ins/RegExp/property-escapes/generated/Ideographic': [SKIP],
'built-ins/RegExp/property-escapes/generated/ID_Start': [SKIP],
'built-ins/RegExp/property-escapes/generated/Lowercase': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Ahom': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Arabic': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Armenian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Bengali': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Bopomofo': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Chakma': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Common': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Devanagari': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Dogra': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Ahom': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Arabic': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Armenian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Bengali': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Bopomofo': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Chakma': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Common': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Devanagari': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Dogra': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Georgian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Grantha': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Gunjala_Gondi': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Gurmukhi': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Han': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Hanifi_Rohingya': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Hebrew': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Kaithi': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Kannada': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Kharoshthi': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Khojki': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Latin': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Makasar': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Malayalam': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Medefaidrin': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Mongolian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Newa': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Nko': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Old_Sogdian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Oriya': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Sogdian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Soyombo': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Tamil': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Tangut': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Telugu': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Tirhuta': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Georgian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Gunjala_Gondi': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Gurmukhi': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Han': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Hanifi_Rohingya': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Hebrew': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Inherited': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Kaithi': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Kannada': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Kharoshthi': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Latin': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Makasar': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Medefaidrin': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Mongolian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Newa': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Nko': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Old_Sogdian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Sogdian': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Soyombo': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Tangut': [SKIP],
'built-ins/RegExp/property-escapes/generated/Script_-_Telugu': [SKIP],
'built-ins/RegExp/property-escapes/generated/Sentence_Terminal': [SKIP],
'built-ins/RegExp/property-escapes/generated/Terminal_Punctuation': [SKIP],
'built-ins/RegExp/property-escapes/generated/Unified_Ideograph': [SKIP],
'built-ins/RegExp/property-escapes/generated/Uppercase': [SKIP],
'built-ins/RegExp/property-escapes/generated/XID_Continue': [SKIP],
'built-ins/RegExp/property-escapes/generated/XID_Start': [SKIP],
# https://bugs.chromium.org/p/v8/issues/detail?id=7874
'built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment