1. 27 May, 2022 2 commits
  2. 25 May, 2022 1 commit
  3. 24 May, 2022 1 commit
  4. 19 May, 2022 1 commit
  5. 18 May, 2022 2 commits
    • Seth Brenith's avatar
      [v8windbg] Skip undefined types in Torque structs · 3a558456
      Seth Brenith authored
      The test cctest/test-v8windbg recently started failing because the
      v8windbg debugger extension is unable to read the "flags" field on a
      SharedFunctionInfo instance. This occurs because one of the bitfields
      within "flags" has type OSRCodeCacheStateOfSFI, which is only declared
      using an "opaque enum declaration":
      
        enum OSRCodeCacheStateOfSFI : uint8_t;
      
      When WinDbg fails in its attempt to look up that type, v8windbg responds
      by failing to construct anything at all for "flags". However, the other
      17 bitfields in "flags" can be represented successfully, so a more
      useful behavior is to just skip the one failed entry.
      
      Change-Id: I40630548d21499e49f0214da28260318a38d9360
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3653096Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
      Cr-Commit-Position: refs/heads/main@{#80615}
      3a558456
    • Almothana Athamneh's avatar
      Revert "Change linux_chromium_chromeos_msan_rel_ng to blocking on auto roll" · c3107f06
      Almothana Athamneh authored
      This reverts commit e412e643.
      
      Reason for revert: builder takes too long on CQ
      
      Original change's description:
      > Change linux_chromium_chromeos_msan_rel_ng to blocking on auto roll
      >
      > Bug: v8:12755
      > Change-Id: I7c693c07640fd5952047666063f23b4be77692bd
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644954
      > Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Auto-Submit: Almothana Athamneh <almuthanna@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#80590}
      
      Bug: v8:12755
      Change-Id: I371c4ebbfc9dc9a0e806653c6c819b0eb29e5228
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644962
      Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Auto-Submit: Almothana Athamneh <almuthanna@chromium.org>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/main@{#80610}
      c3107f06
  6. 17 May, 2022 4 commits
  7. 13 May, 2022 2 commits
  8. 12 May, 2022 1 commit
    • Jakob Kummerow's avatar
      Revert "[tools] Add a simple gdb frame unwinder" · a5906c24
      Jakob Kummerow authored
      This reverts commit c3ac338b.
      
      Reason for revert: Breaks stepping with `n`
      
      Original change's description:
      > [tools] Add a simple gdb frame unwinder
      >
      > Add a simple unwinder for gdb which, on x64,  walks frame pointers
      > whenever there is no source information available. Ideally we would only
      > do this for V8 PCs but this appears hard to do in an Unwinder without
      > messing with gdb's internal assumptions.
      >
      > Change-Id: Iba1e62a3768340ee912e81d691237c1920a8ae91
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3608628
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#80204}
      
      Change-Id: I0264cf34cfe8fe2331bacf202dedbb4706535936
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644855
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80493}
      a5906c24
  9. 11 May, 2022 2 commits
  10. 10 May, 2022 2 commits
  11. 09 May, 2022 3 commits
  12. 03 May, 2022 5 commits
  13. 02 May, 2022 1 commit
    • Camillo Bruni's avatar
      [tools] Add variants support for run_perf.py · a42a2f41
      Camillo Bruni authored
      We usually run benchmarks in multiple variants: default, future, noopt
      This is currently only achieved by copying the run-perf json file and
      changing the flags at the top-level (or copy whole subsections).
      
      Using "variants" we can duplicate the tests at the current level with
      different values and easily create benchmarks that differ only in v8
      flags.
      
      Drive-by-fix:
      - Add Node.__iter__ and log the whole config graph in debug mode
      - Add GraphConfig.__str__ method for better debugging
      - Rename TraceConfig to LeafTraceConfig
      - Rename RunnableTraceConfig to RunnableLeafTraceConfig
      - Make --filter accept a regexp to better filter out variants
      
      Bug: v8:12821, v8:11113
      Change-Id: I56a2ba2dd24da15c7757406e9961746219cd8061
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596128Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80307}
      a42a2f41
  14. 29 Apr, 2022 1 commit
    • George Wort's avatar
      Make profile-guided optimization of builtins more configurable · 0e127bce
      George Wort authored
      Introduce get_hints.py and combine_hints.py in order to make
      the interpretation of basic block counts into hints more
      configurable and explicit, as well as allowing more accurate
      and consistent methods of combining multiple profiles.
      
      get_hints.py allows for the minimum count and threshold ratio
      values to be easily altered for different profiles, while
      combine_hints.py allows the hints produced from different
      benchmarks and threshold values to be easily and sensibly
      combined.
      
      Simply summing together basic block counts from different
      benchmarks could previously lead to a longer running benchmark
      overshadowing multiple shorter benchmarks with conflicting
      hints.
      
      Allowing alteration of the current threshold values gives a
      doubling of performance, while the new method of combining
      distinct profiles can double the performance improvement of the
      secondary benchmark while losing as little as 4% of the
      improvement gained in the primary benchmark.
      
      Design doc: https://docs.google.com/document/d/1OhwZnIZom47IX0lyceyt-S9i8AApDB0UqJdvQD6NuKQ/edit?usp=sharing
      
      Bug: v8:10470
      Change-Id: I1c09d1eabfdda5ed6794592e2c13ff8b461be361
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545181Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Commit-Queue: George Wort <george.wort@arm.com>
      Cr-Commit-Position: refs/heads/main@{#80282}
      0e127bce
  15. 28 Apr, 2022 1 commit
  16. 27 Apr, 2022 2 commits
  17. 26 Apr, 2022 2 commits
    • Camillo Bruni's avatar
      [tools][system-analyzer] Add profiler-panel · 7a90c320
      Camillo Bruni authored
      Add basic profiler support
      - Moved profiling-related helpers to profiling.mjs
      - Added bottom-up profiler table
      - Added mini-timeline overview wit opt/deopt events and usage graph
      - Added flame-graph, pivoted on the currently selected function
      
      Drive-by-fixes:
      - Added/updated jsdoc type information
      - Fixed static symbols (builtins, bytecodehandlers) that were both
        added by the CppEntriesProvider and from code-events in the v8.log
      - Support platform-specific (linux/macos) dynamic symbol loader by
        adding a query path ('/v8/info/platform') to lws-middleware.js
      - added css var --selection-color
      
      Bug: v8:10644
      Change-Id: I6412bec63eac13140d6d425e7d9cc33316824c73
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585453Reviewed-by: 's avatarPatrick Thier <pthier@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80192}
      7a90c320
    • Shu-yu Guo's avatar
      [ShadowRealm] Look for importValue("path/to/file" patterns for test sync · ef82f4dd
      Shu-yu Guo authored
      ShadowRealm.prototype.importValue dynamically imports other files, so
      the testing infrastructure need to look for these calls to gather files
      to push to e.g. test devices.
      
      The reason to do this over explicit Resources: comment lines is to also
      cover test262.
      
      Bug: v8:12829
      Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng
      Change-Id: I6a06933d5da849157b2c7d5fa6b7b98d39f7d39f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3606391Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Shu-yu Guo <syg@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80189}
      ef82f4dd
  18. 25 Apr, 2022 4 commits
  19. 22 Apr, 2022 3 commits