- 26 Feb, 2020 18 commits
-
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: Iaf1399a0ccc94f8f96cfdab4364eb918d58659d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073758Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#66455}
-
Clemens Backes authored
1) Merge |AddBaselineCompilationUnits| into |InitializeRecompilationProgress|. 2) Rename |InitializeRecompilationProgress| to |InitializeRecompilation|. 3) Unify the update of |ReachedRecompilationTierField| in |compilation_progress_|. R=ahaas@chromium.org CC=duongn@microsoft.com Bug: v8:9654 Change-Id: I58324b553bf226cacb355e387c235841fdea82d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071863 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#66454}
-
Marcin Wiącek authored
Before: running different suites is removing non-related master data After: different suites have separate master data files Change-Id: Iab46d663fdf2a1d709aeb7da77a443c2ed1bdcc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071870Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#66453}
-
Georg Neis authored
This reverts commit b12ba06e. Reason for revert: After further discussion we decided to stick with fdlibm. Original change's description: > [builtins] stop using imprecise fdlibm pow > > This CL reinstates the old pow implementation which calls out to the > system implementation of pow. > > Bug: v8:9622 > Change-Id: I3df997888ced3fb8b5bd4b810098e967649aaa55 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1774898 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66303} TBR=yangguo@chromium.org,neis@chromium.org,hpayer@chromium.org,me@gus.host # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9622 Change-Id: I941f70c7432cd2fab86e0eadcb2e1a9ec8195e91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072746 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#66452}
-
Clemens Backes authored
This extends EnumSet by 1) adding element-wise operations (without first creating an EnumSet of that element in the caller), 2) adding arithmetic assignment operators, and 3) adding a subtraction operation which removes all elements in another EnumSet, or a single element. R=mlippautz@chromium.org Change-Id: Ibe694e9e111e506ad09cf9729fa0b0ba38430b79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071874 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#66451}
-
Clemens Backes authored
In {InitializeRecompilationProgress}, we already have logic in place to call the callback (all callbacks really) if no compilation units were added. In that case, the callback in fact does not need to be added to the list of callbacks. Instead, it's enough to just call this one callback and then discard it. R=ahaas@chromium.org Bug: v8:9654 Change-Id: I60bab2d67d67d10964404d897d13ffd628ff9964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071861 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Georg Neis authored
This reverts commit 73f91a2d. Reason for revert: Reverting b12ba06e Original change's description: > [builtins] Replace V8_INFINITY with its definition > > V8_INFINITY is not defined here. > "src/common/globals.h" is also not allowed to be included > in this source file. > > Change-Id: Ia3b14db8ac5099b6ce65839eb0fc59340dc59555 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062930 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#66336} TBR=neis@chromium.org,clemensb@chromium.org,me@gus.host,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia43c3f7f735dfb622d4f5464a52a142d19ddeb26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072745Reviewed-by:
-
Emanuel Ziegler authored
Added a type field to elements to distinguish anyref, funcref and nullref elements and do a proper type checking at compile time as the spec requires. R=ahaas@chromium.org Change-Id: I31be7aa1170439859ca7ec5e20aabb2720c290b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069330 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Clemens Backes authored
EnumSet hold a single integral field, hence it should be passed by value. All users already do this, we are just inconsistent within the declaration of EnumSet itself. R=mlippautz@chromium.org Change-Id: Ic2cac35fbd8fe3e98c1fe135bd334547dca30ab5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071872Reviewed-by:
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: I0773d60e5cd3d3b181446c11943eb19d5336b420 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066982 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This CL fixes two unrelated issues in Turbofan that contributed to non-determinism: - Most importantly, external references included their address in the node hash, but they're unpredictable due to ASLR. Fix by only looking at the lowest bits assuming a 4K page size. - BranchElimination didn't properly trigger revisits for the IfTrue/IfFalse projections. Bug: chromium:1046815 Change-Id: I9ba3535cc748890708e4638017e245a3f4e2a7d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069332 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=yangguo@chromium.org Change-Id: Icafeeccdcbe854d6986d3930ec6fcb2c856d274a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072743 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#66444}
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/31f1bb5a..6d4b62614 Bug: v8:7834 Change-Id: Iecb139feb3db4001bc87d662f5acc006a521caad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073380 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#66443}
-
Ng Zhi An authored
Implements i8x16.abs, i16x8.abs, and i32x4.abs. Bug: v8:10233 Change-Id: I350ceca7ee75037615985ea955c5f17997996aac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067842 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#66442}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/11be0fc..9dba72c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8fd825d..d2b5e78 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9aa1a96..227d510 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/493c55d..2457e41 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/9f40209..49ee7b1 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8085056f080300b80449bc2ec186acc37746a9ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073019Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#66441}
-
Ng Zhi An authored
Implements i8x16.abs, i16x8.abs, and i32x4.abs. Bug: v8:10233 Change-Id: Iefe3c70bdc229c6da6a0ef07273ca654ca1e937e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063200Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Move load splat and load extend ops into the list of SIMD memory opcodes, since they similarly take an i32 and an memarg. This fixes the OpcodeLength calculation in function-body-decoder-impl.h. And in turn, fixes the mjsunit test code that the fuzzer generates. See the regress-1055692.js file for the weird S8x16LoadSplat followed by 2 kExprUnreachable, where the kExprUnreachable really is a memarg {0x0, 0x0}. This bug was caught by the fuzzer, and that was the generated test (with small fixes to add kExprDrop), so leaving it as it is. Bug: chromium:1055692 Change-Id: I743b6beb82350b5fea22c8dd10b546a02741cfed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071401Reviewed-by: -
Ng Zhi An authored
FMA tests that are running on Liftoff can use fused results, since the tests will fall back to TurboFan. Bug: v8:9415 Change-Id: I02edea5ce1447263f7bc7574573418b0055aef8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063202Reviewed-by:
-
- 25 Feb, 2020 21 commits
-
-
Shu-yu Guo authored
The deprecated legacy FinalizationGroup APIs are left unchanged for compat. Bug: v8:8179 Change-Id: I9bdcaa92360db318c96fc8524c04163ece25118e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071236 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#66437}
-
Milad Farazmand authored
LoadMem already does the proper sign extension based on the passed memtype, so all is left is splatting it to the desired number of lanes. Change-Id: I54317b6e2b4d3daf2e980315198577f61c3f556a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2068031Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port cc12e947 R=georgia.kouveli@arm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I58e35c6fc007b01db4a51f93bff995ce8c14c37a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071512Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66435}
-
Z Nguyen-Huu authored
We want to be consistent with wasdk/wasmparser. The names used in V8 should follow the WAT convention and always start with a dollar, both for names from the "names" section as well as generated names. Bug: v8:10242 Change-Id: If4dbd4c38208c9dd9377dd2f79120635a531d881 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070637 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#66434}
-
Clemens Backes authored
This extends the existing test to also print scope information on every break. Note that the currently printed information is not correct, since register values are not reconstructed yet. We just always print {-11} for register values. Thus the expected output will change with follow-up CL. R=thibaudm@chromium.org Bug: v8:10222 Change-Id: I7be13ecb02957454c875a4280cec154a08c2deb7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062403Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66433}
-
Victor Gomes authored
Context: This is part of a bigger CL: https://chromium-review.googlesource.com/c/v8/v8/+/2043840 In order to get rid of the arguments adaptor frame, we will reverse the JS arguments in the stack. Some macros will need to reverse its arguments as well, we will do that using helper macros in another CL (see src/builtins/builtins-descriptors.h in 2043840). For that we need to stringify the name kDontAdaptArgumentsSentinel, which cannot be done if '::' is in its name. This CL should not have any impact performace/memory on V8. Bug: v8:10201 Change-Id: If76b7f457c179fbddddfe1a0ae038d2f1210ad2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066969Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66432}
-
Andreas Haas authored
This is a reland of 03d5a7ba Nothing changed here compared to the original test. The tests on the blink side were invalid, I fixed them in https://crrev.com/c/2066907. Original change's description: > [wasm] The name of a custom section can cause a validation error > > The WebAssembly spec defines that the name of a custom section can cause > a validation error. The streaming decoder, however, used a separate > Decoder object to decode the name, and thereby avoided a validation > error. With this CL the streaming decoder uses the main decoder to > decode the name of the custom section. > > In addition this CL removes the test mjsunit/regress/wasm/regress-789952. > This test defined an invalid WebAssembly module and expected it to > compile. As it is a regression test, it makes no sense to fix the test. > The module is invalid because it defines the length of the custom section > to be '0', so there are no bytes in the custom section for its name. > > R=clemensb@chromium.org > CC=thibaudm@chromium.org > > Bug: v8:10126 > Change-Id: I8cfc77c9a5916570d5362d5922e0179a29774da8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2041446 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66348} Bug: v8:10126 Change-Id: I48aaed8eb9899da1703030fb6809fe46a6e66191 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069325 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Omer Katz authored
This reverts commit 6cfba48b. Reason for revert: Removing dynamic parameter caused regressions for scavenger. Original change's description: > [heap] Align v8 and oilpan worklists > > This CL makes the following changes: > 1) Size of allocated buffer is set by a template parameter > (with a default value instead of hardcoded size) > 2) Remove dynamic parameter for initializing number of > tasks (see comment in scavenger.cc) > > This CL aligns the v8 and oilpan heaps so that they provide > the same interface and functionality. > > Change-Id: I77d63793f0a54ea29198ddd6bd298eae2c15cf42 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2030920 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66158} TBR=ulan@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iab127d59882ded33d0df3897326031bfc2d2aaf2 Bug: chromium:1052750 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071862 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: Ic9ef9ba35218450d3f9e7838890c82b785c34da4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2037433 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10155 Change-Id: Ia89724ed5f8af4199bbce41ed12a0dace578c43f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069326Reviewed-by:
-
Camillo Bruni authored
The newly introduced --rcs-cpu-time flag enables CPU time for all runtime call stats timers. By default we still keep on using good old wall time. This CL also adds the long-awaited --rcs short flag. Change-Id: I3173e3a0f846ec3bf0d319624a37741c56914be5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060304Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#66427}
-
Mythri A authored
We use the same interrupt to both allocate feedback vectors and for updating the profiler ticks. If there is a feedback vector already available, we just increment the profiler ticks that we use to mark for optimizing function. Calling JSFunction::EnsureFeedbackVector allocates a feedback vector, but doesn't reset the budget, so we optimize much earlier than expected. This is currently only a problem with %PrepareFunctionForOptimize that doesn't reset the budget. Other code paths do also reset the interrupt budget. Bug: chromium:10243 Change-Id: I611a9202e5e71077bf897def5959bcfe11b8fdf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064980 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Mike Stanton authored
CL Reland "[turbofan] Fast API calls from TurboFan https://chromium-review.googlesource.com/c/v8/v8/+/2066971 had an off-by-one error in simplified lowering for fast api calls. Bug: chromium:1052746 Change-Id: I31bed7d1bb9564c6991521e84fd1a8edad6d0e32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071259 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a reland of 78defee4 Original change's description: > [inspector] Check that wasm wrappers appear in profiles > > This extends the existing wasm profiling test to also check that > wasm-to-js and js-to-wasm wrappers appear in the profiles as expected. > It thus serves as a regression test for the status quo. > > R=bmeurer@chromium.org > > Bug: chromium:1054386 > Change-Id: I5d4d8e6a252c6eb266b910621fca43a6ff0837bd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066970 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66401} TBR=bmeurer@chromium.org Bug: chromium:1054386, v8:10266 Change-Id: Iae04c0564ee8f0330d61ce954d895a41497c5a85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071260Reviewed-by:
-
Ng Zhi An authored
This is a reland of 548fda4a regress-1054466 is modified to not use 64x2 operations, since that was causing problems on noavx/nosse builds, which requires scalar lowering, and scalar lowering for 64x2 ops is not implemented. Original change's description: > [liftoff] Check fp_pair when looking up register for reuse > > Given two registers that are both not gp_pair, one could be an fp_pair, > and the other not, and we will incorrect call == on them. The current > check needs to be expanded to check that both registers are fp_pair. > > Bug: chromium:1054466 > Change-Id: Ib986c002a8a5cadb9668458597a797cecfd971b1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070006 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66402} Bug: chromium:1054466 Change-Id: If88f1ff2fb17aaa3727758cda5b368be1c6d9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071396Reviewed-by:
-
Georgia Kouveli authored
Change-Id: I22a6d25fb1d7b8e0db13df4a0be46d2f4104d20c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064394Reviewed-by:
-
Dan Elphick authored
Makes RoundIntPtrToFloat64 return TNode<Float64T> instead of Node*. Bug: v8:10155 Change-Id: I1edd5456b2b86b264b66eeab5e46ceb2a1f0170f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064978 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL generalizes the lowering of special CallDescriptors in the int64-lowering. The reason is a planned extension of the special handling due to a refactoring of the AtomicWait implementation. R=jkummerow@chromium.org Bug: v8:10108 Change-Id: I48d0087e2ad00ba9b44c5198ffdbbae8eb575a85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069333Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#66420}
-
Richard Townsend authored
Because this code is compile-time gated, it's bit-rotted as new functions have come along. This patch brings things back to parity with x86/x64. Bug: v8:10012 Change-Id: Iba4cd1155a1ae46742ecddbed96f36938a10db48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066973Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#66419}
-
Camillo Bruni authored
Bug: v8:9344 Change-Id: Iee66fc27b9f1c45ac3ac09dd82d88926414cc8f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2061558Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/49d87d5..11be0fc Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/feb2d0c..ef2f1b3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/672b17e..8fd825d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1773f37..9aa1a96 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I22baa6ba92b307d8c282364eb694704dcff06509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070999Reviewed-by:
-
- 24 Feb, 2020 1 commit
-
-
Shu-yu Guo authored
Renaming the JS-visible identifiers and strings is left for a future CL. FinalizationGroup was renamed at Feb 2020 TC39, to better signal that if a FinalizationRegistry dies, the finalization actions registered with it may no longer be performed. Bug: v8:8179 Change-Id: I0d676a71a4a67d2b7175994a67458a6158065844 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2055381Reviewed-by:
-
