- 10 Feb, 2022 7 commits
-
-
Dominik Inführ authored
We need to create the CodePageCollectionMemoryModificationScope *after* setting up the LocalIsolate. Otherwise the destructor of that scope will run after that thread detached from the isolate, when it isn't part of the next GC safepoint anymore. This allows two concurrent operations on the page flags: 1) The destructor of CodePageCollectionMemoryModificationScope protects the page again and accesses page flags in a DCHECK. 2) The GC unprotects the code pages for the collection and sets the the evacuation candidate flag. Bug: chromium:1295738 Change-Id: I6de626bb075f43e26d74dba18e28fe34331fdfd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3451714 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79025}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Id4273832d6d48d5a516a04982afcdf92b2cf045d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447366Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79024}
-
Dominik Inführ authored
This is a reland of 4b8f1b1c After landing https://crrev.com/c/3447371, we can reland this CL as-is correctness-wise. What's new in this CL is that we now treat references from client objects into the shared heap as roots for the --track-retaining-path feature. Original change's description: > Reland "[heap] Support client-to-shared refs in Code objects" > > This is a reland of 12e46091 > > Original change's description: > > [heap] Support client-to-shared refs in Code objects > > > > Support references from code objects in the client heaps to shared heap objects. Such references are stored in a remembered set during marking, which is later used for updating pointers. > > > > Bug: v8:11708 > > Change-Id: I8aeb508ddd14514ca65fa5acf3030dd8c2040168 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401588 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#78819} > > Bug: v8:11708 > Change-Id: I47bcf44b452fcffe8675fba03244b736ede14247 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3422630 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78838} Bug: v8:11708 Change-Id: I5b48e942fa469eabb40e797e221d06c25af16443 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3425358Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79023}
-
Dominik Inführ authored
--shared-string-table assumes that all old strings are in the shared heap. However, when also using --expose-gc we create an external string for the GC function name. So far external strings are always allocated in the local old space though, which results in a heap verification error. This CL creates external string in the shared old heap with --shared-string-table enabled. In order to pass all the tests this CL also has to: * Stop marking into the shared heap for VisitEmbeddedPointer and VisitCodePointer. * Relax DCHECK in String::GetFlatContent: We cannot check the thread id for any shared string. Even if that string isn't really shared atm. Bug: v8:11708 Change-Id: I51fec5ba038d035be5fe5e1277ef9286efc8dc2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447371Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79022}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a4e7e5a..96cf77d Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/2a745cc..169eef5 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/a18d792..53a6cf1 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/b86911d..107cd56 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/25f38be..954eec7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cc0f7a5..ff8a62f Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/43efa0a..06519ce Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3fc7923..14f4303 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d7bcddc..c7ca87f R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7c8070fa5f42d7a3fe22b674e73050b1c527d7e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3450174 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79021}
-
Milad Fa authored
Change-Id: If7a0742b694d3dc475442a6aee3f6c967291eda1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3451360Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79020}
-
Liu Yu authored
StoreArgsInStackSlot sometimes does unaligned store. Relate to commit 18469ec4. In MemoryFill, size is an 8-byte integer, but is stored into a 4-byte aligned memory; Bug: v8:10949, chromium:1281995 Change-Id: I9f18a0168432cdd6d27eacc98b980fa5b6d57d79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447932Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Yu Liu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#79019}
-
- 09 Feb, 2022 16 commits
-
-
Milad Fa authored
Change-Id: I346ff7d125027caeb14cbfead74eba0bd30c6f2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3450900Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79018}
-
Seth Brenith authored
When the debugger is active and a Promise begins executing, Isolate::PushPromise adds a global handle for that Promise. If the debugger is no longer attached when the Promise finishes executing, then there is no corresponding call to PopPromise which would clean up the global handle. To avoid leaking memory in that case, we should clean up the Promise stack when detaching the debugger. Bug: v8:12613 Change-Id: I47a2c37713b43b482e23e2457e96fba5f52623f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448949Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79017}
-
Manos Koukoutos authored
Bug: v8:12607 Change-Id: I937366634f77648bb76e36934c5a2952fb0e184f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3450422Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79016}
-
Manos Koukoutos authored
As a temporary solution to reenable wasm-gc fuzzing, we modify {WasmModuleBuilder} to optionally wrap all types in a recursive group. Bug: v8:7748 Change-Id: Ib0f8ab17c48ecbe04b51da2b1d01502be77ad35a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3450414Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79015}
-
Michael Lippautz authored
Move on-allocation and on-move events to a designated tracker that is only installed when running with debugging flags. This eliminates a bunch of flag checks as they are all moved behind the allocation trackers. Bug: v8:12615 Change-Id: Ied6819991511328351825e2341375c36ae34916b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3450419Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79014}
-
Tamer Tas authored
R=machenbach@chromium.org,liviurau@chromium.org,alexschulze@chromium.org Bug: v8:12610 Change-Id: I24a1af48bf7a748e06c719439fb368ad75dd0160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448377 Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/main@{#79013}
-
Igor Sheludko authored
Bug: v8:11880, chromium:1292638 Change-Id: Ia457f391098aa2027988dae404948ab6f7fa8fab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3450415 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79012}
-
Manos Koukoutos authored
Bug: v8:11510 Change-Id: I15d3758532d964ce6a7203c4152ba3e34c3d9601 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448375Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79011}
-
Samuel Groß authored
This is required when allocating external pointer table entries from background threads through the LocalFactory interface. Bug: v8:10391 Change-Id: Ice5eee1000e1c7341bd0e58782cbb175080a5a74 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448376Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79010}
-
Samuel Groß authored
We need to properly handle the case of uninitialized embedder data slots which contain the "undefined" value and thus might look like valid external pointer table indices. Bug: v8:10391 Change-Id: I169a3e42132dde223ea151c1a5d5956c72341f8d Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448378Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79009}
-
Manos Koukoutos authored
Bug: v8:12605 Change-Id: Ic353570757b0271279d9a00352017b0341281e05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448382Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79008}
-
Michael Achenbach authored
Another encoding fix and test coverage for it. No-Try: true Bug: chromium:1292013 Change-Id: Id54f505848f93b4869710156fa77ad2e258c5dd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447905Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79007}
-
Dominik Inführ authored
When iterating slots for promoted objects we now also need to visit the map word slot since maps might get compacted. If we do not do this, we risk losing the already recorded slot for the map word in case that object already got marked. Bug: v8:12578, chromium:1295239 Change-Id: I34fbf7ae4b9e36eae8e7e3df354b5fd19adcb08f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448373Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79006}
-
Jakob Gruber authored
Drive-by: Change the macro magic around elements kind runtime predicates to make the function names grep-able. Fixed: v8:10105 Change-Id: Id5046bd0e60f40611c6c264613729fb9c6b73853 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3420306Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79005}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/bdea505..d2cbd4b Avoid potential truncation issues for the integral type parameterized tests. (#1341) (staffantj) https://chromium.googlesource.com/external/github.com/google/benchmark/+/d2cbd4b R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I7b50e4d883fe02cf0fcf2ede04d74ef0bab85e6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3449236 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79004}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/19e2886..a4e7e5a Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/77c52e2..a18d792 Rolling v8/third_party/android_sdk/public: Ez2NWws2SJYCF6qw2O-mSCqK6424l3ZdSTpppLyVR_cC..PGPmqJtSIQ84If155ba7iTU846h5WJ-bL5d_OoUWEWYC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1b93e14..cc0f7a5 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/94a76bd..d7bcddc R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4596515689bc1e99feb0af285d5b631fc2be8d5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3449235 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79003}
-
- 08 Feb, 2022 17 commits
-
-
Milad Fa authored
Change-Id: Ie5eac61238442bedcb5f9d61a67cc47de261655a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447692Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79002}
-
Milad Fa authored
Change-Id: If5f8aef98dcfbff14ba457669c4a5fba5c9226b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447376Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79001}
-
Alex Turner authored
This will allow users to create invalid V8DebuggerIds, e.g. to handle error cases. Bug: v8:12528 Change-Id: I6efbea934d444b520fc43531b910f4f80c718630 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3445742Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/main@{#79000}
-
Camillo Bruni authored
- Unroll loop in ReadVarInt to skip checks for uncommon branches and improve by ~15% - Use cage_base more aggressively - Use more dehandlified code if possible - Allow allocating strings directly in old-space to avoid filling up the new space when deserialising web-snapshots Cleanup: - ThrowDataCloneError now returns Nothing<bool>() for more consistency Bug: v8:11525 Change-Id: I69ac635e2bcab83e92fba5ab34603146fa21f043 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437049Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78999}
-
legendecas authored
Not all environments (like ShadowRealm) would expect console APIs to present in their globals. Moving console API to context's extras binding to allow them to be still snapshotted to not slow down the bootstrap. The console API is not removed from the global in this CL, but it is planned to be removed in the later release. Bug: v8:11989 Change-Id: Ieca09e0bafdf8943e8fff8fee97fc21c2326320f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364786Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Chengzhong Wu <legendecas@gmail.com> Cr-Commit-Position: refs/heads/main@{#78998}
-
Alexander Schulze authored
R=liviurau@chromium.org, machenbach@chromium.org Bug: chromium:1292010 Change-Id: Ice96bda42e1597b7d266cafb61565a54ea96d9a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448374Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/heads/main@{#78997}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dfc291f..19e2886 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/f2ef96e..b86911d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b4974c8..25f38be Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9c0ccc7..1b93e14 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I86966fa9d9a33c714004f9982f01dfa8e83b095a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447530 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78996}
-
Manos Koukoutos authored
Since {WasmGraphBuildingInterface::UnOp} always sets the result value node, we have to ensure the passed {result} is not null. Note: This can never happen with the current set of operators; this is guarding against possible future operators. Bug: chromium:1285041 Change-Id: I657cb02a9c650121a51ee795ef5572a5abd66933 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447373Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78995}
-
Jakob Kummerow authored
So that it doesn't cause loops to think that they have side effects, which would impede load elimination and similar optimizations. For compiling JavaScript, there is an equivalent annotation in JSOperatorBuilder::StackCheck. Change-Id: Ic9380df424062deb565671c8650b46550621fce5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440662 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78994}
-
Jakob Kummerow authored
We treat array indices as unsigned, so we should use `ChangeUint32ToUint64` before using them for computing memory offsets on 64-bit platforms. The signed version is currently an inefficiency; if we actually allowed arrays of such huge sizes, it would become a bug. Bug: v8:7748 Change-Id: I5c89ef82755a9987c4e5a8c9b3b630534bb3424f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440661 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78993}
-
Piotr Sikora authored
Fixes cross-compilation with bazel-zig-cc. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Change-Id: I7d94b84be33d8699ec71b4073bc0df1e7fcce5c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3445204Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#78992}
-
Jakob Gruber authored
The regexp parser historically has tried to gracefully detect and bail out from excess zone allocations, where 'excess' was determined to be an arbitrary limit of 256MB. This leads to issues now that the regexp parser may run from within the JS parser - the JS parser doesn't observe this arbitrary limit and happily keeps allocating until the underlying allocator actually runs out of memory; this way, the JS parser can handle very large JS files, and it's now counterproductive if the regexp parser (which reuses the JS parser zone) bails out on excess allocations. This CL simply removes the excess_allocation mechanism. Bug: chromium:1264014 Change-Id: I8d93a1e52aa65bb0ea6c2aab3b68b479ce79a1f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401580Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#78991}
-
Benedikt Meurer authored
Previously the inspector was trying to handle step-out for async functions by annotating the async stacks, but this was merely a hack and didn't work reliably (a) when the async caller that is `await`ing the result of the callee was still in the synchronous part (because then there was no async task yet in the inspector), or (b) not at all when the async stack tracking wasn't enabled or the maximum async stack depth was too small. This CL replaces that hack with a pragmatic solution inside the V8 debugger, where upon `await` we memorize the async function object of the caller on the outer promise of the callee, and when stepping out of the callee we check whether the returned promise has a memorized async function object and if so, we schedule that to resume. This CL thereby effectively reverts https://crrev.com/c/1054618 and replaces it with a V8 debug solution, and thereby further reduces the (memory) overhead of an AsyncStackTrace. Fixed: chromium:1246867 Bug: v8:6161, v8:7753, chromium:1277451, chromium:1280519 Change-Id: I6aa79e90f49d204f66bfd37e7a328c7fb8d635b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439865Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78990}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/1ee7bee..bdea505 Add mutex when reading counters_ (Fixes #1335) (#1338) (Liqiang TAO) https://chromium.googlesource.com/external/github.com/google/benchmark/+/bdea505 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I5acd1ef0af30aac9f76e6f7b215fd51d89c73c75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3446781 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78989}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3233ed2..dfc291f Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/5b0a8cf..77c52e2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/66c9784..9c0ccc7 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/14aa11d..43efa0a Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/fc5cfd7..3fc7923 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a8ca822..94a76bd R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ia89843d90b9b115b302e4281991f3a7b2284b963 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3445842 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78988}
-
Lu Yahan authored
Change-Id: I948d17b34334caae9deb9282176a76e6be3d28a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3443174Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78987}
-
Frank Tang authored
Bug: chromium:1290612 Change-Id: If1e3030882786ccc0c6a9b42128bc1ac044f43f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3445201Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78986}
-