• Dominik Inführ's avatar
    [heap] Support --expose-gc with shared heap · 01eb8ff9
    Dominik Inführ authored
    --shared-string-table assumes that all old strings are in the shared
    heap. However, when also using --expose-gc we create an external string
    for the GC function name. So far external strings are always allocated
    in the local old space though, which results in a heap verification
    error. This CL creates external string in the shared old heap with
    --shared-string-table enabled.
    
    In order to pass all the tests this CL also has to:
    
    * Stop marking into the shared heap for VisitEmbeddedPointer and
      VisitCodePointer.
    * Relax DCHECK in String::GetFlatContent: We cannot check the thread
      id for any shared string. Even if that string isn't really shared atm.
    
    Bug: v8:11708
    Change-Id: I51fec5ba038d035be5fe5e1277ef9286efc8dc2a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447371Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79022}
    01eb8ff9
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...