- 03 Jun, 2019 8 commits
-
-
Yang Guo authored
R=rmcilroy@chromium.org NOPRESUBMIT=true Bug: v8:9247 Change-Id: I355ac92c323ab34e1898c0764856ebadc3357dcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635691 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#61960}
-
Yang Guo authored
Bug: v8:9247 Change-Id: Ieae700aa01261c712e3ac22967fe3c59988c25c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635892Reviewed-by:
-
Simon Zünd authored
This CL changes "MessageWriter" type to std::function instead of a plain function pointer. This allows capturing lambdas, which in turn are used to make unittests more robust. R=sigurds@chromium.org Bug: v8:8880 Change-Id: I9d71ddcac173af36e5b62852f2a9ec6dcfac9f78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640201 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61958}
-
Clemens Hammacher authored
Trap handler registration happens under a spin lock, which causes lots of wasted cycles. With 48 background compilation threads, half of the wall-clock time is being spent on that spin lock. Moving this registration inside {PublishCodeLocked} avoids any lock contention (if a single module is being compiled), since we already sequentialize code publication. This speeds up background compilation for large numbers of background tasks, and has no measurable effect for small numbers. R=ahaas@chromium.org Bug: v8:8916 Change-Id: I572b53b9b581e4d5f6e441f6685350017d08d0be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1634928Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61957}
-
Ulan Degenbaev authored
Change-Id: I839de4a0c96347728abc5a0a9f7e2c4f9678133b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640200Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61956}
-
Ross McIlroy authored
Code stub assembler does implicit compression / decompression when loading values from the heap. As a result, we shouldn't expose explicit compress / decompress operators. BUG=v8:7703 Change-Id: I72b7b862b48f19e918db0e283d1be065a2651b44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1637879 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Jun Lim authored
This CL avoid lowering Switch to jumptable if the case count is small enough(4). Change-Id: Ida632807558c7403171e803947e7484908e0e028 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1605357Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61954}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/355210a..a3b6390 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b8451b7..5b31e69 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/bad01ad..c38806b Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/64e5d7d..9f0f47b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1f646a8..7ee072e TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Iea3df2d17dc375327cec3fbfe86e0cd2274a05c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640689Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61953}
-
- 31 May, 2019 20 commits
-
-
Frank Tang authored
Bug: v8:9312, chromium:968269 Change-Id: I0e3d134cd4341c30277df62fead6386e344be0bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1636179 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#61952}
-
Michael Achenbach authored
Change-Id: If2610987b66324a4b77531628c5058c3b31b8718 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1637463Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61951}
-
Santiago Aboy Solanes authored
CompressedHeapConstant is used in the DecompressionElimination Reducer to create compressed HeapConstant values. It won't appear in the graph up until that point. This CL enables back the disabled tests in DecompressionElimination, as well as generating the CompressedHeapConstant in that reducer. The RelocInfo has already been added for x64 but not for arm64. Therefore, the x64 version is now doing the mov on 32 bits. The support for ARM will come in a following CL, and for now it is doing the mov in 64 bits. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703, v8:9298 Change-Id: If0ca4f937cfa60501679e66f6fd5ded2df38f605 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632236Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61950}
-
Mythri A authored
Array push / pop / shift were inlined if the elements kind of the receiver maps is the same. This cl extends it by inlining these builtins even when the receiver maps have different elements kinds. It still limits it to only fast elements kinds. This is required to prevent regressions in deltablue when lazy feedback allocation is enabled. With lazy feedback allocation we may see polymorphic feedback more often, since we don't have allocation site feedback till the feedback vectors are allocated. Bug: v8:9078 Change-Id: Id4a7b84be6305b125913b6ce0fb4f3eb3e3b15ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632239 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61949}
-
Benedikt Meurer authored
This fixes a problem where ICs for transitioning stores go MEGAMORPHIC if the transition target map dies in between invocations of the IC, which is totally possible, since we only hold on weakly to these transition targets (both from the FeedbackVectors and also from the TransitonArrays). The root problem here was an inconsistency in how the maps and handlers are being reported by the FeedbackVector. On the on hand side the method FeedbackVector::ExtractMaps() will report all receiver maps that are still present (i.e. which haven't died themselves), but then the other method FeedbackVector::FindHandlers() will only report handlers that are still alive (i.e. which in case of transition target maps being used as handlers haven't died yet). If the length of these lists don't match the IC chickens out and goes MEGAMORPHIC. But this is exactly the case with the transitioning stores, where there's no handler anymore, i.e. as can be seen in this simple example: ``` // Flags: --expose-gc function C() { this.x = 1; } new C(); new C(); gc(); // map with the `C.x` property dies new C(); // now the STORE_IC in C goes MEGAMORPHIC ``` So the problem is that we have these two methods that don't agree with each other. Now FeedbackVector::ExtractMaps() is also used by TurboFan and it even reports receiver maps for PREMONOMORPHIC state, which is different from the use case that the ICs need. So I replaced the FeedbackVector::FindHandlers() with a completely new method FeedbackVector::ExtractMapsAndHandlers(), which returns both the maps and handlers, exactly as the ICs need it. And only returns pairs for which both the receiver map and the handler are still alive. This fixes the odd problem that sometimes STORE_ICs going MEGAMORPHIC for no apparent reason. Due to the weakness of the transition target maps, they can still die and cause deoptimizations, but at least TurboFan will now be able to reoptimize again later with the new maps and still generate proper code. Bug: v8:9316 Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel Change-Id: I74c8b60f792f310dc813f997e69efe9ad434296a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1637878 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The size is now computed as a fraction of the old space size: - for low memory devices (<512MB) the fraction is 1 / 256. - for all other devices the fraction is 1 / 128. The values were chosen to minimize the difference between the new and the old heuristics. Bug: v8:9306 Change-Id: I3246fe2d6fc589af6220e2566e3f10fb13470b82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632158Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61947}
-
Maciej Goszczycki authored
This makes the API more consistent and reduces the cognitive load of switching between 'next' and 'Next'. Bug: v8:9183 Change-Id: Ia81b874374626887d6af8c90f8ac185812f0573f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635689Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port c354fb9c Original Commit Message: This CL adds a new enum {LiftoffBailoutReason}, and tracks this reason for each bailout. This will give us data to prioritize extensions of Liftoff for new proposals or last missing instructions. Since we also track the {kSuccess} case, we will also see what percentage of functions can be compiled with Liftoff overall. R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iaf93d59780f62f03ccdcd5368ce4331e8b496f52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1638004Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#61945}
-
Michael Achenbach authored
Bug: chromium:967663 Change-Id: I1f2176dfeb435d10cc5c24cbba77119575315f03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635893Reviewed-by:
-
Maciej Goszczycki authored
counter_ could never be RO_SPACE. Make sure RO_SPACE and OLD_SPACE are marked as unreachable. Added tests for PagedSpaces and SpaceIterator. Bug: v8:9183 Change-Id: I97bc2b4e0e5af37363a1c628ca7d69d2790a97b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635696 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
-
Maciej Goszczycki authored
Without this, asan (rightfully) complains about read-only space leaking. Because pages are manually allocated using mmap, a few objects within them need to be explicitly ignored in addition to the read-only heap itself. This change re-adds lsan.h, with tweaks to make the type checking a bit more lenient. Bug: v8:7464 Change-Id: I0e2809930f3674e3f891e755b568ebb5194da461 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622121Reviewed-by:
-
Maciej Goszczycki authored
Bug: v8:9183 Change-Id: I53ad134b6dc8611ba439b78f27bfc8e56a82169e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635697Reviewed-by:
-
Maciej Goszczycki authored
ReadOnlySpace::Contains uses owner() which will eventually be set to nullptr. Use ReadOnlyHeap::Contains instead. Bug: v8:7464 Change-Id: I2b33c40b937768ff06536fb17be8d57727a8dd22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635695Reviewed-by:
-
Clemens Hammacher authored
This CL adds a new enum {LiftoffBailoutReason}, and tracks this reason for each bailout. This will give us data to prioritize extensions of Liftoff for new proposals or last missing instructions. Since we also track the {kSuccess} case, we will also see what percentage of functions can be compiled with Liftoff overall. R=mstarzinger@chromium.org CC=jwd@chromium.org Change-Id: I42b6a14c5a298ddda7053c195e8b650dc1fe66dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1634910Reviewed-by: -
Benedikt Meurer authored
The `FunctionTemplate::SetHiddenPrototype()` API was removed in a previous CL, after being deprecated since beginning of the year. This removes all the logic behind it, leaving us with just the special case of the JSGlobalProxy which has the JSGlobalObject as its hidden prototype. This gives us back one bit in `Map::bit_field2` and removes quite a bit of complexity from the code base (especially due to previous work from verwaest@ in this area). Bug: v8:9267 Change-Id: Id04b59686212fe35a63c9451aa3e045f0766b9cc Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619752 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Truncation::Float64 is confusing; in reality, we mean that oddballs and big-ints are identified with their ToNumber counterparts. Bug: v8:9183 Change-Id: Ibcce990327ac7e01e36a2237ad39c374ac9922aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632224 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61937}
-
Yang Guo authored
R=rmcilroy@chromium.org Bug: v8:9247 Change-Id: I2644436fd44ecf0e206a81cf28071cccb49793df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635690 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/bc7d300..41747be Remove extraneous copyright from bikeshed document (#1030) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/41747be [test/interpreter] Rounding edge cases for float literals (#1025) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/4bf74f6 Editorial: Remove links from Number, Object when checking types (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/b8faae7 [interpreter] Fix edge cases for f32_convert_i64 (#1021) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/356886f [spec] Address feedback on section 4 (#1022) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/9fd0547 [spec] Tweak wording (#966) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/a0e1a7e [spec][js-api] Fix some links (#1020) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/39646d1 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I543114a3147fac367f9e03962b7cbbad172c9fd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1638223Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/19aa2f3..355210a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7760fd2..b8451b7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9779b14..bad01ad Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/65e8ecf..1f646a8 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I5cf09857950c36a67630c3ed6e0cdf37202b4141 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1638222Reviewed-by:
-
Yu Yin authored
port https://crrev.com/c/1632235 (65f3861e) to mips. Original Commit Message: So far, calls to Wasm C/C++ API functions reused the call descriptors of WasmImportWrappers, and the stack frame type of regular Wasm functions. This CL cleans that up by introducing separate implementations for both. No change in functionality or performance is expected. Change-Id: I1d068e9baab403d714ddb31c26f97fa4e5becb41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635275 Commit-Queue: Yu Yin <xwafish@gmail.com> Auto-Submit: Yu Yin <xwafish@gmail.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#61933}
-
- 30 May, 2019 7 commits
-
-
Irina Yatsenko authored
WeakFixedArray, WeakArrayList, JSFinalizationGroup, JSFinalizationGroupCleanupIterator, WeakCell, JSWeakRef, BytecodeArray, SourcePositionWithFrameCache Note: SourcePositionTableWithFrameCache doesn't derive from Tuple2 anymore. Bug: v8:8952 Original CL: https://chromium-review.googlesource.com/c/v8/v8/+/1504433 Change-Id: I13f102b445c9ff3e1ebabe0cdf013c62bb6d771d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559212 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Suraj Sharma authored
Bug: v8:8952 Change-Id: I37410feab6fb24b306ba8712013267ba1ff5bc5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1618341Reviewed-by:
-
Johannes Henkel authored
This makes it so that v8 stops using the copy of the endoding library in the template - that is, third_party/inspector_protocol/lib/encoding_{h,cpp}.template - and uses the C++ library directly instead. This is done by having third_party/inspector_protocol/lib/Values_cpp.template include it, which is configured in the inspector_protocol_config.json. Change-Id: I1f8f2541ac2ed588ca35249e383b4c569434022b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635598Reviewed-by:Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#61930}
-
Dan Elphick authored
Fixes LookupNameOfBytecodeHandler so it actually returns non-nullptr values with embedded builtins enabled. Also now correctly handles wide and extra-wide bytecodes and always works regardless of whether ENABLE_DISASSEMBLER is set. Bug: v8:9215 Change-Id: I787134f2145d02daaf5b50ecb6c174dfc129a4fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635890Reviewed-by:
-
Yang Guo authored
Bug: v8:9247 Change-Id: Id6860e7b0f932990ac3cda39e369b0809e4f6a2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632072Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61928}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c93f946..19aa2f3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5db62d3..7760fd2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b97d193..9779b14 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/f71fb4f..f5edb4f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/64bb071..65e8ecf TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Iafa053df8859ac7040338af3f6655c5c15b2a007 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1636487Reviewed-by:
-
Yu Yin authored
port https://crrev.com/c/1627539 to mips. Change-Id: I18029495b6793fa1b981e28505a7c42842dacc97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1634629Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61926}
-
- 29 May, 2019 5 commits
-
-
Michael Mclaughlin authored
Currently, Number.prototype.toString(radix) often fails to produce the least significant bit for doubles near zero. For example, for the minimum double, 5e-324, toString(2) produces "0". This means that a user cannot reliably get the exact binary or hexdecimal value of a double from JavaScript using toString. This patch makes a slight amendment to the DoubleToRadixCString function, so that doubles where the gap to the next double is 5e-324 (i.e. doubles less than 2**-1021), are represented exactly in binary and other power-of-two bases, and close to exactly otherwise. It results in Number.prototype.toString producing the correct binary value for all doubles. R=jkummerow@chromium.org, mathias@chromium.org, yangguo@chromium.org Bug: v8:9294 Change-Id: I71506149b7c4c0eac8c38675a1ee15fb4f36f9ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631601 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Frank Tang authored
Speed up Intl.PluralRules constructor x3.4 $python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Intl" \ test/js-perf-test/JSTests5.json Score for NewIntlPluralRules BEFORE 550 581 576 AFTER 1856 1978 1996 Bug: v8:9300 Change-Id: I76b4290aa433b1049e3ee770d391b86e468e967d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630134 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Johannes Henkel authored
New revision: e8ba1a7665bdcd8336915d5ca4b390e0cf6b1f6f Change-Id: I6a916f003a29b0b9436ad031bbd43eddfa189e63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1634938 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
Bug: chromium:966460 Change-Id: I418eab656510fe3f799f552e75be10140d25bcab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625864Reviewed-by:
-
Milad Farazmand authored
Port 157b9181 Original Commit Message: Port 878ccb33 Original Commit Message: This CL was generated by an automatic clang AST rewriter using this matcher expression: callExpr( callee( cxxMethodDecl( hasName("operator->"), ofClass(isSameOrDerivedFrom("v8::internal::Object")) ) ), argumentCountIs(1) ) The "->" at the expression location was then rewritten to ".". R=miladfar@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I620c2104b649a75a01fd7a92dacadd652b23be7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1634931Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
