• Clemens Hammacher's avatar
    [wasm] Postpone trap handler registration until publish · 3410d142
    Clemens Hammacher authored
    Trap handler registration happens under a spin lock, which causes lots
    of wasted cycles. With 48 background compilation threads, half of the
    wall-clock time is being spent on that spin lock.
    Moving this registration inside {PublishCodeLocked} avoids any lock
    contention (if a single module is being compiled), since we already
    sequentialize code publication. This speeds up background compilation
    for large numbers of background tasks, and has no measurable effect for
    small numbers.
    
    R=ahaas@chromium.org
    
    Bug: v8:8916
    Change-Id: I572b53b9b581e4d5f6e441f6685350017d08d0be
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1634928Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61957}
    3410d142
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...