• Michael Mclaughlin's avatar
    Improve toString(radix) for doubles near zero · 348cc6f1
    Michael Mclaughlin authored
    Currently, Number.prototype.toString(radix) often fails to produce the
    least significant bit for doubles near zero. For example, for the
    minimum double, 5e-324, toString(2) produces "0". This means that a
    user cannot reliably get the exact binary or hexdecimal value of a
    double from JavaScript using toString.
    
    This patch makes a slight amendment to the DoubleToRadixCString
    function, so that doubles where the gap to the next double is 5e-324
    (i.e. doubles less than 2**-1021), are represented exactly in binary and
    other power-of-two bases, and close to exactly otherwise. It results
    in Number.prototype.toString producing the correct binary value for all
    doubles.
    
    R=jkummerow@chromium.org, mathias@chromium.org, yangguo@chromium.org
    
    Bug: v8:9294
    Change-Id: I71506149b7c4c0eac8c38675a1ee15fb4f36f9ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631601
    Commit-Queue: Mathias Bynens <mathias@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61925}
    348cc6f1
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...