- 23 Nov, 2021 16 commits
-
-
Marja Hölttä authored
Previous version: https://chromium-review.googlesource.com/c/v8/v8/+/3259648 Fix 1: ValueSerializer <3 JSArrayBufferView Fix 2: set flags correctly when creating DataViews via the API Bug: v8:11111 Change-Id: I9cbfdaff29f97c7823eaa3d931689b363e1f4cf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297708Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78046}
-
Andreas Haas authored
With dynamic tiering, caching is triggered multiple times as there is no single event anymore that triggers when the module should be cached. This CL adds a counter for the number of times caching is triggered. This counter can indicate whether our current caching heuristics are good or should get adjusted. R=thibaudm@chromium.org Bug: v8:12281 Change-Id: I8ed9ed73a556d11df643c31ec6d20760a257e0d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295578Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78045}
-
Hiroshige Hayashizaki authored
This CL adds `can_use_compiled_module` parameter to WasmStreaming::Finish() that is used by Chromium https://chromium-review.googlesource.com/c/chromium/src/+/3282643 to invalidate compiled module bytes after SetCompiledModuleBytes(). Bug: chromium:1260939 Change-Id: Iebf0e8615c27c8622721777c664b06a53fb9ee91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297548Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#78044}
-
Jakob Gruber authored
test-heap/NextCodeLinkIsWeak test-heap/NextCodeLinkIsWeak2 test-heap/NextCodeLinkInCodeDataContainerIsCleared These tests depends on deterministic compile job behavior. Fixed: v8:12367 Change-Id: I47e748f18abf947a769e09df3814bd2a3443b11b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297894 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78043}
-
Tobias Tebbi authored
Private methods use a property with symbol name that stores a context. This is then loaded to perform the brand check. Since this uses JSLoadProperty in Turbofan, we should not type JSLoadProperty as NonInternal. Bug: chromium:1269063, v8:12359 Change-Id: I920ccf46e939ab0477ff2fdb3cda6d7d94bab0af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293089Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78042}
-
Victor Gomes authored
No-Try: true Change-Id: I9a7be37f6f1a404fb5c3517b5fdb4008aaaec45a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295460 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78041}
-
Anton Bikineev authored
The macro may be defined but the value to it may not be assigned. The compiler can complain about (reproduced when compiling chromium on Windows). Bug: chromium:1249550 Change-Id: I684997ccda7122f56c01391e7a1339fadf6589e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297888Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#78040}
-
Marja Hölttä authored
This reverts commit 8f3e53b8. Reason for revert: Blink test failures Original change's description: > [rab/gsab] Add RAB / GSAB support to DataViews > > Bug: v8:11111 > Change-Id: Ice66accee734484302d499b8098056ae1c68faf3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259648 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78028} Bug: v8:11111 Change-Id: Icaae7276dfede8c021f3ce1a7e96ed3ec13fe4fe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295577 Auto-Submit: Marja Hölttä <marja@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#78039}
-
Anton Bikineev authored
The list of to-be-finalized objects can grow significantly. While running Speedometer2, the metadata that stores to-be-finalized objects can be the second largest contributor to heap consumption (overall taking up 2.6MB, checked with heaptrack). The CL changes the list to be stored inlined in HoH, if cage-heap is enabled, rather than in a separate vector. Bug: chromium:1249550 Change-Id: I04a0c84d118655fa6ff8e2440423e802cd722842 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295448Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#78038}
-
JianxiaoLuIntel authored
Change-Id: I6411c752e3de1fb6e1547ccfe41265c5615eb421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3296148 Auto-Submit: Jianxiao Lu <jianxiao.lu@intel.com> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78037}
-
QiuJi authored
Change-Id: I7755e943674ec4128b0e5869e9ff5ea735efd162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295309 Auto-Submit: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#78036}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/eabf027..368880d Rolling v8/third_party/aemu-linux-x64: BsMGVIB-SMSFb0qDOwUoX0kok6z1XZdfmi4kKMOPrWYC..RGchQ75eBrFQJRPQJMv5DT7uzlwr_ttfbGI2Kqlzw0wC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8a112e2..738798d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b6c1ed4..a29f589 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b0d8d05..649f6b9 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I62d21963fa941ad4c6bee2bc4c2d48bc9e858c19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3296368 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78035}
-
jiepan authored
Change-Id: Icc245d9939649386d44ca95b9e57933b436b5cb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293414Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Jie Pan <jie.pan@intel.com> Cr-Commit-Position: refs/heads/main@{#78034}
-
jiepan authored
Bug: v8:12228 Change-Id: I21b2ee1e640ba75227a03d765bb1552eff68e3fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293415Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Jie Pan <jie.pan@intel.com> Cr-Commit-Position: refs/heads/main@{#78033}
-
Paolo Severini authored
Bug: chromium:1271456 Change-Id: I54b81fc8e450ba65c9895ec5e22366446098dd64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3296146Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/main@{#78032}
-
Paolo Severini authored
It is possible to inline a JSToWasm wrapper that directly calls a WasmToJS wrapper. In this case we need to make sure that the instance we pass is a WasmApiFunctionRef, not a WasmInstanceObject. Bug: chromium:1271456 Change-Id: I684a769922895860a43c73ba43c2598c9bda4b64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293423 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78031}
-
- 22 Nov, 2021 19 commits
-
-
Omer Katz authored
Bug: v8:12407 Change-Id: Iedf6154796423267fdb32125a408e580bb3c205b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295349Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78030}
-
Anton Bikineev authored
For large working set, the sweeper metadata can significantly increase. Currently, the backing of swept_unfinalized_pages never gets freed, which causes about 300KB of memory be occupied (checked on Speedometer2). The CL makes sure to shrink (actually free) the backing after each GC cycle. Bug: chromium:1249550 Change-Id: I7c7e5248983960a498afc252a344fa71cb1444c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295347 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78029}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Ice66accee734484302d499b8098056ae1c68faf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259648 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#78028}
-
Frank Tang authored
Reduce unnecessary size during development Bug: chromium:1260432 Change-Id: I690e511900abf0f8218f6ece8a5d1f144947b584 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292484Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78027}
-
Ng Zhi An authored
No implementation needed, since relaxed swizzle is already handled in wasm-compiler, and is visited by VisitI8x16Swizzle, and on arm64 we generate the same code (TBL). Bug: v8:12284 Change-Id: I446632101de26bb2f28c3f3ed60f209e81600dec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272643Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#78026}
-
Ng Zhi An authored
Bug: v8:12284 Change-Id: Ia5dd40ffd1854ed8f1d6138a1bf40d8f2ca79793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272642Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#78025}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I49326278fa43cd07c17a01b70253303d2e861b06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291558Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#78024}
-
Victor Gomes authored
ASAN builds on Google3 depends on NoSanitizeMemset No-Try: true Change-Id: Ia03c2b3cea4a063806e799eb0ba0f38408a18d99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295743 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78023}
-
Omer Katz authored
Change-Id: Id592b919b307637a0dab1ce1a7d9ec931836650c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295458 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78022}
-
Clemens Backes authored
Many safepoint tables do not contain any deoptimization info and/or no callee-saved registers. Do not emit empty fields for all entries in this case. This often shrinks the size of the encoded safepoint table by more than 50%. Drive-by cleanups: - Rename fields of the safepoint table entries to clarify their meaning ("tagged slots" instead of "bits", "tagged register indexes" instead of "register bits"). - Include the PC in the decoded {SafepointEntry} to make it the single source of truth. R=jkummerow@chromium.org Bug: v8:12401 Change-Id: If5c24a688a434842ed3b6427f5f1f3ea9232173a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289173Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78021}
-
Andreas Haas authored
With dynamic tiering, not all functions get compiled with TurboFan, and not all functions can therefore get cached. With this metric we want to keep track of the time needed to compile missing functions with Liftoff. R=jkummerow@chromium.org Bug: v8:12281 Change-Id: I1f2de3e1f6b004477985df5d2116f69371528c3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289178Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78020}
-
Nico Hartmann authored
This reverts commit d7c3f1cd. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Android%20Arm64%20-%20debug%20builder/22043/overview Original change's description: > Reland "[fastcall] Enable float support on arm64 simulator" > > This is a reland of b9ddcbc8 > > The original CL was reverted due to an MSAN issue, that is fixed by > moving the signature mapping onto the Isolate (instead of having > per-thread storage, which got invalid on multithreaded compilation). > > This CL also contains fixes for the Bazel config and for a data race > when obtaining the PerIsolateSimulatorData. > > Original change's description: > > [fastcall] Enable float support on arm64 simulator > > > > This CL adds support for handling calls to C functions with arbitrary > > signatures on the arm64 simulator. It adds infrastructure for > > encoding the signature data from CallDescriptor and FunctionInfo > > classes into a compact representation, stored in the simulator and > > called EncodedCSignature. > > > > Design doc: > > https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit > > > > This CL is a follow up on the native support added in > > https://chromium-review.googlesource.com/c/v8/v8/+/3182232 > > and is partially based on the previous attempt: > > https://chromium-review.googlesource.com/c/v8/v8/+/2343072 > > > > Bug: chromium:1052746 > > Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > > Commit-Queue: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#77744} > > Bug: chromium:1052746, chromium:1267854 > Change-Id: I89bbd01e33fb1080543d98bcfd4c2d17b5c76861 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3270541 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78018} Bug: chromium:1052746, chromium:1267854 Change-Id: Ia8f10d085d13990b331f306957f95ecf3e003cfd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295453 Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78019}
-
Maya Lekova authored
This is a reland of b9ddcbc8 The original CL was reverted due to an MSAN issue, that is fixed by moving the signature mapping onto the Isolate (instead of having per-thread storage, which got invalid on multithreaded compilation). This CL also contains fixes for the Bazel config and for a data race when obtaining the PerIsolateSimulatorData. Original change's description: > [fastcall] Enable float support on arm64 simulator > > This CL adds support for handling calls to C functions with arbitrary > signatures on the arm64 simulator. It adds infrastructure for > encoding the signature data from CallDescriptor and FunctionInfo > classes into a compact representation, stored in the simulator and > called EncodedCSignature. > > Design doc: > https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit > > This CL is a follow up on the native support added in > https://chromium-review.googlesource.com/c/v8/v8/+/3182232 > and is partially based on the previous attempt: > https://chromium-review.googlesource.com/c/v8/v8/+/2343072 > > Bug: chromium:1052746 > Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77744} Bug: chromium:1052746, chromium:1267854 Change-Id: I89bbd01e33fb1080543d98bcfd4c2d17b5c76861 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3270541Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#78018}
-
Leszek Swirski authored
There are cases where DeclareEvalVar can fail to create a variable, in particular when the declaration scope is not extensible. Throw an error in such cases. Fixed: chromium:1145119 Change-Id: I6260f570570c4d7801231bdb5f6724f3734444fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295348 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78017}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I4e4ba332611e3feedc70b32c39f4270cdb0e11cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295446Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78016}
-
Omer Katz authored
Once CppHeap moves away from EmbedderHeapTracer, it can no longer be returned by Isolate::GetEmbedderHeapTracer. Blink currently uses GetEmbedderHeapTracer to trigger GCs. This CL introduces a variant of Isolate::RequestGarbageCollectionForTesting to replace that. Bug: v8:12407 Change-Id: I099989f55291a0daab7d2051072dedddef58dd40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293413 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78015}
-
Dominik Inführ authored
Instead of just DCHECKing that we are in a safepoint in Snapshot::Create, pass the GlobalSafepointScope as argument. Bug: v8:11708, v8:12377 Change-Id: Ia856c27b92223bf3a96fe6946b86e4625f3a1e0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295342Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78014}
-
Dominik Inführ authored
This is a reland of 90a9d6cb The original CL got reverted because of two different issues: * The DCHECK failure on AllowGarbageCollection::IsAllowed() got fixed in https://crrev.com/c/3289625. * The crash with the incremental marking job were because of a nested GC started from a SafepointScope. This CL adds IgnoreLocalGCRequests scopes to SafepointScopes in src/heap. In addition this CL prevents shared GCs during isolate deserialization by locking the clients_mutex_ until the isolate is fully deserialized. The original GC used a DisallowSafepoints scope to prevent shared GCs from interrupting isolate deserialization. Original change's description: > [heap] Support multiple clients in shared GC > > Add support for safepointing multiple isolates as described in the > design doc (link is below). A safepoint across multiple isolates is > considered a global safepoint to distinguish it from regular safepoints. > > The basic idea behind the implementation is that we reach a > safepoint for each client. What's new is that now also main threads > need to participate in the safepointing protocol and need to give up > control in time. The slow paths of Park(), Unpark() and Safepoint() on > the main thread need to be adjusted for this reason as well. > > This CL introduces GlobalSafepoint and GlobalSafepointScope to mirror > IsolateSafepoint and IsolateSafepointScope. > > This CL adds the type IgnoreLocalGCRequests, it is used to prevent > Park() and Unpark() from honoring the request from background threads > to perform a local GC. This is used heap-internally to not have GCs > (or even nested GCs) in certain locations. E.g. when initiating a > safepoint to perform a GC we don't want a "recursive" GC to occur. > > Design doc: https://docs.google.com/document/d/1y6C9zAACEr0sBYMIYk3YpXosnkF3Ak4CEuWJu1-3zXs/edit?usp=sharing > > Bug: v8:11708 > Change-Id: I5aca8f5f24873279271a53be3bb093fc92a1a1eb > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009224 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77812} Bug: v8:11708, v8:12375, v8:12377 Change-Id: I9d1af6fbc06a3a8b6f216ec5e9027665ad071809 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3283067 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#78013}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/63b08e1..eabf027 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I5d37b3b024f5da8769268becc86166d74282c6ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294405 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78012}
-
- 21 Nov, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3335020..63b08e1 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/a63bbc1..e504863 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8b575c9..8a112e2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I457b5528fce8eafbb3fc99424656554a0442ae6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294681 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78011}
-
- 20 Nov, 2021 4 commits
-
-
Omer Katz authored
Starting an incremental GC when it is not supported is not allowed but trying to finalize one when it might be unknown whether it's supported or not should be legal. In such cases, finalization would immediately bail out since there is no active gc. Bug: chromium:1272076 Change-Id: If5aaaa130dc55474d3fc3afcd7039880a2c11333 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293411 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78010}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/8401429..ce92bbf remove long-defunct cli parameter (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/ce92bbf lose some build warnings (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/88ea9d9 Disable clang-tidy (unused-using-decls) (#1287) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/91ed7ee disable lint check where we know it'd fail (#1286) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/8722d6f Add Setup/Teardown option on Benchmark. (#1269) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/b5bb9f0 Googletest renamed master to main today. (#1285) (Donald Aingworth) https://chromium.googlesource.com/external/github.com/google/benchmark/+/a07f6d1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I590fce794f7df0271ea97efce0ee04efd6d5d5a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294010 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78009}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/d3ba6ae..bf66d37 Reduce size by using lao dictionary from ICU 69. (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/bf66d37 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: Ibe8ce74e1cb9997f6da001e8dc445fe5656e1aca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3294011 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78008}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/26f1f4567e..d52b510a Bug: v8:7834 Change-Id: Ied739ce9ee8482cbd23ebb19b5e76c62387d8ef6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292508Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78007}
-