Commit 6e978db8 authored by Tobias Tebbi's avatar Tobias Tebbi Committed by V8 LUCI CQ

[turbofan] fix typing of JSLoadProperty

Private methods use a property with symbol name that stores a context.
This is then loaded to perform the brand check. Since this uses
JSLoadProperty in Turbofan, we should not type JSLoadProperty as
NonInternal.

Bug: chromium:1269063, v8:12359
Change-Id: I920ccf46e939ab0477ff2fdb3cda6d7d94bab0af
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293089Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78042}
parent ee3c9f2b
......@@ -1321,9 +1321,7 @@ Type Typer::Visitor::TypeJSGetTemplateObject(Node* node) {
return Type::Array();
}
Type Typer::Visitor::TypeJSLoadProperty(Node* node) {
return Type::NonInternal();
}
Type Typer::Visitor::TypeJSLoadProperty(Node* node) { return Type::Any(); }
Type Typer::Visitor::TypeJSLoadNamed(Node* node) { return Type::NonInternal(); }
......
// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --always-opt --assert-types --no-analyze-environment-liveness
class C {
get #a() { }
getA() { return this.#a; }
}
new C().getA();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment