- 06 Nov, 2018 40 commits
-
-
Adam Klein authored
This reverts commit 007c0034. Reason for revert: fails on TSAN bots (e.g., https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/23395) Original change's description: > [Intl] Handle 'c' pattern for DateTimeFormat > > Handle the pattern 'c' return by ICU in Intl.DateTimeFormat > for weekday standalone form. > Add regression test to ensure all the standalone pattern return > option are in the expected list. > > Bug: v8:8413 > Change-Id: I9ab42383e3882ef1720606830624775e2748fccb > Reviewed-on: https://chromium-review.googlesource.com/c/1318092 > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57299} TBR=jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org Change-Id: Iff0afbcd4527428e16b779d84dc7b8b70eb1fe16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8413 Reviewed-on: https://chromium-review.googlesource.com/c/1320891Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57301}
-
Adam Klein authored
'simulator_run' is now used exclusively in test/*/*.status. Change-Id: I501b7ffd19e2476f4c803ed3d25cba69d67039fa Reviewed-on: https://chromium-review.googlesource.com/c/1318610Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57300}
-
Frank Tang authored
Handle the pattern 'c' return by ICU in Intl.DateTimeFormat for weekday standalone form. Add regression test to ensure all the standalone pattern return option are in the expected list. Bug: v8:8413 Change-Id: I9ab42383e3882ef1720606830624775e2748fccb Reviewed-on: https://chromium-review.googlesource.com/c/1318092Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57299}
-
Adam Klein authored
This test currently takes nearly 10 minutes on the arm64 debug builder. Bug: v8:7783 Change-Id: I500fc026b01873e666f32062d790eca3f34455b9 Reviewed-on: https://chromium-review.googlesource.com/c/1318495 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57298}
-
Junliang Yan authored
Bug: v8:8420 Change-Id: Ie3ca4cbee01a1b19c82630ec205915ff6a00b303 Reviewed-on: https://chromium-review.googlesource.com/c/1320449Reviewed-by:
-
Junliang Yan authored
simulator takes too long to run. Change-Id: I77f6e932129bfed7d1cdb7e9ccf78a4608554ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1320389Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57296}
-
Junliang Yan authored
Port 6d706ae3 Original Commit Message: and split Smi out of objects.h into smi.h. R=jkummerow@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id876a65c3e0af550caa246090b60580645faedc5 Reviewed-on: https://chromium-review.googlesource.com/c/1320032Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57295}
-
Michael Achenbach authored
This reverts commit b8e8b0de. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm%20-%20debug/8276 Original change's description: > [ptr-compr] Fix incorrectly used machine types > > in TurboFan, CSA, Wasm and compiler tests. Tagged values decompression > logic will depend on the machine type of the value being loaded so it must > be correct. > > Bug: v8:7703 > Change-Id: Ia9e7cc1e273e5a458d9de8aaa4adb0c970413b8b > Reviewed-on: https://chromium-review.googlesource.com/c/1319573 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57280} TBR=mstarzinger@chromium.org,ishell@chromium.org Change-Id: Ia97d5bfebf8d8fe1b2b7607f63024b60cf2c584f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7703 Reviewed-on: https://chromium-review.googlesource.com/c/1320349Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ibe96234f101ce1e3a8fd61ccf387aa4bb6da6067 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319870Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57293}
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I6e2782a7f8589c466b54987c850d41d4ff5f6489 Reviewed-on: https://chromium-review.googlesource.com/c/1316618Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57292}
-
Clemens Hammacher authored
The CompileStep is only invoked via the {AsyncCompileJob} that owns it, so we can just pass a pointer to the AsyncCompileJob instead of storing it in the step itself. R=ahaas@chromium.org Bug: v8:8238, v8:7921 Change-Id: I92eda222ace2d5fef5af7663175c62fa7601810c Reviewed-on: https://chromium-review.googlesource.com/c/1319759 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57291}
-
Jaroslav Sevcik authored
This introduces a utility function on code stub assembler to check that a map has given prototype object map. In addition, if constant field tracking is active, it will check that a given field is still constant (typically a function that is assumed not to be patched). This also fixes a fast path check in regexp C++ code to properly detect that "exec" function was modified on RegExp's prototype when constant field tracking is on. Bug: v8:5495, v8:8361 Change-Id: I98476db46ba4633124cf1437be90aea3585ce978 Reviewed-on: https://chromium-review.googlesource.com/c/1297954 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57290}
-
Joyee Cheung authored
Rename variables and flag names so that the classes can be reused by private methods implementation. In particular: Rename "fields" to "members" in the initializer so that we can initialize both fields and private methods/accessors there, for example: instance_fields_initializer -> instance_members_initializer InitializeClassFieldsStatement -> InitializeClassMembersStatement Rename "private field" to "private name" for the private symbols used to implement private fields so that we can use them to store private methods/accessors later as well, for example: private_field_name_var -> private_name_var NewPrivateFieldSymbol -> NewPrivateNameSymbol The follow-on is in https://chromium-review.googlesource.com/c/v8/v8/+/1301018 The design doc is in https://docs.google.com/document/d/1T-Ql6HOIH2U_8YjWkwK2rTfywwb7b3Qe8d3jkz72KwA/edit?usp=sharing Bug: v8:8330 Change-Id: I1cdca8def711da879b6e4d67c5ff0a5a4a36abbe Reviewed-on: https://chromium-review.googlesource.com/c/1312597Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The order is: inner classes, friend classes, fields, methods. Before, fields and methods were mixed up. R=ahaas@chromium.org Bug: v8:8238 Change-Id: I4a6834785f2285e62e24c073611885378046b88b Reviewed-on: https://chromium-review.googlesource.com/c/1319756Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I1fe4454e3c0f2ec5cc044e36c311012d41e896a7 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319768 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: If8faa3c7c0324fc9d0a2704533278828c62d5b91 Notry: true Bug: v8:8128, v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319765Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57286}
-
Sigurd Schneider authored
Bug: chromium:901798 Change-Id: I4b479d6431cc7cdfa53f9cdf6283d2ff86e32821 Reviewed-on: https://chromium-review.googlesource.com/c/1319760Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
These tests are also used for streaming. This CL changes the test to actually output the exception that unexpectedly happened. R=ahaas@chromium.org Bug: v8:7921 Change-Id: Ia9c91a7d3d9452f9c0180329a5434f049b56c3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1319755 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Any sane platform would process foreground tasks in a FIFO order. Hence our mock platform in the tests should do the same. R=ahaas@chromium.org Bug: v8:7921 Change-Id: Iafe1d9f2eb2a0c168f7e994f05b054756ef9e4af Reviewed-on: https://chromium-review.googlesource.com/c/1319754 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: Iaac8c2e036a0343c4d4a5c50bc91fb3d35e5d760 Reviewed-on: https://chromium-review.googlesource.com/c/1319586Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57282}
-
Jakob Gruber authored
This condition is easy to miss at call sites and could create 'fast' arrays that are too large. Let's make this a runtime CHECK instead. Bug: chromium:901944 Change-Id: I8f8f161781414944b67099007a98f76972496ae2 Reviewed-on: https://chromium-review.googlesource.com/c/1319571Reviewed-by:
-
Igor Sheludko authored
in TurboFan, CSA, Wasm and compiler tests. Tagged values decompression logic will depend on the machine type of the value being loaded so it must be correct. Bug: v8:7703 Change-Id: Ia9e7cc1e273e5a458d9de8aaa4adb0c970413b8b Reviewed-on: https://chromium-review.googlesource.com/c/1319573 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57280}
-
Jakob Gruber authored
The array length is modifiable by user code that is called as a side-effect during the sorting algorithm. We thus cannot base any guarantees on the current length, but must reference the initially-read array length instead. Note that even though the algorithm may read and write from beyond the current array length value, this adheres to the spec, which only requires accesses to be within the original array dimensions (i.e.: 0 <= i < original array length). Bug: chromium:901633 Change-Id: Id765e80d4231ff6f2a73e040ec94c2b07f8c5b0f Reviewed-on: https://chromium-review.googlesource.com/c/1317814 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#57279}
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: I7e81d233211ba29d9c48accda63a365e31f51617 Reviewed-on: https://chromium-review.googlesource.com/c/1319582Reviewed-by:
-
Michael Starzinger authored
R=herhut@chromium.org Change-Id: Ic7fede18b89a14a8e0af255add5678a70b699475 Reviewed-on: https://chromium-review.googlesource.com/c/1319580Reviewed-by:
-
Sigurd Schneider authored
Phi creation in the code assembler was dependent on the addresses of the CodeAssemblerVariable::Impl object. This caused non-determinism in mksnapshot which sometimes occurred on Windows. This CL adds IDs to CodeAssemblerVariable::Impl objects and ensures all iterations are done in ID order instead of object address order. Change-Id: I2b370dc5153202be864a5c13289e70f5ebd59e2e Bug: v8:8391 Reviewed-on: https://chromium-review.googlesource.com/c/1319749 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57276}
-
Dan Elphick authored
When deserializing the startup snapshot, call IterateStrongRoots with VISIT_FOR_SERIALIZATION rather than VISIT_ONLY_STRONG. To compensate, make the StartupDeserializer explicitly iterate over the partial snapshot cache. This makes the deserializer and serializer consistent in their use of the function and makes their differences explicit in the snapshot code itself. Bug: chromium:902230 Change-Id: I3a2ac858f4f6b3097b98a10ed2dd5ac5b9bf83e8 Reviewed-on: https://chromium-review.googlesource.com/c/1319585 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
- Fix ParseBCP47 to return just the extension. The second argument to substr function is actually the length, not the end position of the substring :') - Remove extension keys that aren't part of the relevant extension keys - Use 'ca' as an relevant extension key for DateTimeFormat - Use the canonicalized locale tag after create the ICU locale is created, rather than the input locale tag. Bug: chromium:895942, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I189709714d847e684b04409b734a60ff04ed7dd2 Reviewed-on: https://chromium-review.googlesource.com/c/1291076Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#57274}
-
Mike Stanton authored
Bug: v8:8418 Change-Id: I6d2efdf87bb4fc5454e5a4ee8e5a66463533615e Reviewed-on: https://chromium-review.googlesource.com/c/1317810 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Yang Guo authored
This is to ensure the snapshot is deterministic. Internal fields can contain: - reference to heap object - embedder-defined aligned pointer - a smi The latter two are not distinguishable by V8, so if the serializer callback returns non-zero value, we consider it to be an aligned pointer and clear it to ensure that the snapshot does not contain memory addresses that may not be deterministic. If the callback returns { nullptr, 0 } as result, we consider it to be a smi or some in-place data that we then serialize verbatim. R=jgruber@chromium.org Bug: chromium:870584 Change-Id: I3cf9abf135ffd28d8138fa32636b12596b076e13 Reviewed-on: https://chromium-review.googlesource.com/c/1304441 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: -
Peter Marshall authored
Causing ASAN failures Bug: v8:5193 Change-Id: I7a899a6390bd1258a1afc8738e85f73239f44a59 Reviewed-on: https://chromium-review.googlesource.com/c/1319583Reviewed-by:
-
Daniel Clifford authored
This is a reland of c88994f8 Turned out to not be the issue. Original change's description: > Fix Array.prototype.sort speed regression > > CanUseSameAccessor<ElementsAccessor: type> is array-sort.tq is super > performance-critical. Reverting the type-safe cleanup made in this > function while landing Array.prototype.slice. > > Bug=chromium:852764 > > Change-Id: I1252d2ff8e431581f916794807e59abb39248abb > Reviewed-on: https://chromium-review.googlesource.com/c/1317815 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Daniel Clifford <danno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57248} TBR=danno@chromium.org Change-Id: I627a131a8525ae4e131c6467561cab9832f3792f Reviewed-on: https://chromium-review.googlesource.com/c/1319581Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57270}
-
Georg Neis authored
Bug: chromium:901944 Change-Id: Iaf1dfaa5763162ae7952381fb8b64661d85ea1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1317822Reviewed-by:
-
Toon Verwaest authored
Change-Id: Iefea33f47ee4492c9c4d4e105e30f7e2d9128bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1319576Reviewed-by:
-
Sigurd Schneider authored
Notry: true Change-Id: Iacc8aadc62956cf5fab13c60a9eaa52318519d62 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1317813 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: v8:8421 Change-Id: Ifbc7271da8a210b197b698f92aad925d3adf7244 Reviewed-on: https://chromium-review.googlesource.com/c/1319579 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit c88994f8. Reason for revert: Seems to break AccessibilitySelectionTest.List in webkit_unit_tests (https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Mac/15618) Original change's description: > Fix Array.prototype.sort speed regression > > CanUseSameAccessor<ElementsAccessor: type> is array-sort.tq is super > performance-critical. Reverting the type-safe cleanup made in this > function while landing Array.prototype.slice. > > Bug=chromium:852764 > > Change-Id: I1252d2ff8e431581f916794807e59abb39248abb > Reviewed-on: https://chromium-review.googlesource.com/c/1317815 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Daniel Clifford <danno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57248} TBR=danno@chromium.org,jgruber@chromium.org Change-Id: Ie447fd0382fee344326d928398595aa450ccdcca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1319577Reviewed-by:
-
Toon Verwaest authored
This rethrows the underlying expression error if there is one. Bug: v8:8409 Change-Id: Icc8253e4006c554df9f6a6d850b087b03d88de2d Reviewed-on: https://chromium-review.googlesource.com/c/1319570Reviewed-by:
-
Clemens Hammacher authored
Instead of passing and storing uint8_t* and size_t, we now more often store a Vector or OwnedVector, which encapsulates these two fields. This provides some more DCHECKs which happen automatically when getting a subvector into the buffer. Drive-by: More refactorings and removals of unneeded or rarely used helper methods. R=ahaas@chromium.org Bug: v8:8238 Change-Id: I1b24f90f1517fc50360854f46c2d001075544858 Reviewed-on: https://chromium-review.googlesource.com/c/1317817 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Igor Sheludko authored
In particular, output root name instead of root value when detecting accesses to roots table. For example: REX.W cmpq [r13+0x80] (root (0x391473a00569 <Map[16]>)),rbx REX.W movq rdi,[r13+0x18] (root (0x391473a007b9 <Map>)) REX.W movq rdi,[r13-0x20] (root (0x391473a005b9 <the_hole>)) turns into REX.W cmpq [r13+0x80] (root (heap_number_map)),rbx REX.W movq rdi,[r13+0x18] (root (fixed_array_map)) REX.W movq rdi,[r13-0x20] (root (the_hole_value)) Bug: v8:8238 Change-Id: I0f7bdcb7774a2fe450f930c1bc2f3ccd03064201 Reviewed-on: https://chromium-review.googlesource.com/c/1317823Reviewed-by:
-
