• Jakob Gruber's avatar
    [array] Weaken bounds checks in Array.p.sort · 1444bebe
    Jakob Gruber authored
    The array length is modifiable by user code that is called as a
    side-effect during the sorting algorithm. We thus cannot base any
    guarantees on the current length, but must reference the initially-read
    array length instead.
    
    Note that even though the algorithm may read and write from beyond
    the current array length value, this adheres to the spec, which only
    requires accesses to be within the original array dimensions (i.e.: 0
    <= i < original array length).
    
    Bug: chromium:901633
    Change-Id: Id765e80d4231ff6f2a73e040ec94c2b07f8c5b0f
    Reviewed-on: https://chromium-review.googlesource.com/c/1317814
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarDaniel Clifford <danno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57279}
    1444bebe
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...