- 14 Jan, 2019 16 commits
-
-
Clemens Hammacher authored
This reverts commit f5729f1c. Reason for revert: GC Stress failures, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23549 Original change's description: > [GC] Ensure JSFunctions with flushed bytecode are flushed during GC. > > When bytecode is flushed from a SFI, the JSFunctions still retain their > FeedbackVector's and point to the interpreter entry trampoline. They are > reset if re-executed, however if not they could hold onto the feedback > vector indefinetly. This CL adds a pass the GC to detect JSFunctions that > need to be reset, and performs the reset at the end of GC. > > BUG=v8:8395 > > Change-Id: I3de8655aff9ff80f912b4fd51dee43eb98cfd519 > Reviewed-on: https://chromium-review.googlesource.com/c/1393292 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58775} TBR=ulan@chromium.org,rmcilroy@chromium.org Change-Id: I1ba0a190e54bb84b9e2c52ae73d19eb5afc02a4b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8395 Reviewed-on: https://chromium-review.googlesource.com/c/1408993Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58778}
-
Ben L. Titzer authored
R=ahaas@chromium.org Change-Id: Ib6c69345f6c00580ba444ec885c46057dc8a3d48 Reviewed-on: https://chromium-review.googlesource.com/c/1408992Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#58777}
-
Clemens Hammacher authored
Instead, pass it as a parameter to the compilation. This makes compilation units slimmer with the end goal of them being just the function index and execution tier. It also makes ownership handling of the NativeModule easier. R=titzer@chromium.org Bug: v8:8343, v8:7921 Change-Id: I0522c894569c71d8b7245f5ed5612ab2a249e1ad Reviewed-on: https://chromium-review.googlesource.com/c/1406668Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58776}
-
Ross McIlroy authored
When bytecode is flushed from a SFI, the JSFunctions still retain their FeedbackVector's and point to the interpreter entry trampoline. They are reset if re-executed, however if not they could hold onto the feedback vector indefinetly. This CL adds a pass the GC to detect JSFunctions that need to be reset, and performs the reset at the end of GC. BUG=v8:8395 Change-Id: I3de8655aff9ff80f912b4fd51dee43eb98cfd519 Reviewed-on: https://chromium-review.googlesource.com/c/1393292 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58775}
-
Ben L. Titzer authored
This matches the terminology that is used throughout the spec. R=clemensh@chromium.org Change-Id: I62445e750415e6048b805110c7306f3bdbf9da60 Reviewed-on: https://chromium-review.googlesource.com/c/1408988 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: Iad9a3087ea7915bade6c70c56f6d8f6f640f26cb Reviewed-on: https://chromium-review.googlesource.com/c/1408889Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58773}
-
Clemens Hammacher authored
They happen right after each other anyway. Merging them saves one mutex scope. R=ahaas@chromium.org Change-Id: Id3ed564e6f7d8dce78022e6ded238d41c6beb333 Reviewed-on: https://chromium-review.googlesource.com/c/1405858Reviewed-by:
-
tzik authored
As a follow-up of https://crrev.com/c/1372857 that repordered the parameters of JSEntry, this CL updates JSEntry for PPC for new ordering. Bug: v8:8124 Change-Id: I9daa23dc66209e435a729c2e8464c54d098dcf1f Reviewed-on: https://chromium-review.googlesource.com/c/1406530 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#58771}
-
Jakob Gruber authored
This code must move into builtins since --jitless disallows executable memory allocation at runtime. Removing CPU-dependent code will make that step easier. The hope is that processors have gotten better in the last couple of years and this code is unnecessary by now. Bug: v8:8675 Change-Id: I1f2f104befc5f65f1dd69e9643cc51290d2465b8 Reviewed-on: https://chromium-review.googlesource.com/c/1407061Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58770}
-
Georg Neis authored
This is a reland of 2d2c1374 without changes. Offending chromium tests have been modified. Original change's description: > Reland^2 "[turbofan] Use feedback when reducing global loads/stores." > > This reverts commit ac85ab0a. A > chromium test caused trouble and was taken care of in > https://chromium-review.googlesource.com/c/1384064. > > Original change's description: > > [turbofan] Use feedback when reducing global loads/stores. > > > > We already record the script context location or the property cell > > as feedback of the global load/store IC, so Turbofan doesn't need > > to do the lookups again. > > TBR=sigurds@chromium.org > > Change-Id: I58bcd9bceec2f9cf401f7b0fc4460a6da6cd0abc > Reviewed-on: https://chromium-review.googlesource.com/c/1386404 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58393} Change-Id: Ic6734201a6c45f2752488ab44b16859776802f51 Reviewed-on: https://chromium-review.googlesource.com/c/1408252Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58769}
-
Predrag Rudic authored
Failure to make snapshot in debug mode on MIPS was caused by bad floating point register allocation for function parameters. According to MIPS convention, floating point parameters cannot be stored on odd numbered floating point register. Which was the case (f7 was allocated). This patch ensures that f12 and f14 are used for storing fp parameters. To be able to determine types of parameters in InitializePlatformSpecific method, InitializePlatformIndependent has to be executed first. InitializePlatformIndependent requires number of parameters in arguments. That is the reason for changing definitions of CompareDescriptor and BinaryDescriptor classes. Change-Id: I7d723e03385f756114df60e33798400e97d99d8f Reviewed-on: https://chromium-review.googlesource.com/c/1400415Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#58768}
-
Sven Sauleau authored
It removes the assertion that caused the bug report by introducing a new trampoline (WasmBigIntToI64) for the conversion code stub between a Bigint object and a Wasm i64 BigIntToI64). The tests were updated to cover calling the stub from a Wasm callsite. Bug: v8:8625 Change-Id: I55891001cfa72f6f2849792293b43bbb54147f1a Reviewed-on: https://chromium-review.googlesource.com/c/1405028 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#58767}
-
Jakob Gruber authored
This reverts commit 4a9f186b. Reason for revert: Regresses microbenchmarks. https://crbug.com/v8/8675#c5 Original change's description: > [ia32] Remove custom MemMove function > > It isn't clear whether our custom generated MemMove function provides > any benefits over std::memmove. This is an attempt to remove it. If > bots seem unhappy we can revert. > > Bug: v8:7777,v8:8675 > Change-Id: I7f1a6e3050b6e635618593c04f7d51e448426ee2 > Reviewed-on: https://chromium-review.googlesource.com/c/1405854 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58748} TBR=jkummerow@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7777, v8:8675 Change-Id: Ia4ad37070f433f76b1158e90835162aefe38abdd Reviewed-on: https://chromium-review.googlesource.com/c/1407063Reviewed-by:
-
Benedikt Meurer authored
Bug: v8:7522, v8:8673 Change-Id: Iee2d6fda9291fbdd346d25d2c535874dba13fdc9 Ref: nodejs/node#11865 Design-Document: http://bit.ly/v8-zero-cost-async-stack-traces Reviewed-on: https://chromium-review.googlesource.com/c/1396425 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Tom Tan authored
.rdata is the default section which hosts read-only data for COFF. Use this default section name avoids creating a new .rodata section with explicit read-only property. Bug: chromium:919180 Change-Id: I7325cbcfdb142b3ee15de93b7881f755c365d6e6 Reviewed-on: https://chromium-review.googlesource.com/c/1407240 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4fb577f..d419229 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I0d2a9672ca8ea92128f3ce5515cfdc95c6116a49 Reviewed-on: https://chromium-review.googlesource.com/c/1408397Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58763}
-
- 13 Jan, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1fd7544..4fb577f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8a781d8..a9c5056 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5da862435a82ae938106f5ea0d8a97a1dd4780c0 Reviewed-on: https://chromium-review.googlesource.com/c/1408389Reviewed-by:
-
- 12 Jan, 2019 4 commits
-
-
Sigurd Schneider authored
- 'let' instead of 'var', and prefer 'const' - Prefer for-of over indexed interation - Variable names should be 'camel-case' or all-caps snake-case. - Only one variable declaration per line Change-Id: I645dd2333d6d9a993f24c29121f5f156249f1b71 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405320 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58761}
-
Sigurd Schneider authored
Change-Id: I8e147bcb5d1e0b8e16874f0593a8ce4338dfc201 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405319 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
- Ban T[] array syntax - Format arrow function arguments consistently Bug: v8:7327 Notry: true Change-Id: I072a352ec9009948392a6bb5dd4381d4993af7be Reviewed-on: https://chromium-review.googlesource.com/c/1405317 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/211b3ed..889afc2 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/26535fd..1fd7544 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/7d88270..0e1cbc4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0cc5823..96320b5 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/80a1cf6..8432ec2 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I8cd4d39fa2e6b8340b8137af4294e8dbf80b31a6 Reviewed-on: https://chromium-review.googlesource.com/c/1407241Reviewed-by:
-
- 11 Jan, 2019 19 commits
-
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:920561 Change-Id: Ice88e78100d8c87d11e30c8c5fa42c54206c2967 Reviewed-on: https://chromium-review.googlesource.com/c/1363132 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58757}
-
Sergiy Belozorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:920561 Change-Id: Iaf80de577ba2c6b2d22938240aba6b9e432b7427 Reviewed-on: https://chromium-review.googlesource.com/c/1404441Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58756}
-
Adam Klein authored
Bug: chromium:917215 Change-Id: Ie2127953a8ce3d6da4feb3478039ba318774e21d Reviewed-on: https://chromium-review.googlesource.com/c/1404176Reviewed-by:
-
Maya Lekova authored
Bug: v8:8672 Change-Id: I3cd7319f81280447486b713b1b321f6e8ee099f6 Reviewed-on: https://chromium-review.googlesource.com/c/1405855 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit e2d44ede. Reason for revert: Breaks GC stress tests - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23527 Original change's description: > [parser] Inline byte scope data into PreparseData object > > Each PreparseData object had at least one pointer to a PodArray for its > serialized scope data. These objects usually have only tens of bytes of > payload. By inlining the byte data we save 3 words per PreparseData object. > This optimization saves 140KB of data on cnn.com. > > > - Store data_length and inner_length as int32 saving a words on 64bit > - Inline store byte data into PreparseData > - OnHeapConsumedPreparseData directly uses the PreparseData object > - get_inner, set_inner no longer allow Null sentinels > > Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5 > Reviewed-on: https://chromium-review.googlesource.com/c/1406673 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58751} TBR=ulan@chromium.org,cbruni@chromium.org,leszeks@chromium.org Change-Id: I39d92ee7bd2864e1b0c3a8fed4a11b68b3e14d58 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1407073Reviewed-by:
-
Junliang Yan authored
Port 4ab96a9a Original Commit Message: Remove the use of a jump table in the prologue of the deopt entries and instead pass the bailout id explicitly in a register when calling the deopt entry routine from optimized code. This unifies the logic with the way the Arm64 code works. It saves the following amount of memory in code stubs: - arm: 384KB - ia32: 480KB - x64: 240KB This could be offset by a slight increase in the size of optimized code for loading the immediate, however this impact should be minimal and will scale with the maximum number of bailout ids (e.g., the size of code will increase by one instruction per bailout id on Arm, therefore ~98,000 bailouts will be needed before the overhead is greater than the current fixed table size). R=rmcilroy@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id5762334b21e6a91e5ce44b7db1e38ace9147372 Reviewed-on: https://chromium-review.googlesource.com/c/1406026 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#58752}
-
Camillo Bruni authored
Each PreparseData object had at least one pointer to a PodArray for its serialized scope data. These objects usually have only tens of bytes of payload. By inlining the byte data we save 3 words per PreparseData object. This optimization saves 140KB of data on cnn.com. - Store data_length and inner_length as int32 saving a words on 64bit - Inline store byte data into PreparseData - OnHeapConsumedPreparseData directly uses the PreparseData object - get_inner, set_inner no longer allow Null sentinels Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5 Reviewed-on: https://chromium-review.googlesource.com/c/1406673Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Andreas Haas authored
The fuzzers were already removed on the chrome side and therefore inactive, see https://crrev.com/c/1194228. R=machenbach@chromium.org Bug: v8:8562 Change-Id: I0cf5ec6d07e07452c5168ea952f45028bcea1c85 Reviewed-on: https://chromium-review.googlesource.com/c/1406678 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Forced GCs are performed during memory benchmarking to record memory usage, and as such, should not age the bytecode and cause it to be prematurely flushed. BUG=v8:8395 Change-Id: I75c16d8fec29963e49d70738c6a399fd826f6e8b Reviewed-on: https://chromium-review.googlesource.com/c/1393298 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Jakob Gruber authored
It isn't clear whether our custom generated MemMove function provides any benefits over std::memmove. This is an attempt to remove it. If bots seem unhappy we can revert. Bug: v8:7777,v8:8675 Change-Id: I7f1a6e3050b6e635618593c04f7d51e448426ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1405854 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58748}
-
Junliang Yan authored
Change-Id: I060905ed0954365e64c45f7bac53909256f35c0c Reviewed-on: https://chromium-review.googlesource.com/c/1405910Reviewed-by:
-
Jaroslav Sevcik authored
When logging with --logfile-per-isolate, we use isolate addresses to disambiguate. However, it often happens that the isolate addresses are identical for different renderers, so we corrupt the log files. This CL adds pid to the log filename when --logfile-per-isolate is on. Bug: v8:8674 Change-Id: Id664b17d4dbaad2d805379dbe17ecbe08e4ae1f4 Reviewed-on: https://chromium-review.googlesource.com/c/1405853Reviewed-by:
-
Camillo Bruni authored
Drive-by-fix: - Add several iterator instance types to user objects - Add JSProxy instance type to user objects - Rename *PRE_PARSED_SCOPE* to *PREPARSE_DATA* Change-Id: Ia1304871c91bb4e7e46ae0aef6084ded985b9a9f Reviewed-on: https://chromium-review.googlesource.com/c/1405040Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58745}
-
Tamer Tas authored
TestSuite has a static method LoadTestSuite that should properly configure the TestSuite instance (i.e. loaded status files and tests), however the method leaves some configuration logic to the caller. The leaky abstraction causes the caller to do a bunch of loading operations (see the removed methods in base_runner.py). This CL isolates the TestSuite loading logic to the static method only. This is a refactoring only change without any intended logical changes. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I105059c9c9e050f03bb584174e2bd7ceeae2b228 Reviewed-on: https://chromium-review.googlesource.com/c/1396417 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Leszek Swirski authored
It is not legal for destructuring patterns and identifiers in declarations to be in parentheses. This includes nested patterns/identifiers inside another pattern. We were checking sub-patterns for parentheses when parsing possible sub-patterns, but this check missed sub-patterns with a default initialiser (e.g. [({x:y})=1] = {}), as the AssignmentExpression hid the pattern. So, we now additionally record declaration/pattern errors of an assignment LHS when parsing the assignment cover grammar. Bug: v8:8630 Change-Id: Ia5a97003671fc1da7f68d7fb15943928ce9496e3 Reviewed-on: https://chromium-review.googlesource.com/c/1404452Reviewed-by:Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#58743}
-
Ulan Degenbaev authored
This fixes two places that used the marking write barrier for elements instead of the new marking write barrier for descriptor array. This also ensures that revisited objects are marked black. Bug: v8:8651,chromium:917794 Change-Id: Ifc17ff89686f32ccf61d4b3f764b0ab536c42912 Reviewed-on: https://chromium-review.googlesource.com/c/1406670Reviewed-by:
-
Jakob Gruber authored
The JSRegExp's data fixed array is variable size depending on the regexp kind. Bug: v8:8572 Change-Id: I8f07b8e8d2a9a81e0905563fb701e1e3687cafb5 Reviewed-on: https://chromium-review.googlesource.com/c/1405034Reviewed-by:
-
Jakob Gruber authored
As far as I can tell these were unused; their only callers were arm and ppc simulators, but codegen explicitly returned nullptr if in a simulator build, falling back to std::sqrt. There's more potential cleanup to be done here for other functions defined in codegen-*.cc files. Tbr: clemensh@chromium.org Bug: v8:7777, v8:8675 Change-Id: I4b9d6062c6724a810ab094d09e3cd04a0b733d9b Reviewed-on: https://chromium-review.googlesource.com/c/1405851Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58740}
-
Yang Guo authored
R=jarin@chromium.org Bug: v8:8671, v8:8674 Change-Id: I5cdcd49d05f08206aa32426f2fe0560568291f2e Reviewed-on: https://chromium-review.googlesource.com/c/1405852 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
