• Tamer Tas's avatar
    [testrunner] fix leaky abstraction in TestSuite loading process · 234f27b5
    Tamer Tas authored
    TestSuite has a static method LoadTestSuite that should properly configure the
    TestSuite instance (i.e. loaded status files and tests), however the method
    leaves some configuration logic to the caller.
    
    The leaky abstraction causes the caller to do a bunch of loading operations (see
    the removed methods in base_runner.py).
    
    This CL isolates the TestSuite loading logic to the static method only.
    
    This is a refactoring only change without any intended logical changes.
    
    R=machenbach@chromium.org
    CC=​​​yangguo@chromium.org,sergiyb@chromium.org
    
    Bug: v8:8174
    Change-Id: I105059c9c9e050f03bb584174e2bd7ceeae2b228
    Reviewed-on: https://chromium-review.googlesource.com/c/1396417
    Commit-Queue: Tamer Tas <tmrts@chromium.org>
    Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Reviewed-by: 's avatarSergiy Belozorov <sergiyb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58744}
    234f27b5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...