• Leszek Swirski's avatar
    [parser] Check assignment LHS for paren errors · df6f5f6b
    Leszek Swirski authored
    It is not legal for destructuring patterns and identifiers in declarations
    to be in parentheses. This includes nested patterns/identifiers inside
    another pattern.
    
    We were checking sub-patterns for parentheses when parsing possible
    sub-patterns, but this check missed sub-patterns with a default
    initialiser (e.g. [({x:y})=1] = {}), as the AssignmentExpression hid
    the pattern.
    
    So, we now additionally record declaration/pattern errors of an assignment
    LHS when parsing the assignment cover grammar.
    
    Bug: v8:8630
    Change-Id: Ia5a97003671fc1da7f68d7fb15943928ce9496e3
    Reviewed-on: https://chromium-review.googlesource.com/c/1404452Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58743}
    df6f5f6b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...