1. 02 Dec, 2021 1 commit
    • Leszek Swirski's avatar
      [parser] Allow cloning chunked streams · 602de389
      Leszek Swirski authored
      This allows streamed sources to also trigger parallel compile tasks. The
      chunk vectors are shared via std::shared_ptr.
      
      Clone chunked streams are initialised with a null source, and are not
      allowed to fetch any more data. Similarly, the original stream is not
      allowed to fetch data if it has been cloned (since the vector is shared
      and would mutate if we added more data to it).
      
      This is ok for the purposes of cloning for parallel compile tasks, as we
      fully parse before cloning for the task.
      
      Change-Id: Ic268e4956e0894acb63111bf0aaf32eaad426066
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310917
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#78209}
      602de389
  2. 12 Oct, 2021 1 commit
  3. 27 Sep, 2021 1 commit
  4. 24 Jun, 2021 3 commits
  5. 18 Jun, 2021 1 commit
  6. 24 Nov, 2020 1 commit
  7. 07 Jul, 2020 1 commit
  8. 10 Jun, 2020 1 commit
  9. 21 Apr, 2020 1 commit
  10. 13 Aug, 2019 1 commit
  11. 23 May, 2019 1 commit
  12. 12 Mar, 2019 1 commit
  13. 06 Feb, 2019 1 commit
  14. 25 Jan, 2019 1 commit
  15. 27 Nov, 2018 1 commit
  16. 25 Sep, 2018 2 commits
    • Ross McIlroy's avatar
      Reland "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · dc204cc6
      Ross McIlroy authored
      This is a reland of 31228a69
      
      TBR=yangguo@chromium.org,verwaest@chromium.org
      
      Original change's description:
      > [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
      >
      > Splits background compilation data out of ScriptStreamingData and into
      > BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      > of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      > BackgroundCompileTask.
      >
      > As part of this change, we now create the CharacterStream on the main thread,
      > and therefore have to set the (thread-local) runtime_call_stats on the already
      > created CharacterStream when the BackgroundCompileTask is run on the background
      > thread. As such, changes to CharacterStream were needed to feed the
      > runtime_call_stats through appropriately.
      >
      > Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      > no longer used, and the streamed source never has cached data (streaming is
      > suppressed if cached data is available). Also removes Utf8ChunkedStream which
      > is dead code.
      >
      > BUG=v8:8041, v8:8015
      > TBR=yangguo@chromium.org
      >
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      > Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      > Reviewed-on: https://chromium-review.googlesource.com/1236353
      > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56182}
      
      Bug: v8:8041, v8:8015
      Change-Id: Ied5132c537d4c25c6e355f289c2a9cc1f8ff98e9
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1242097
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56201}
      dc204cc6
    • Maya Lekova's avatar
      Revert "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · 875480d2
      Maya Lekova authored
      This reverts commit 31228a69.
      
      Reason for revert: Introduces new pretty consistent flakes on Linux sanitizers, one of which block LKGR. Please see https://crbug.com/v8/8219
      
      Original change's description:
      > [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
      > 
      > Splits background compilation data out of ScriptStreamingData and into
      > BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      > of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      > BackgroundCompileTask.
      > 
      > As part of this change, we now create the CharacterStream on the main thread,
      > and therefore have to set the (thread-local) runtime_call_stats on the already
      > created CharacterStream when the BackgroundCompileTask is run on the background
      > thread. As such, changes to CharacterStream were needed to feed the
      > runtime_call_stats through appropriately.
      > 
      > Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      > no longer used, and the streamed source never has cached data (streaming is
      > suppressed if cached data is available). Also removes Utf8ChunkedStream which
      > is dead code.
      > 
      > BUG=v8:8041, v8:8015
      > TBR=yangguo@chromium.org
      > 
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      > Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      > Reviewed-on: https://chromium-review.googlesource.com/1236353
      > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56182}
      
      TBR=rmcilroy@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Change-Id: Ib05bcbde2e9a588bd4008d2155f75cdac5cc47f5
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8041, v8:8015
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1241958Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56187}
      875480d2
  17. 24 Sep, 2018 1 commit
    • Ross McIlroy's avatar
      [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher · 31228a69
      Ross McIlroy authored
      Splits background compilation data out of ScriptStreamingData and into
      BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      BackgroundCompileTask.
      
      As part of this change, we now create the CharacterStream on the main thread,
      and therefore have to set the (thread-local) runtime_call_stats on the already
      created CharacterStream when the BackgroundCompileTask is run on the background
      thread. As such, changes to CharacterStream were needed to feed the
      runtime_call_stats through appropriately.
      
      Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      no longer used, and the streamed source never has cached data (streaming is
      suppressed if cached data is available). Also removes Utf8ChunkedStream which
      is dead code.
      
      BUG=v8:8041, v8:8015
      TBR=yangguo@chromium.org
      
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      Reviewed-on: https://chromium-review.googlesource.com/1236353
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56182}
      31228a69
  18. 17 Sep, 2018 1 commit
  19. 14 Sep, 2018 1 commit
  20. 04 Sep, 2018 1 commit
  21. 28 Aug, 2018 1 commit
  22. 21 Aug, 2018 1 commit
    • Toon Verwaest's avatar
      [scanner] Go back to untemplatized scanning with buffering · fcfd995a
      Toon Verwaest authored
      This reverts the following 3 CLs:
      
      Revert "[scanner] Templatize scan functions by encoding"
      Revert "[asm] Remove invalid static cast of character stream"
      Revert "[scanner] Prepare CharacterStreams for specializing scanner and parser by character type"
      
      The original idea behind this work was to avoid copying, converting and
      buffering characters to be scanned by specializing the scanner functions. The
      additional benefit was for scanner functions to have a bigger window over the
      input. Even though we can get a pretty nice speedup from having a larger
      window, in practice this rarely helps. The cost is a larger binary.
      
      Since we can't eagerly convert utf8 to utf16 due to memory overhead, we'd also
      need to have a specialized version of the scanner just for utf8. That's pretty
      complex, and likely won't be better than simply bulk converting and buffering
      utf8 as utf16.
      
      Change-Id: Ic3564683932a0097e3f9f51cd88f62c6ac879dcb
      Reviewed-on: https://chromium-review.googlesource.com/1183190Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55258}
      fcfd995a
  23. 20 Aug, 2018 1 commit
  24. 02 Aug, 2018 1 commit
  25. 01 Aug, 2018 1 commit
  26. 30 Jul, 2018 1 commit
  27. 26 Jul, 2018 2 commits
  28. 13 Jul, 2018 1 commit
    • Michael Lippautz's avatar
      Revert "Reland "[heap] Added External Strings to external memory accounting."" · 71dddd14
      Michael Lippautz authored
      This reverts commit 7bff339e.
      
      Reason for revert: Breaks autoroll, see bug.
      
      Bug: v8:7944
      
      Original change's description:
      > Reland "[heap] Added External Strings to external memory accounting."
      > 
      > This is a reland of 5863c0b6
      > 
      > Original change's description:
      > > [heap] Added External Strings to external memory accounting.
      > > 
      > > Bug: chromium:845409
      > > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550
      > > Reviewed-on: https://chromium-review.googlesource.com/1118164
      > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com>
      > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#54110}
      > 
      > Bug: chromium:845409
      > Change-Id: Ied341ec6268000343d2a577b22f2a483460b01f5
      > Reviewed-on: https://chromium-review.googlesource.com/1121736
      > Commit-Queue: Rodrigo Bruno <rfbpb@google.com>
      > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54410}
      
      TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,petermarshall@chromium.org,rfbpb@google.com
      
      Change-Id: Ie55586e84f44a2d83c7f97110d60abb86f0730c5
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:845409
      Reviewed-on: https://chromium-review.googlesource.com/1136312Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54428}
      71dddd14
  29. 12 Jul, 2018 1 commit
  30. 05 Jul, 2018 3 commits
  31. 04 Jul, 2018 2 commits
  32. 09 Apr, 2018 1 commit
  33. 06 Apr, 2018 1 commit
    • Michael Achenbach's avatar
      Revert "[cleanup] Refactor the Factory" · 503e07c3
      Michael Achenbach authored
      This reverts commit f9a2e24b.
      
      Reason for revert: gc stress failures not all fixed by follow up.
      
      Original change's description:
      > [cleanup] Refactor the Factory
      > 
      > There is no good reason to have the meat of most objects' initialization
      > logic in heap.cc, all wrapped by the CALL_HEAP_FUNCTION macro. Instead,
      > this CL changes the protocol between Heap and Factory to be AllocateRaw,
      > and all object initialization work after (possibly retried) successful
      > raw allocation happens in the Factory.
      > 
      > This saves about 20KB of binary size on x64.
      > 
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: Icbfdc4266d7be8b48d2fe085f03411743dc6a0ca
      > Reviewed-on: https://chromium-review.googlesource.com/959533
      > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52416}
      
      TBR=jkummerow@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,hpayer@chromium.org
      
      Change-Id: Idbbc53478742f3e9525eee83342afc6aedae122f
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/999414Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52420}
      503e07c3