[api] Deprecate Set/ResetToBookmark

Used to be needed for streaming but we don't use it anymore.

Change-Id: I0947155bec38a6b329452e42204f07170a72c155
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217195
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77339}

include/v8-script.h

@@ -465,21 +465,16 @@ class V8_EXPORT ScriptCompiler {
     virtual size_t GetMoreData(const uint8_t** src) = 0;
 
     /**
-     * V8 calls this method to set a 'bookmark' at the current position in
-     * the source stream, for the purpose of (maybe) later calling
-     * ResetToBookmark. If ResetToBookmark is called later, then subsequent
-     * calls to GetMoreData should return the same data as they did when
-     * SetBookmark was called earlier.
-     *
-     * The embedder may return 'false' to indicate it cannot provide this
-     * functionality.
+     * [DEPRECATED]: No longer used, will be removed soon.
      */
-    virtual bool SetBookmark();
+    V8_DEPRECATED("Not used")
+    virtual bool SetBookmark() { return false; }
 
     /**
-     * V8 calls this to return to a previously set bookmark.
+     * [DEPRECATED]: No longer used, will be removed soon.
      */
-    virtual void ResetToBookmark();
+    V8_DEPRECATED("Not used")
+    virtual void ResetToBookmark() {}
   };
 
   /**

src/api/api.cc

@@ -1962,10 +1962,6 @@ ScriptCompiler::CachedData::~CachedData() {
   }
 }
 
-bool ScriptCompiler::ExternalSourceStream::SetBookmark() { return false; }
-
-void ScriptCompiler::ExternalSourceStream::ResetToBookmark() { UNREACHABLE(); }
-
 ScriptCompiler::StreamedSource::StreamedSource(
     std::unique_ptr<ExternalSourceStream> stream, Encoding encoding)
     : impl_(new i::ScriptStreamingData(std::move(stream), encoding)) {}

test/cctest/parsing/test-scanner-streams.cc

@@ -42,8 +42,6 @@ class ChunkSource : public v8::ScriptCompiler::ExternalSourceStream {
     chunks_.push_back({nullptr, 0});
   }
   ~ChunkSource() override = default;
-  bool SetBookmark() override { return false; }
-  void ResetToBookmark() override {}
   size_t GetMoreData(const uint8_t** src) override {
     DCHECK_LT(current_, chunks_.size());
     Chunk& next = chunks_[current_++];