- 30 Oct, 2019 31 commits
-
-
Ng Zhi An authored
These are SSE instructions that deal with scalar single precision values, and look like the packed single precision variant of the instructions, but with a prefix. E.g. sqrtps is NP 0F 51, sqrtss is F3 0F 51. Bug: v8:9810 Change-Id: I417ea6d4d85d8618ad6602a1b32d4428db0d66d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874509Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64658}
-
Michael Starzinger authored
R=clemensb@chromium.org TEST=mjsunit/wasm/streaming-error-position Change-Id: Ia1e95f5c5b0f90a98848951333c4c4aa4ebafefe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889880 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64657}
-
Joshua Litt authored
Bug: v8:9838 Change-Id: Ibdb985243fe121057f982712b2909f45e0ae175c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869490 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#64656}
-
Georg Neis authored
... since we may be in the background. Print the HeapObjectRef instead, which will read the heap when it's allowed to do so. Bug: v8:9541 Change-Id: I201c6dcd83e1b050393d633e4d59aec636772da6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889876 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64655}
-
Michael Starzinger authored
This fixes the streaming decoder to report the correct error position for repeating code sections (i.e. only one code section per module). R=clemensb@chromium.org Change-Id: Ie02d704d74b4e051fa9b00288dd6d1e46e2418a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890094 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Backes authored
Each run of {OnFinishedUnits} can only trigger baseline completion or top tier completion at most once, so we can pull the call out of the loop. R=ahaas@chromium.org Change-Id: I7eaf42addbbaa9600cb9bf95dce76399be683971 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889879Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64653}
-
Milad Farazmand authored
Port b875f466 Original Commit Message: This is a reland of 4a16305b The original CL adjust only one part of the stack check, namely the comparison of the stack pointer against the stack limit in generated code. There is a second part: Runtime::kStackGuard repeats this check to distinguish between a stack overflow and an interrupt request. This second part in runtime must apply the offset just like in generated code. It is implemented in this reland by the StackCheckOffset operator and a new StackGuardWithGap runtime function. Original change's description: > [compiler] Optionally apply an offset to stack checks > > The motivation behind this change is that the frame size of an optimized > function and its unoptimized version may differ, and deoptimization > may thus trigger a stack overflow. The solution implemented in this CL > is to optionally apply an offset to the stack check s.t. the check > becomes 'sp - offset > limit'. The offset is applied to stack checks at > function-entry, and is set to the difference between the optimized and > unoptimized frame size. > > A caveat: OSR may not be fully handled by this fix since we've already > passed the function-entry stack check. A possible solution would be to > *not* skip creation of function-entry stack checks for inlinees. > > This CL: 1. annotates stack check nodes with the stack check kind, where > kind is one of {function-entry,iteration-body,unknown}. 2. potentially > allocates a temporary register to store the result of the 'sp - offset' > in instruction selection (and switches input registers to 'unique' > mode). 3. Applies the offset in code generation. > > Drive-by: Add src/compiler/globals.h for compiler-specific globals. > > Bug: v8:9534,chromium:1000887 > Change-Id: I257191c4a4978ccb60cfa5805ef421f30f0e9826 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762521 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63701} R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I37bf1d9157a96a5d3538108703f2d7469a11bffe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890535Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64652}
-
Sigurd Schneider authored
This CL removes a GC invocation which might not be needed anymore. This CL picks up on a previous attempt to remove this invocation: crrev.com/c/928241 Bug: chromium:1005906, chromium:1019613 Change-Id: I487b5bfd51532fe60cd71444b53874f20eecdf16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1883566Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64651}
-
Santiago Aboy Solanes authored
In the case where we fail on the 'before register allocation' phase, we will have the instructions to print, but turbolizer will fail to show them because it will look for the non-existent offsets. Bug: v8:7327 Change-Id: I52e520dcb662fe9931f1bb29cd2c16cd62913158 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889883Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64650}
-
Nico Hartmann authored
Bug: v8:9192 Change-Id: Idd89fd36d4b334b46505bf0b35b7ce2472e6bf08 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890098 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64649}
-
Santiago Aboy Solanes authored
Test for the HeapConstant reduction. Move heap_constants to a scope where it can be reused by other tests. Bug: v8:7703 Change-Id: I1da1dd7ad65670980867aa5319b96cc9c701c5a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1876064 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Ingvar Stepanyan authored
Some tools that transform Wasm today, already support encoding the transforms and correctly updating locations in source maps, but not yet in DWARF (although this is being worked on). Until they catch up, it's best to consistently prefer source maps over DWARF when both are present, and not just rely on order of sections as accidentally done in the previous CL that introduced DWARF info. Ref: crrev.com/c/v8/v8/+/1834341 Bug: chromium:1016772 Change-Id: I769311e2096ae0e4ca304bef0a0453c7e0776aae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888930 Commit-Queue: Ingvar Stepanyan <rreverser@google.com> Reviewed-by:
-
Clemens Backes authored
The same functionality can be achieved by just setting a breakpoint in that function. R=ahaas@chromium.org Bug: v8:9810 Change-Id: Ieb5e99b5c2f0b492e32e75cae0c0b9292accd932 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888072Reviewed-by:
-
Liviu Rau authored
This reverts commit b3c6e1ac. Reason for revert: The build time incresed significantly. We want to investigate if we can reduce it by removing the 'packaging' step. Original change's description: > Activate is_offcial_build option for perf builders > > Bug: v8:9898 > Change-Id: I41e1fcb37755906e29e6937b805cfb3018e90438 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888937 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64640} TBR=machenbach@chromium.org,tmrts@chromium.org,liviurau@chromium.org Change-Id: Ifbae1d7aedbfb7e4f7622c5a2bec74bc2f06e7f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9898 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890092Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#64645}
-
Santiago Aboy Solanes authored
Bug: v8:7703 Change-Id: I33e0c82c25d0c43f940d6cf0aff0abc04403b095 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1876058 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:7703 Change-Id: I06c47aa4057362d52e53b6a45d4e8a5febb92c82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1876055 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Temporarily enable the flag to test the performance of the DecompressionOptimization reducer. Bug: v8:7703 Change-Id: Ia55d732a73f2aef7ef6e3da329c19b2752a41459 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890091Reviewed-by:
-
Jakob Gruber authored
The test was originally skipped due to slowness. This might have been fixed by reduced store-store zone allocations (see the linked bug). Locally, this now runs in less than 20 seconds in full x64 debug mode. The largest zone is < 100MB: 12089344, "V8.TFAllocateGeneralRegisters" 21954208, "graph-zone" 26181688, "../../src/compiler/verifier.cc:2000" 57895456, "instruction-zone" 98933872, "register-allocation-zone" Drive-by: Remove tsan SLOW annotation, it's already marked SLOW in the ALWAYS block. Bug: v8:9572 Change-Id: Ic3ffd3de732e262f412f1d7a66448ea7228582f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889872 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Liviu Rau authored
Bug: v8:9898 Change-Id: I41e1fcb37755906e29e6937b805cfb3018e90438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888937Reviewed-by:
-
Santiago Aboy Solanes authored
It was used only with Register inputs, so we can replace its uses with the Registers themselves. Change-Id: I1ea3ed88ee41177b696a7281cdf3b90fefdc5870 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886916Reviewed-by:
-
Santiago Aboy Solanes authored
Smi checks get lowered to Word32And, so they are important to consider in the reducer. Bug: v8:7703 Change-Id: Ie6e2403db84f83808edcc1e44ecb60ecd72ae34d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1876053 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64638}
-
Santiago Aboy Solanes authored
Effect control linearization knows about compressed values only when DecompressionElimination is active. Bug: v8:7703 Change-Id: I7854488322f846f94c644e057ab1c32641adf662 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1883896Reviewed-by:
-
Gus Caplan authored
Change-Id: I2a1ad1835b751237b350e56d64e3475459bfb7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873715 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Change SlotSet representation to a variable-sized array of pointers to buckets. The length of the array/number of buckets depends on the size of the page. Before this change the SlotSet always stored a fixed number of buckets. Large pages needed a SlotSet-Array to cover the whole object. Now both regular and large pages both use a single SlotSet object, which contains all bucket pointers. Change-Id: I2d8d62fad54b58409cd39ae7a52c64497ee7c261 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1876811Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is a reland of 4a16305b The original CL adjust only one part of the stack check, namely the comparison of the stack pointer against the stack limit in generated code. There is a second part: Runtime::kStackGuard repeats this check to distinguish between a stack overflow and an interrupt request. This second part in runtime must apply the offset just like in generated code. It is implemented in this reland by the StackCheckOffset operator and a new StackGuardWithGap runtime function. Original change's description: > [compiler] Optionally apply an offset to stack checks > > The motivation behind this change is that the frame size of an optimized > function and its unoptimized version may differ, and deoptimization > may thus trigger a stack overflow. The solution implemented in this CL > is to optionally apply an offset to the stack check s.t. the check > becomes 'sp - offset > limit'. The offset is applied to stack checks at > function-entry, and is set to the difference between the optimized and > unoptimized frame size. > > A caveat: OSR may not be fully handled by this fix since we've already > passed the function-entry stack check. A possible solution would be to > *not* skip creation of function-entry stack checks for inlinees. > > This CL: 1. annotates stack check nodes with the stack check kind, where > kind is one of {function-entry,iteration-body,unknown}. 2. potentially > allocates a temporary register to store the result of the 'sp - offset' > in instruction selection (and switches input registers to 'unique' > mode). 3. Applies the offset in code generation. > > Drive-by: Add src/compiler/globals.h for compiler-specific globals. > > Bug: v8:9534,chromium:1000887 > Change-Id: I257191c4a4978ccb60cfa5805ef421f30f0e9826 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762521 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63701} Bug: v8:9534, chromium:1000887 Change-Id: I71771c281afd7d57c09aa48ea1b182d01e6dee2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822037Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Backes authored
{Smi::ToInt} has only one character more. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I1e91bb3623a354ceeee1dc93822011a6809281d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886922Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64633}
-
Ulan Degenbaev authored
This is the first step in unification of concurrent and main thread marking visitors. The new MarkingVisitorBase will become a base class for all marking visitors and will remove the existing code duplication. This is a refactoring without behavior change. Subsequent CL will change the main thread marking visitor to derive from the new base class. Bug: chromium:1019218 Change-Id: I3d47030d396e0ba6706882fbd922bbcac46181b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886920Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#64632}
-
Clemens Backes authored
The macros were probably duplicated when splitting off liftoff-assembler.cc from liftoff-compiler.cc, but are dead now. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I668ce598815c45cc690653b5a12d90ab44937204 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888070Reviewed-by:
-
Dominik Inführ authored
Start experiment with promoting all young live objects during mark-compact. This CL sets always_promote_young_mc to true by default. Change-Id: I306527ad2a361fc3e0edcf684c5ccec2b1d6e491 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879938Reviewed-by:
-
Jakob Gruber authored
The `capture_ix` refers to all captures while `capture_count` only refers to named captures. Clarified by renaming `capture_count` to `named_capture_count` and removing the incorrect part of the DCHECK. The `>= 1` part of the condition must still hold since named captures can only refer to explicit capture groups, which start at index 1. Tbr: petermarshall@chromium.org Bug: chromium:1018592 Change-Id: If8a26f6661ba0483d585f74270b3b4a3853e2ca8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886810Reviewed-by:
-
Zhao Jiazhong authored
Port 1e4bb087 https://crrev.com/c/1826728 Change-Id: If977914ef55eb65228f92fecd1c9e9d0f625fa2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886716Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#64628}
-
- 29 Oct, 2019 9 commits
-
-
Johannes Henkel authored
Change-Id: Ie73b21c284052a66ce18f0686030ee0a11f49d3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1887631 Commit-Queue: Johannes Henkel <johannes@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Johannes Henkel authored
Also we're not creating these any more via StringUtil in blink, so these two helpers can go. Change-Id: Ifdf700171ebc46cfbd6ce0af9a6f6ba73419a5a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1887689 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Andreas Haas authored
The new API with v8::BackingStore should be used instead as explained in https://docs.google.com/document/d/1sTc_jRL87Fu175Holm5SV0kajkseGl2r8ifGY76G35k This also relaxes the pre-condition for [Shared]ArrayBuffer::Detach to not require externalization first. Bug: v8:9380, v8:9908 Change-Id: Idd119fcd28be84a2fae74ae86f7381fd997766f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859628 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Changes introduced in 30ec6a89 generates compilation error in gcc 8.1.0: 8.1.0/include/c++/bits/stl_iterator_base_funcs.h:183:2: error: no match for 'operator--' (operand type is 'v8::internal::HandlerTable::LookupReturn(int)::Iterator') --__i; Which maybe caused by the following change in stl_iterator_base_funcs: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=248875 Overloading the "--" operator fixes the compilation error. Change-Id: I32f54ddd4993375bf905996b5b1e66cd005256da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888190 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 3c6ecf71 Original Commit Message: Object::operator-> was removed in https://chromium-review.googlesource.com/c/v8/v8/+/1624788 but a few subclasses still had their own implementations. R=seth.brenith@microsoft.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I0f4902250ef1f80d2e06c71f27a0bee0717cf5ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888191Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Clemens Backes authored
This flag would help customers understand why Liftoff bails out, thus make it available also in release builds. R=jkummerow@chromium.org Change-Id: Ie2f69cbeaee617632f772030a3e03f052f688a10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888071Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64622}
-
Frank Tang authored
Bug: v8:9912 Change-Id: Ib9deba176f7aaa2ffca2db811c5273af673028ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1884955Reviewed-by:
-
Ng Zhi An authored
There are a couple of bugs here: 1. The immediate used for vinsertps is wrong when lane == 1, the first two bits specify which element of the source is copied, and it should always be 00, 01 to copy the first 2 lanes of source. 2. For both cases, the second insertps call should be using dst as the src, since dst was already updated by the first insertps call, it was incorrectly using the old value of src. This was probably working correctly because in many cases dst and src happened to be the same register. 3. rep cannot be same as dst, because dst is overwritten, and rep should stay the same I also modified the F64x2ReplaceLane to test separately for replacing lane 0 and lane 1. Fixed bug 3. for arm and arm64. Bug: v8:9728 Change-Id: Iec6e48bcfbc7d27908dd86d5f113a8b5dedd499b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1877055Reviewed-by:
-
Seth Brenith authored
Object::operator-> was removed in https://chromium-review.googlesource.com/c/v8/v8/+/1624788 but a few subclasses still had their own implementations. Change-Id: Ie2c4df4cd0af0bdba8838aaf2f3852c61e227aa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1884950Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#64619}
-
