• Ng Zhi An's avatar
    [wasm-simd] Fix f64x2 replace lane · f3cbcdb2
    Ng Zhi An authored
    There are a couple of bugs here:
    
    1. The immediate used for vinsertps is wrong when lane == 1, the first
    two bits specify which element of the source is copied, and it should
    always be 00, 01 to copy the first 2 lanes of source.
    2. For both cases, the second insertps call should be using dst as the
    src, since dst was already updated by the first insertps call, it was
    incorrectly using the old value of src. This was probably working
    correctly because in many cases dst and src happened to be the same
    register.
    3. rep cannot be same as dst, because dst is overwritten, and rep should
    stay the same
    
    I also modified the F64x2ReplaceLane to test separately for replacing
    lane 0 and lane 1.
    
    Fixed bug 3. for arm and arm64.
    
    Bug: v8:9728
    Change-Id: Iec6e48bcfbc7d27908dd86d5f113a8b5dedd499b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1877055Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64620}
    f3cbcdb2
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...