- 12 May, 2021 1 commit
-
-
Ng Zhi An authored
This is a reland of 3356078a. The fix is in PS2: - fix the DCHECK to be triggered only if dst != src, the dcheck is meant to prevent rep from being overwritten, which happens only if dst != src - fix instruction selector for f64x2.replace_lane, require SameAsFirst only for non-AVX, which makes dst == src, saving a move - on x64 we also require all registers, since the macro-assembler helper only handles registers Original change's description: > [wasm-simd][x64][ia32] Factor f64x2.replace_lane into shared code > > This pblendw/movlhps combination has lower latency and requires less > unop than pinsrq (1 v.s. 2). > > Bug: v8:11589 > Change-Id: I770b0c20a286774afefbac5ef0adffe463318f21 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2828871 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74049} Bug: v8:11589 Change-Id: I51cba0539d5241242dc4d7d971ede1940b9ac1fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2842264 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#74545}
-
- 19 Apr, 2021 2 commits
-
-
Zhi An Ng authored
This reverts commit b824d853. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20debug/36784/overview Original change's description: > [wasm-simd][x64][ia32] Factor f64x2.replace_lane into shared code > > This pblendw/movlhps combination has lower latency and requires less > unop than pinsrq (1 v.s. 2). > > Bug: v8:11589 > Change-Id: I770b0c20a286774afefbac5ef0adffe463318f21 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2828871 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74049} Bug: v8:11589 Change-Id: I1be96e59fdb844db1e228be3a09d4a06798a16c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2837805 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74050}
-
Ng Zhi An authored
This pblendw/movlhps combination has lower latency and requires less unop than pinsrq (1 v.s. 2). Bug: v8:11589 Change-Id: I770b0c20a286774afefbac5ef0adffe463318f21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2828871Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#74049}
-
- 15 Apr, 2021 1 commit
-
-
Ng Zhi An authored
Bug: v8:11589 Change-Id: I6f43e6382b3441adf59dbaea58d766013cf3793b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826712Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73983}
-
- 22 Mar, 2021 1 commit
-
-
Deepti Gandluri authored
Removing prefetch operations as per the vote in the github issue: https://github.com/WebAssembly/simd/pull/352 Bug:v8:11168 Change-Id: Ia72684e68ce886f8f26a7d3b5bea601be416dfab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2771758Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#73578}
-
- 10 Mar, 2021 1 commit
-
-
Ng Zhi An authored
This is done with a script that does something like: files=$(ag 'v\d\d?x\d\d?[._]?all_?true' -l) sed -i 's/V\(8x16\|16x8\|32x4\|64x2\)\([._]\?\)\([aA]ll_\?[tT]rue\)/I\1\2\3/g' $(files) sed -i 's/v\(8x16\|16x8\|32x4\|64x2\)\([._]\?\)\([aA]ll_\?[tT]rue\)/i\1\2\3/g' $(files) And manual fixups in test-run-wasm-simd.cc and wasm-opcodes-inl.h. Bug: v8:10946 Change-Id: Ib5dad388dd6dd9cd0fb575ad961dffc189a2e6ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2740488Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73309}
-
- 04 Mar, 2021 3 commits
-
-
Ng Zhi An authored
This is a reland of 77838343 No changes in this reland, this wasn't causing the failures, see https://crbug.com/1163833 for the actual cause. Original change's description: > [wasm-simd] Remove add horiz instructions > > Bug: v8:6020 > Change-Id: I0605798d03f2e9f9c3c07c49141289889a10a3b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727204 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73180} Bug: v8:6020 Change-Id: I83d59ed800bd73c81cb879b4ba3a5144045c62d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2733663Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73200}
-
Shu-yu Guo authored
This reverts commit 77838343. Reason for revert: Mysterious win32 test262 failures: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win32%20-%20debug/30119/overview Original change's description: > [wasm-simd] Remove add horiz instructions > > Bug: v8:6020 > Change-Id: I0605798d03f2e9f9c3c07c49141289889a10a3b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727204 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73180} Bug: v8:6020 Change-Id: Id1a58d7689d506b17ed04a7df67fec4003bc523d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2733662 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73181}
-
Ng Zhi An authored
Bug: v8:6020 Change-Id: I0605798d03f2e9f9c3c07c49141289889a10a3b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727204Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73180}
-
- 26 Feb, 2021 1 commit
-
-
Ng Zhi An authored
These were prototyped and not merged into the SIMD proposal. Bug: v8:10983 Change-Id: I5c30a0e9955ee5602e05d473f0f85be59d124205 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718761Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73080}
-
- 25 Feb, 2021 1 commit
-
-
Ng Zhi An authored
This instruction is not in the final SIMD proposal. Bug: v8:6020 Change-Id: Ifef1b3d58bf660f2d30784f587aed85f327825ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716073 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#73058}
-
- 12 Feb, 2021 2 commits
-
-
Ng Zhi An authored
Same code sequence as x64. Bug: v8:11416 Change-Id: Ibbd4cbf75e10b0ce876d42809d909868fdb86b87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2686309Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72724}
-
Ng Zhi An authored
This is a reland of a16add80. The fixes are adding disassembly for pcmpgtq and vpcmpgtq. While fixing also noticed a mistake in assembler for pcmpgtq, which flipped dst and src. Also realized that we don't detect SSE4.2, so adding that in. PS2 contains these changes. Original change's description: > [wasm-simd][ia32] Implement i64x2 signed compares > > The code sequence is exactly the same as x64. > > Bug: v8:11415 > Change-Id: I53ed2723eda29c0a250cff514372a3d45b203476 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2683495 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72637} Bug: v8:11415 Change-Id: If6a18af2d7de20ac8ad38f94b6d0220769397194 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2688119Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72721}
-
- 10 Feb, 2021 2 commits
-
-
Zhi An Ng authored
This reverts commit a16add80. Reason for revert: Broke Win32 debug https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win32%20-%20debug/29653/overview Original change's description: > [wasm-simd][ia32] Implement i64x2 signed compares > > The code sequence is exactly the same as x64. > > Bug: v8:11415 > Change-Id: I53ed2723eda29c0a250cff514372a3d45b203476 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2683495 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72637} TBR=bbudge@chromium.org,zhin@chromium.org Change-Id: Idbfc8cd0fbbff607cff76953c53d0c149b87b573 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2688074Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72640}
-
Ng Zhi An authored
The code sequence is exactly the same as x64. Bug: v8:11415 Change-Id: I53ed2723eda29c0a250cff514372a3d45b203476 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2683495Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72637}
-
- 05 Feb, 2021 1 commit
-
-
Bill Budge authored
- Reworks the code structure to break out 3 major cases: Immediate, MemoryOperand, and LocationOperand. - InstructionSelector passes an additional immediate operand, the push size in bytes, so we can generate correct code for the Immediate case. Bug: v8:9198 Change-Id: I86cd41826150aa84b158fdbb1d3e8f3e93755119 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2673273 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#72553}
-
- 04 Feb, 2021 1 commit
-
-
Ng Zhi An authored
Implement these 6 instructions: - f64x2.convert_low_i32x4_s - f64x2.convert_low_i32x4_u - i32x4.trunc_sat_f64x2_s_zero - i32x4.trunc_sat_f64x2_u_zero - f32x4.demote_f64x2_zero - f64x2.promote_low_f32x4 The code sequences are exactly the same as on x64. Needed to add some more instructions, and we don't have macro lists for these instructions yet, so individually define them for now. We can factor them into lists in a future change. Bug: v8:11265 Change-Id: I606e1226201e3c5ecdc7e3f611315437e917d77c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2668913Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72535}
-
- 03 Feb, 2021 1 commit
-
-
Ng Zhi An authored
Bug: v8:11347,v8:11348 Change-Id: I47ba950b80197d1d769d93aa68266131be9bf31d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666146Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72518}
-
- 02 Feb, 2021 2 commits
-
-
Ng Zhi An authored
Code sequence from https://github.com/WebAssembly/simd/pull/379, and exactly the same as x64, with minor tweaks for ExternalReferenceAsOperand. Bug: v8:11002 Change-Id: Icbfdac62b21c2734ad4886b3d48f34e29f7a8222 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664860 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72495}
-
Ng Zhi An authored
Bug: v8:11217 Change-Id: I6e61b11babc0baecf7b1982ef779b941d3344182 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667971Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72493}
-
- 21 Jan, 2021 1 commit
-
-
Deepti Gandluri authored
Bug: v8:11168 Change-Id: I6f697363d6f6d9b6a2303dec848f6d5200613f0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641198 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72240}
-
- 13 Jan, 2021 1 commit
-
-
Deepti Gandluri authored
Bug: v8:11217 Change-Id: Ic58b0ac90fa227cadc35829bd1e5629f6749020a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2616102 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72083}
-
- 12 Jan, 2021 2 commits
-
-
Zhi An Ng authored
Prototype these 4 instructions: - i64x2.widen_low_i32x4_s - i64x2.widen_high_i32x4_s - i64x2.widen_low_i32x4_u - i64x2.widen_high_i32x4_u Implementation is the same as x64. Drive-by fix to add a missing CpuFeatureScope to x64. Bug: v8:10972 Change-Id: Iacc84bce156053d0ac39b1a419727c93c499a8c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2612339 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72025}
-
Zhi An Ng authored
Implementation is the same as x64. Disassembly support for the new instruction, pmulhrsw, is already supported due to the macro list. Bug: v8:10971 Change-Id: I099c4f8c3da521006ef5e2b151626f25a5df1ed9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2620898Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72021}
-
- 11 Jan, 2021 1 commit
-
-
Zhi An Ng authored
This allows us to reuse this optimized code sequence in Liftoff. This is similar to the x64 implementation, except that the macro-assembler function takes an additional scratch register. Change-Id: Ieaa5899cd1be65abee1c6e0c0908a357777afcd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2610510Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71996}
-
- 17 Dec, 2020 1 commit
-
-
Zhi An Ng authored
Same pattern matching and implementation as x64 here: https://crrev.com/c/2589062. Change-Id: I11f8df79ab9910af9c7a97e2382144703be5916d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2591851Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71816}
-
- 15 Dec, 2020 1 commit
-
-
Zhi An Ng authored
Codegen is identical to x64. Tweaked a macro definition to do a dst == src1 check when AVX is not supported, and updated a single caller in LiftOff. Bug: v8:11086 Change-Id: Ic9645f3d1bf1c26a1aa6db6bc2fa67fc991f8bbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2579928 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#71756}
-
- 14 Dec, 2020 4 commits
-
-
Zhi An Ng authored
Drive-by fix IWYU for instruction-scheduler-ia32.cc. Bug: v8:11217,v8:7490 Change-Id: I7ae4fdaf3c48274e9421e6b31897ad0ea1464876 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2585254Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71750}
-
Zhi An Ng authored
Change the codegen for f32x4.extract_lane from shufps to insertps. They have the same performance, but shufps has a false dependency on dst (it shuffles dst and src, but we don't care about dst at all). We then merge the SSE and AVX opcode. Bug: v8:11217 Change-Id: I7cdbf486573ce3a19881df84400a9c7e09c3ee48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2585259Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71748}
-
Zhi An Ng authored
Drive-by cleanup: IWYU for macro-assembler-ia32.cc. IWYU added src/heap/basic-memory-chunk.h which failed a presubmit, so I updated src/DEPS to allow for including it. Bug: v8:11217,v8:7490 Change-Id: I63662bfb2b34e354e94f6052edfcb92f1341da58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2583675Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71729}
-
Zhi An Ng authored
Drive-by cleanup: IWYU for macro-assembler-ia32.h and instruction-selector-ia32.cc Ran using `iwyu_tool.py -p out/ia32.debug <filename>`, with a local build of llvm and iwyu. Bug: v8:11217,v8:7490 Change-Id: I4f8e95fa9be2f51f6764c994bb4da9ae86854c4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2583671Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71728}
-
- 11 Dec, 2020 1 commit
-
-
Zhi An Ng authored
Implementation is almost identical to x64, except that in the instruction-selector, for AVX, we allow the second operand to be a slot, and so we use InputOperand in the codegen. Bug: v8:11008 Change-Id: I5b5ea4b5058dc0bf5ff1c24a67f9b787c5312106 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576887Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71705}
-
- 09 Dec, 2020 1 commit
-
-
Zhi An Ng authored
Bug: v8:11217 Change-Id: I82719eb2c4b35cc54fc1b4b6f01eca6a48afb152 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576884Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71672}
-
- 07 Dec, 2020 2 commits
-
-
Zhi An Ng authored
Bug: v8:11217 Change-Id: I4a02af1b9b07470134ea893d532c545da63b26d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568922 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#71632}
-
Zhi An Ng authored
This is a reland of 716dae3a Original change's description: > [wasm-simd][ia32] Prototype sign select > > The implementation is the same as on x64. > > Bug: v8:10983 > Change-Id: I2654ce4a627ca5cc6c759051ab9034c528d9f25a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567194 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71606} Bug: v8:10983 Change-Id: I05af92ec2d3531dd2e0d27353cc665967fb5c387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2574001 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#71627}
-
- 04 Dec, 2020 3 commits
-
-
Zhi An Ng authored
This reverts commit 716dae3a. Reason for revert: broke noavx build https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/33124/overview Original change's description: > [wasm-simd][ia32] Prototype sign select > > The implementation is the same as on x64. > > Bug: v8:10983 > Change-Id: I2654ce4a627ca5cc6c759051ab9034c528d9f25a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567194 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71606} TBR=bbudge@chromium.org,zhin@chromium.org Change-Id: I6408268945e41ef7acf5938ac989bab9824df185 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10983 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573996Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71607}
-
Zhi An Ng authored
The implementation is the same as on x64. Bug: v8:10983 Change-Id: I2654ce4a627ca5cc6c759051ab9034c528d9f25a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567194Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71606}
-
Zhi An Ng authored
Some extract lane and replace lane opcodes overlap with the ones used for load lane, with a different addressing mode. Merge those cases together and delete unused opcodes. Drive by clean-up to rename kF32x4ReplaceLane to kIA32Insertps to follow the naming convetion (kIA32 prefix) and also make it more general if in the future we use insertps for other purposes. Bug: v8:10975 Change-Id: Id143670f63e69cb45cf7c1ce358297a928383035 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568924Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71605}
-
- 03 Dec, 2020 1 commit
-
-
Zhi An Ng authored
These instructions have the same implementation in code-generator. Bug: v8:11217 Change-Id: I06fa7eaf6360aa8f142ee1d0b36832be3a518b7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568920Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71581}
-
- 02 Dec, 2020 1 commit
-
-
Zhi An Ng authored
Bug: v8:11215 Change-Id: If6e9cb252176230815c7509ecf2a6e3e2269e601 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567532Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71549}
-