- 25 Jul, 2022 23 commits
-
-
Leszek Swirski authored
Too often, maglev has an issue during graph building. These are hard to debug, because failing to build a graph means that no graph can be printed. This patch adds a tracing printer that dumps out nodes as they are added to the graph -- it doesn't have the beautiful unicode arrows, but at least it's something. Bug: v8:7700 Change-Id: Id6673a9ee2436eac365d6d449dd2fa49bdc354d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780527Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81926}
-
Jakob Kummerow authored
a.k.a. "option 1a". Reflects the resolution of this discussion: https://github.com/WebAssembly/function-references/issues/44 Bug: v8:7748 Change-Id: I6b53c353a1ace2aaf5b852addead51b9f76c9d64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782674Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81925}
-
Samuel Groß authored
Bug: v8:10391 Change-Id: I6075a8fe3c201f9221149e0c54edf4fb191088da Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3757342 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81924}
-
Clemens Backes authored
The new method is not implemented in Chrome or Node, and the issue has no activity since 2018, so let's rip out the incomplete new API. Drive-by: Sprinke a few V8_LIKELY and V8_UNLIKELY. R=mlippautz@chromium.org Bug: chromium:634547 Change-Id: I0dabad520d459277d7196fa69c1bbceaf4d53596 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780528Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81923}
-
jameslahm authored
... including LogMapsCodeTest.LogMapsDetailsCode, LogMapsTest.LogMapsDetailsStartup and LogMapsTest.LogMapsDetailsContexts. Bug: v8:12997 Change-Id: I9dc315d7361efb8c58bf7ad3be8e324cdd456184 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784617Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#81922}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Ibd40e7bf3f0681f358bb2ed0785fce9a50f8b617 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784599Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#81921}
-
Clemens Backes authored
Sometimes the second Wasm instantiation fails because we run out of memory. This raises a RangeError, which is not recognized by ClusterFuzz as OOM. Thus turn it into a proper OOM crash. R=ahaas@chromium.org Bug: chromium:1347024 Change-Id: I39f7789cc85a9ba9b4217764fbbcef15c6c6ed76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784602Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81920}
-
Omer Katz authored
Whenever PagedNewSpace allocates a page, the page is added to the free list. Preallocating pages on space initialization means the pages are added to the free list before the map for free space is initialized. Then, when allocating from the free list, a DCHECK fails (free-list.cc:508). This CL delays page preallocation until `EnsureCurrentCapacity` is called. When using PagedNewSpace, we will call this method from `Heap::CreateHeapObjects` after the maps are allocated and before any allocations in new space are attempted. Bug: v8:12612 Change-Id: I33f825ddd831640b12e4c0f7b849262a335df51e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780541Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Bug: v8:13101 Change-Id: I5d144939b420957eab58ead64836b561bd541a00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784601 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#81918}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Ib3325ff8f764f7a3bd6c064a5ad301c384503d99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784594 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81917}
-
Michael Lippautz authored
Sentinel pointers would be treated as live by the GC (through `HandleWeak()` but would be treated as dead when checked explicitly through the `LivenessBroker` in e.g. custom callbacks. Treat sentinel pointers as live consistently across all callsites and weak types. Change-Id: I9a4c096ddac1a111df808f3683325b55e7597eea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782800 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#81916}
-
Andreas Haas authored
With this CL the time is measured from when the streaming decoder is finished until the time when the compilation of all functions of the streamed module is finished. If the streaming decoder finishes second, the time gets recorded negatively. This timer should allow us eventually to check whether the assumption that Liftoff compilation is faster than downloading module bytes is correct. R=clemensb@chromium.org Bug: v8:12924 Change-Id: I2b7fbdef891d1eda77706ffbd20cf223b91b901c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3678839 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81915}
-
Anton Bikineev authored
- The data race on atomic memcpying/memsetting was fixed; - All the known alignment issues in Blink were fixed; - Several perf optimizations were applied. Original change's description: > cppgc: Enable pointer compression by default on Desktop > > The CL enables pointer compression in Oilpan. > > For sherrifs: the CL may cause some slight perf regressions (likely > blink_perf.*), due to slightly higher cost of compression and > decomrpession. > > Speedometer2 is not expected to regress, as was checked locally. Such a > slight performance degradation is compensated by memory savings that are > expected to be around 10-20% of Oilpan committed size (~2.5-5% of Renderer > PMF). Bug: chromium:1325007 Change-Id: I5fa9a06cb1fa5141f4e2b22e710007e2404a176b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3762567 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Samuel Groß authored
Due to top-byte ignore (TBI) in Arm64, only bits [48, 56) can be used for type tags as otherwise type-check failures may go unnoticed if they only leave bits in the top byte set. This CL therefore switches the external pointer tagging scheme to use 8-bit tags. Bug: v8:10391 Change-Id: Ia1f379ebc1bbda4117785d2dc119bc8dfa358711 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776688 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
The return value of StringBuilder::cursor() isn't safe to store across print operations, because it will become stale if the StringBuilder needs to grow its buffer. The solution is to store the length() instead, and recompute the raw pointer from the updated start() when needed. Change-Id: Id453e39743644a5df9f7cbb8b1acaea7f5890453 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782671 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL fixes two lock-order-inversion warning in the DefaultPlatform. The problem was that during shutdown locks get taken in the oposite order than during initialization. The first two conflicting locks were the WasmEngine lock and the lock of the DefaultTaskRunner. During WasmEngine initialization, when the WasmEngine lock is hold, a foreground task is scheduled, which requires the TaskRunner lock. During shutdown, the task queue of the TaskRunner gets drained while holding the TaskRunner lock. Thereby the destructors of the tasks get executed, and the LogCode task of the WasmEngine thereby acquires the WasmEngine lock. The second conflict happens between the WasmEngine lock and the DefaultPlatform lock, where the DefaultPlatform lock is taken during WasmEngine initialization when the ForegroundTaskrunner is acquired. During Shutdown, the DefaultPlatform lock was hold while the task queue was drained, as described above. Bug: chromium:1346250 Change-Id: Ib67d0c6cad1372e7c592f40bbe68b0ae31b2976b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782796 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Backes authored
All embedders override this method now, so it can be abstract. R=mlippautz@chromium.org Bug: v8:12425 Change-Id: I4db5d74341c9519222592a88d247bc2aa2be03a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780538Reviewed-by:
-
Clemens Backes authored
This allows to run a test repeatedly (in the same process) which always sets the flag(s) to the same value. This also applies to fuzzers. The {FlagValue<T>::operator=} is the central bottleneck which is now used for any flag value updates, either via the FLAG_foo globals, or via the internal or public API. R=cbruni@chromium.org Bug: v8:12887, chromium:1346284 Change-Id: I46662322e1420ee12314544302ad9700523dcf90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780525 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#81909}
-
Matthias Liedtke authored
This is a follow up to Iadf73c294904ec20cefe1053a2969aa1dbb91a39. Bug: v8:7748 Change-Id: I59390b8c82c4ebed58f2d3130cd9b1578bffdd4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780535 Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@google.com> Cr-Commit-Position: refs/heads/main@{#81908}
-
Michael Lippautz authored
Manually roll forward `google_benchmark` and rely on the shipped export header file. Adjust the build rules to always imply a static build though as that's how the library is used in v8. Bug: chromium:1346538 Change-Id: Ia94ad976f533a1c1d8099f1bc931b491d6fb17dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782798Reviewed-by:
-
Simon Zünd authored
This CL changes `scheduleTask` to use a cached ObjectTemplate to create the JS task objects. Console creates the template lazily upon first use. A local micro benchmark that creates 100k task objects shows a speedup of roughly 4x. R=jarin@chromium.org Bug: chromium:1334585 Change-Id: Ice037ad32836fe428b1bcbee15738cb17877a3dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779496 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/main@{#81906}
-
Simon Zünd authored
Minor cleanup CL for better readability. R=kimanh@chromium.org Bug: chromium:1334585 Change-Id: I430a33e2b7173e146ff9927e70b06a04770cd956 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779495Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#81905}
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/ae6c9d1..476d5ae R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I426c18c1fe0c61b19d9ad39144c6243016c0cec1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3783912 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81904}
-
- 24 Jul, 2022 2 commits
-
-
Omer Katz authored
A couple of allocation were still going to new space. Since objects allocated during isolate initialization are long living anyway, we should pretenure them. This also untangles preallocating pages in the paged new space. Bug: v8:12612 Change-Id: Ib63ff4445930afa5969464e6adaef85b314e95ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782802Reviewed-by:
-
Clemens Backes authored
Avoid most of the {is_inline()} checks by having a {data_begin_} pointer which either points at the inline storage or at the zone-allocated memory. This replaces a dynamic branch by a memory indirection, which is beneficial for big (non-inline) BitVectors. For small BitVectors we will have to see what the bots say; the hypothesis is that a memory load is still faster than a dynamic branch. Apart from better performance, this change allows for simpler code in many places, including the iterator implementation. R=jkummerow@chromium.org Bug: v8:13063 Change-Id: I1e28279d1a438598e0b8403a6a4078c2cd2a4c48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776685Reviewed-by:
-
- 23 Jul, 2022 3 commits
-
-
Clemens Backes authored
Provide a V8_ASSUME implementation for GCC which has the same effect as using __builtin_assume on clang. R=cbruni@chromium.org Change-Id: Ia6ab56995d9ecac1015eab8bacc7e3115da7004f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779691Reviewed-by:
-
Clemens Backes authored
Instead of cmov + unconditional store, do a conditional store. At least on Intel CPUs, this turns out to be significantly faster. R=jkummerow@chromium.org Bug: v8:13063 Change-Id: Ib5a89b9b9dbc88ca408a4bafc152d91407bf8d1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776675Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/3e55cfb..ae6c9d1 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/b954e3e..039323b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b0098bb..192679c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0ba2fd4..2cd4823 Rolling v8/third_party/fuchsia-sdk/sdk: version:9.20220720.2.1..version:9.20220722.3.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Idf52c81a0ddfbaea9920889c0ee39b181a980a29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3781739 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81899}
-
- 22 Jul, 2022 12 commits
-
-
ishell@chromium.org authored
Drive-by fixes: * categorize CodeDataContainer objects as kCode, * when external code space is enabled report CodeDataContainers as (%s builtin handle), * replace a sequence of obj.IsXXX() with a respective sequence of InstanceTypeChecker::IsXXX(). Bug: v8:11880 Change-Id: Ib50b168eb28af5f8388be7f9b9f4feba2ee784af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780534 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
r8, r12, and r15 should be usable as general allocatable registers. This is a performance experiment. If it causes more regressions than improvements, we can simply revert it. Change-Id: I757c06e9d0fc760e900b228b92671d6710bf4560 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782672 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Paolo Severini authored
Make sure AddAllSequenceSlowCallback works on arrays where some elements cannot be accessed. Bug: chromium:1338877 Change-Id: Icdf61a305fb208a91832d03ebc47201d8941e41a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3778410 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
This reverts commit edbe3373. Reason for revert: Breaking presubmit https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8807931292038216513/+/u/Presubmit/stdout /b/s/w/ir/cache/builder/v8/test/mjsunit/mjsunit.status: Error: missing file for mjsunit test wasm/stack-switching-export Original change's description: > [heap] Filter new test for single generation mode > > R=dinfuehr@chromium.org > > Bug: v8:11644, v8:12191 > Change-Id: I60c6426851bb46510ec0b0df132e460bed6d6e80 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782801 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81893} Bug: v8:11644, v8:12191 Change-Id: I52caf104ed3f13bb03dbeb009199c67e34b63732 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782199 Auto-Submit: Shu-yu Guo <syg@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81895}
-
ishell@chromium.org authored
Bug: v8:11880 Change-Id: I62e3d309721f3de50c15c0a6e39b82831dd46337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780532Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81894}
-
Thibaud Michaud authored
R=dinfuehr@chromium.org Bug: v8:11644, v8:12191 Change-Id: I60c6426851bb46510ec0b0df132e460bed6d6e80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782801 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
This change removes: - struct.new_with_rtt - struct.new_default_with_rtt - array.new_fixed - array.new_data - array.new_with_rtt - array.new_default_with_rtt - ref.test - ref.cast - br_on_cast - br_on_cast_fail - rtt.canon Bug: v8:7748 Change-Id: Iadf73c294904ec20cefe1053a2969aa1dbb91a39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779689 Auto-Submit: Matthias Liedtke <mliedtke@google.com> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 8cb02753. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/20736/overview Original change's description: > [wasm] Materialize suspender in JS-to-wasm wrapper > > Instead of creating the Suspender object in JS and passing it to the > stack-switching js-to-wasm wrapper, the wrapper now automatically > creates the Suspender object and forwards it as an extra parameter to > the wasm function. See: > https://github.com/WebAssembly/js-promise-integration/pull/1/files > > R=ahaas@chromium.org > > Bug: v8:12191 > Change-Id: I2badee823f4223a293632f93e7e59f24c49d0820 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779688 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81890} Bug: v8:12191 Change-Id: Id22ed357e3a59bd1569687eadbc9b007d3da995c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780816 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81891}
-
Thibaud Michaud authored
Instead of creating the Suspender object in JS and passing it to the stack-switching js-to-wasm wrapper, the wrapper now automatically creates the Suspender object and forwards it as an extra parameter to the wasm function. See: https://github.com/WebAssembly/js-promise-integration/pull/1/files R=ahaas@chromium.org Bug: v8:12191 Change-Id: I2badee823f4223a293632f93e7e59f24c49d0820 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779688 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 0e554376. Reason for revert: Breaks a number of windows builds Original change's description: > Update google_benchmark > > Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/d4bc509..ef7f75f > > simplified code (#1439) (maochongxin) > https://chromium.googlesource.com/external/github.com/google/benchmark/+/ef7f75f > > use target_compile_definitions (#1440) (Dominic Hamon) > https://chromium.googlesource.com/external/github.com/google/benchmark/+/e27c930 > > Stop generating the export header and just check it in (#1435) (Dominic Hamon) > https://chromium.googlesource.com/external/github.com/google/benchmark/+/7b3ac07 > > Also fix the SOVERSION for benchmark_main (Dominic Hamon) > https://chromium.googlesource.com/external/github.com/google/benchmark/+/d845b7b > > R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org > > Change-Id: Ifbb9be7752856e3f0ab042194108a96a5b6cc083 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782483 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81884} Change-Id: I22eb5e12653f2c8965a87692695cbb06a44da14a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782799 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#81889}
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: I067e9d6a56dd58dbd0f45607f62b5ef36c69ff6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776690Reviewed-by:
-
Jakob Kummerow authored
The DevTools frontend doesn't want the Wasm module's understanding of function body offsets (i.e. including locals), but the ranges of offsets where breakpoints can be set (i.e. only where instructions are). This patch adjusts the reported offsets accordingly. A consequence is that we have to report full (start,end) pairs for each function, instead of being able to dedupe end1==start2 etc. Bug: v8:12917 Change-Id: I0c7d2d96435cdac2c4553647b7bcc8783bc1798b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780526 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/main@{#81887}
-
