• Andreas Haas's avatar
    [d8] Avoid lock-order-inversion warning in the DefaultPlatform · 40a5328b
    Andreas Haas authored
    This CL fixes two lock-order-inversion warning in the DefaultPlatform.
    The problem was that during shutdown locks get taken in the oposite
    order than during initialization.
    
    The first two conflicting locks were the WasmEngine lock and the
    lock of the DefaultTaskRunner. During WasmEngine initialization, when
    the WasmEngine lock is hold, a foreground task is scheduled, which
    requires the TaskRunner lock. During shutdown, the task queue of the
    TaskRunner gets drained while holding the TaskRunner lock. Thereby
    the destructors of the tasks get executed, and the LogCode task of
    the WasmEngine thereby acquires the WasmEngine lock.
    
    The second conflict happens between the WasmEngine lock and the
    DefaultPlatform lock, where the DefaultPlatform lock is taken during
    WasmEngine initialization when the ForegroundTaskrunner is acquired.
    During Shutdown, the DefaultPlatform lock was hold while the task
    queue was drained, as described above.
    
    Bug: chromium:1346250
    Change-Id: Ib67d0c6cad1372e7c592f40bbe68b0ae31b2976b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782796
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81911}
    40a5328b
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...