- 06 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0cc2895..911a0c5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8221306..5715e98 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id7e56f5519adb8897cc9e3c0ec597b977a7d7a80 Reviewed-on: https://chromium-review.googlesource.com/1127485Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54275}
-
- 05 Jul, 2018 39 commits
-
-
Alexey Kozyatinskiy authored
- rewritten couple tests, - migrated JSMessageObject to real Script instead of wrapper, - removed wrapper. R=yangguo@chromium.org TBR=ulan@chromium.org Bug: v8:5530 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia95492344c7b5978a940e2ab007b389384537148 Reviewed-on: https://chromium-review.googlesource.com/1112851Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54274}
-
Alexey Kozyatinskiy authored
After liveedit removed - we do not need this context any more. R=yangguo@chromium.org TBR=clemensh@chromium.org Bug: v8:5530 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idb43d016d51b8048f6cd2ca590fd7510abcacb49 Reviewed-on: https://chromium-review.googlesource.com/1106802 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Creddy authored
* Rename BoilerplateDescription to ObjectBoilerplateDescription * Add literal_type flag to ObjectBoilerplateDescription, which is stored as zeroth element of Fixed array * Create ArrayBoilerplateDescription with elements_kind and constant_elements field * Replace CompileTimeValue and ConstantElementPair with ArrayBoilerplateDescription * Kill ConstantElementPair and CompileTimeValue Change-Id: Icb42dcfd575a27e2b64ffd5e2e61f9d703d5e986 Bug: v8:7787, chromium:818642 Reviewed-on: https://chromium-review.googlesource.com/1122411 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54272}
-
Théotime Grohens authored
This CL adds a Reduction for the DataViewGetInt16 and -Uint16 builtins, and the corresponding handling in LoadDataViewElement node in the effect control linearizer. It also adds tests for the new getters. Change-Id: I5101755e47657c25f10be1417f105e3ae72a3c39 Reviewed-on: https://chromium-review.googlesource.com/1126919 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54271}
-
Yang Guo authored
R=cbruni@chromium.org Change-Id: Iaac9794f2608db21c7b6d6a387085de04f0434d6 Reviewed-on: https://chromium-review.googlesource.com/1127165Reviewed-by:
-
Yang Guo authored
This is a temporary measure to get bots back in order. Bug: chromium:860430 TBR=machenbach@chromium.org Change-Id: I3275150f4bc5dfe8ab90984e15f8a1a469d70caf Reviewed-on: https://chromium-review.googlesource.com/1127166Reviewed-by:
-
Mike Stanton authored
Change-Id: I061df17a2bb713b00c09104c1b7fcfad218b8ad6 Reviewed-on: https://chromium-review.googlesource.com/1126929Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I4fb79b1b694c89f348dba71dae0ad68e82b614dc Reviewed-on: https://chromium-review.googlesource.com/1127051 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54267}
-
Clemens Hammacher authored
This avoids the need for the finisher task (running on the foreground thread) for Liftoff code. This CL just makes the simple change to call {AddCode} from the background thread. More cleanup will follow in separate CLs. R=mstarzinger@chromium.org Bug: v8:6600, v8:7921 Change-Id: I99ef29377efee5be36ba203aa7ed71e2471d86f3 Reviewed-on: https://chromium-review.googlesource.com/1126930 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sathya Gunasekaran authored
This unblocks new feature work that require this operation from C++, whilst the porting to C++ is underway. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Icb7f05bbea42ecfa1abc3cefb6d1bf8542ed921b Reviewed-on: https://chromium-review.googlesource.com/1127082 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Maya Lekova authored
Replace CHECK with throwing exception when no or invalid arguments are passed to async_hooks.createHook. Bug: chromium:860481 Change-Id: Ie5a915ee66f2a0ff79c4df5aef94ff883866ecda Reviewed-on: https://chromium-review.googlesource.com/1127054Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#54264}
-
Leszek Swirski authored
Move some of PreParsedScopeData's santity checks, such as the magic value separating skippable function data from scope data, to be debug only, to save memory. Start position of inner skippable functions is still kept, because it's too good at catching bugs, but we may want to remove it in the future as well. Bug: chromium:818642 Change-Id: If86ff1b9845e8dd3b015b4e554d0033328b145bf Reviewed-on: https://chromium-review.googlesource.com/1127046 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Toon Verwaest authored
The embedder should ultimately be responsible for handling this since they anyway give us a copy of the data. They can easily make sure that the chunks we get do not have lonely bytes. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie862107bbbdd00c4d904fbb457a206c2fd52e5d0 Reviewed-on: https://chromium-review.googlesource.com/1127044Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This introduces a second factory method for allocating new module objects that are based on existing native modules which are potentially shared between multiple Isolates. R=clemensh@chromium.org TEST=cctest/test-wasm-shared-engine BUG=v8:7424 Change-Id: I8c74d821542d443a8ad2352cb77b84b445e21acb Reviewed-on: https://chromium-review.googlesource.com/1126931 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Georg Neis authored
This reverts commit 4b9b9b68. Reason for revert: Regresses Octane. Original change's description: > Reland "[turbofan] Rewrite CompilationDependencies" > > This is a reland of 52a10e50, after > eliminating an invalid assumption about maps. > > TBR=jarin@chromium.org > TBR=mstarzinger@chromium.org > > Original change's description: > > [turbofan] Rewrite CompilationDependencies > > > > Instead of installing code dependencies during graph reduction, > > install them after code generation. > > > > Bug: v8:7902, v8:7790 > > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a > > Reviewed-on: https://chromium-review.googlesource.com/1119913 > > Commit-Queue: Georg Neis <neis@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54170} > > Bug: v8:7902, v8:7790 > Change-Id: I9cbaf98980379b9b17464af5952ec0c47e1cdc6f > Reviewed-on: https://chromium-review.googlesource.com/1126999 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54254} TBR=mstarzinger@chromium.org,jarin@chromium.org,neis@chromium.org Change-Id: Iece193046c48ee96ab7952d2b3bd7ad05f39b190 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7902, v8:7790 Reviewed-on: https://chromium-review.googlesource.com/1127119Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54260}
-
Sathya Gunasekaran authored
Creates two different functions specialized for string and boolean types. Gets rid of several allocations and keeps the C++ <-> JS type conversions to a minimum. Improves the API as we don't have to create the fallback or V8 Strings unnecessarily. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I788e43e6ef23f3e9144ff719f01d6334fe6cb9ce Reviewed-on: https://chromium-review.googlesource.com/1126750 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Additionally now we only scan over flat heap strings. Change-Id: Ia73c538a3c7923ec66089e16efa529ef3cea2d06 Reviewed-on: https://chromium-review.googlesource.com/1126938 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
This is a reland of 8e39af62 Original change's description: > [arm64] Use root register for addressing external references. > > This optimization is already done on x64 (7500e507). > > Bug: v8:7844 > Change-Id: Iccc3bb55aa79ef1d4423576c79d9ce6f829f2828 > Reviewed-on: https://chromium-review.googlesource.com/1120343 > Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54162} Bug: v8:7844 Change-Id: I2eab2d753fd8e374bf7c912a107c93edc58ef4c7 Reviewed-on: https://chromium-review.googlesource.com/1126259Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#54257}
-
jgruber authored
This adds the option to output statistics about the embedded blob. On x64 release, the output is currently: Total size: 724064 Metadata size: 6832 Instruction size: 703427 Padding: 13805 Embedded builtin count: 852 Instruction size (50th percentile): 222 Instruction size (75th percentile): 749 Instruction size (90th percentile): 1871 Instruction size (99th percentile): 9171 Total size is added to our Memory benchmark. Drive-by: Fix startup / context regexps for Memory benchmark. Bug: v8:6666, v8:7898 Change-Id: I90d4458877939d3b48593bd9dd3a33971fe78c44 Reviewed-on: https://chromium-review.googlesource.com/1126104 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Stephan Herhut authored
When assigning a register to a value that is used as a function argument, we use a hint to suggest the corresponding register. However, if the argument is also used after the call, the register will not be free for the entire live range of the value. Hence we need to split the live range. To minimize the number of splits, we aim to choose a register with maxium availability. This heuristic was implemented based on lifetime positions with sub-instruction precision. In such a model, argument registers typically have a shorter available time, as they need to hold a value before a call, whereas all other registers are free until right after the call, where they have been overwritten by the called function. Hence, we typically chose a non-argument register, ignoring the hint and creating an extra move. This change moves the heuristic to instruction granularity, which gives argument and other registers the same free time. We also now prefer hinted registers if they have the same free time. Change-Id: Ia8dd73b6c086d28859a836c42ea9ff8afce4c371 Reviewed-on: https://chromium-review.googlesource.com/1124852Reviewed-by:
-
Georg Neis authored
This is a reland of 52a10e50, after eliminating an invalid assumption about maps. TBR=jarin@chromium.org TBR=mstarzinger@chromium.org Original change's description: > [turbofan] Rewrite CompilationDependencies > > Instead of installing code dependencies during graph reduction, > install them after code generation. > > Bug: v8:7902, v8:7790 > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a > Reviewed-on: https://chromium-review.googlesource.com/1119913 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54170} Bug: v8:7902, v8:7790 Change-Id: I9cbaf98980379b9b17464af5952ec0c47e1cdc6f Reviewed-on: https://chromium-review.googlesource.com/1126999Reviewed-by:
-
Ross McIlroy authored
Previously we were getting the code object from the stack, so printed incorrect position details for interpreted frames. BUG=v8:7916 Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9 Reviewed-on: https://chromium-review.googlesource.com/1126313Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54253}
-
Igor Sheludko authored
Bug: v8:7754 Change-Id: Id7701375897f6f3cfac7327404751b43cfdb221c Reviewed-on: https://chromium-review.googlesource.com/1118888Reviewed-by:
-
Théotime Grohens authored
This CL is a manual revert of 3e78711c. Adding the fast path did not result in any performance improvement, and actually decreased DataView performance in the performance test. Change-Id: I149670088b07c31e44d93ed65505254ec0caf8ba Reviewed-on: https://chromium-review.googlesource.com/1126925Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#54251}
-
Sathya Gunasekaran authored
Change-Id: I4c86e7ff110b4457a4d52b66462b31b62b42473f Reviewed-on: https://chromium-review.googlesource.com/1126891Reviewed-by:
-
Michael Starzinger authored
R=sigurds@chromium.org Change-Id: I1af61feff81f21792d66af7d9b12fc59ea94aacd No-Try: true No-Tree-Checks: true Change-Id: I1af61feff81f21792d66af7d9b12fc59ea94aacd Reviewed-on: https://chromium-review.googlesource.com/1126933 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This is a first set of test cases for sharing an {WasmEngine} and the contained {WasmCode} between multiple Isolates. Currently this can only be done using internal API methods on the Isolate, an external API that is usable by embedders does not exist yet. R=clemensh@chromium.org TEST=cctest/test-wasm-shared-engine BUG=v8:7424 Change-Id: I35541a76b5aceec4519e3a46e6a9ef4d01cad22b Reviewed-on: https://chromium-review.googlesource.com/1126382Reviewed-by: -
Marja Hölttä authored
MaybeObjectHandle already has an API for making a weak pointer. BUG=v8:7308 Change-Id: I9f8390e0dffec850a24391e7f50a455b86b217f5 Reviewed-on: https://chromium-review.googlesource.com/1125922Reviewed-by:
-
Andreas Haas authored
In the WebAssembly fuzzers we detect infinite loops with the interpreter: if the interpreter does not finish after a finite number of steps, we do not execute the compiled code. However, we cannot redirect the start function to the interpreter in the fuzzer, and therefore we cannot detect infinite loops in the start function. With this CL we avoid the problem completely by not instantiating a module in the fuzzer which has a start function. Note that the module still gets compiled. R=clemensh@chromium.org Bug: chromium:858914 Change-Id: Icbbe9a003544918d5267cdd1d9405b21bb681133 Reviewed-on: https://chromium-review.googlesource.com/1126766 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Replace Is<oddball>(GetIsolate()) calls with a no-parameter version that goes through ReadOnlyRoots, and add a version that takes a ReadOnlyRoots if that is available in the parent (but Isolate isn't). Also opportunistically clean up a few places where ReadOnlyRoots are available but we still pass in an Isolate parameter. TBR=yangguo@chromium.org Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Icc0b8a7d8f9c6b84c0ec8fe771fcfb75c9dc5468 Reviewed-on: https://chromium-review.googlesource.com/1126302Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54245}
-
jgruber authored
Mips and mips64 generate non-position-independent trampolines once code exceeds 128K in size. This is a quick fix for failing bots, disabling the ten largest builtins. TBR=machenbach@chromium.org Bug: v8:7882, v8:7920 Change-Id: I027ff8452f927f890773210fb99853adf4934bbc Reviewed-on: https://chromium-review.googlesource.com/1126923 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
This is a port of e5630ea9: "[builtins,x64] pc-relative builtin-to-builtin calls". Bug: v8:6666 Change-Id: Id53bf45c6a4fedb1c972ced72984b6673808ee96 Reviewed-on: https://chromium-review.googlesource.com/1126249Reviewed-by:
-
Georgia Kouveli authored
Change-Id: Id6163e68877554d67ae447e6607fb6a5944ac8c9 Reviewed-on: https://chromium-review.googlesource.com/1120166Reviewed-by:
-
Hannes Payer authored
This is a reland of 2265a852 Original change's description: > [snapshot] Reduce serialization chunk size to 4K. > > This change may slow down deserialization of the snapshot but may result in less fragmentation. > > Bug: v8:7887 > Change-Id: Id8bb9f1a561b08b7ae0f10b80aa77bc00eb23172 > Reviewed-on: https://chromium-review.googlesource.com/1125722 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54198} TBR=hpayer@chromium.org Bug: v8:7887 Change-Id: If03f241a80341cb053190c5bc0451fe9a032e1a8 Reviewed-on: https://chromium-review.googlesource.com/1126899Reviewed-by:
-
Dan Elphick authored
Now that ReadOnlyRoots is used everywhere to access the read-only roots, this makes the Heap accessors for such roots private. It also adds tests that the roots reachable from ReadOnlyRoots are all in RO_SPACE as well as tests that the roots still publicly accessible from Heap are not in RO_SPACE. There's a white list in the file for the few roots where the root pointer itself can change. (For instance materialized_objects points to empty_fixed_array to start with before before later pointing to a mutable array). Also fixes up new use of heap->empty_fixed_array() in elements.cc added since I cleaned it up. Bug: v8:7786 Change-Id: I9ac7985c9f85910b5b22d2f9f559dfd04d43ed44 Reviewed-on: https://chromium-review.googlesource.com/1126252Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54240}
-
Clemens Hammacher authored
We can actually prepare everything in the background, all that remains to do in the finisher task (on the main thread) is actually adding the code to the {NativeModule}. As a next step, even that should happen in the background. R=mstarzinger@chromium.org Bug: v8:6600 Change-Id: I570f99a9aa7dc7e324046da36cca9b4297f1bc5e Reviewed-on: https://chromium-review.googlesource.com/1126391 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Andreas Haas authored
The stack of the wasm interpreter was stored in a zone. However, when the stack grows, the previous memory of the stack cannot be reused. With this CL we allocate the stack on the C++ heap to remove this memory leak. R=clemensh@chromium.org Bug: chromium:856594 Change-Id: Idce22c5c1732f7097fc4281c73174892c95f49e2 Reviewed-on: https://chromium-review.googlesource.com/1126301 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Maya Lekova authored
Fixes V8 correctness failure when there's a proxy in the global object prototype chain and unsuccessful attempt is made to access a property. Bug: chromium:849024 Change-Id: I829e1a6c038982b7c7a77f8bdefb61facb4614f0 Reviewed-on: https://chromium-review.googlesource.com/1124446 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
The code target vector is used by backends whenever initial code creation uses immediates that cannot hold a code pointer: An index into the vector is used instead, and the vector contains the corresponding code object. This CL makes the code target vector available on all platforms. Bug: v8:6666 Change-Id: I2026acd6a77a3465fe2285b84d47866c3b794855 Reviewed-on: https://chromium-review.googlesource.com/1118885 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
