• Dan Elphick's avatar
    [explicit isolates] Make read-only root Heap accessors private · 59af0c3e
    Dan Elphick authored
    Now that ReadOnlyRoots is used everywhere to access the read-only roots,
    this makes the Heap accessors for such roots private.
    
    It also adds tests that the roots reachable from ReadOnlyRoots are all
    in RO_SPACE as well as tests that the roots still publicly accessible
    from Heap are not in RO_SPACE. There's a white list in the file for
    the few roots where the root pointer itself can change. (For instance
    materialized_objects points to empty_fixed_array to start with before
    before later pointing to a mutable array).
    
    Also fixes up new use of heap->empty_fixed_array() in elements.cc added
    since I cleaned it up.
    
    Bug: v8:7786
    Change-Id: I9ac7985c9f85910b5b22d2f9f559dfd04d43ed44
    Reviewed-on: https://chromium-review.googlesource.com/1126252Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54240}
    59af0c3e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...