Commit 2a3cfb5a authored by jgruber's avatar jgruber Committed by Commit Bot

[mips,mips64] Extend IsIsolateIndependent blacklist

Mips and mips64 generate non-position-independent trampolines once code
exceeds 128K in size. This is a quick fix for failing bots, disabling
the ten largest builtins.

TBR=machenbach@chromium.org

Bug: v8:7882, v8:7920
Change-Id: I027ff8452f927f890773210fb99853adf4934bbc
Reviewed-on: https://chromium-review.googlesource.com/1126923
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54244}
parent 5b3b2be3
......@@ -317,11 +317,20 @@ bool Builtins::IsIsolateIndependent(int index) {
case kInterpreterEntryTrampoline:
return false;
#if V8_TARGET_ARCH_MIPS64 || V8_TARGET_ARCH_MIPS
// TODO(7882): The size of ArraySpliceTorque on MIP64 and MIPS32 is greater
// TODO(7882): The size of these builtins on MIP64 and MIPS32 is greater
// than 128KB, and this triggers generation of MIPS specific trampolines.
// Trampoline code is not PIC and therefore the builtin is not isolate
// independent.
case kArraySpliceTorque:
case kKeyedLoadIC_Megamorphic:
case kKeyedStoreIC_Megamorphic:
case kObjectAssign:
case kObjectGetOwnPropertyDescriptor:
case kRegExpMatchFast:
case kRegExpReplace:
case kRegExpSplit:
case kRegExpStringIteratorPrototypeNext:
case kStoreIC_Uninitialized:
return false;
#endif
default:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment