- 28 Sep, 2020 13 commits
-
-
Santiago Aboy Solanes authored
Previously ToNumber could be called with an empty context. In a previous CL (https://crrev.com/c/v8/v8/+/2078580) we added DCHECKS to make sure that some paths were not using the empty context. Now we are doing the next step of adding a primitive to separate the cases. Small update from delphick@ to get the builtin descriptor right. Bug: v8:6949, v8:10933 Change-Id: Ie40b169f680f60a08eb26fac1fcfcef7d6169e65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428863 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#70162}
-
Almothana Athamneh authored
Bug: v8:10955 Change-Id: I630d37bce852712cd38f28f443f1bb5f3d9a50bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434331Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#70161}
-
Simon Zünd authored
The compilation cache doesn't know about REPL mode. This means that non-REPL mode compiled scripts are successfully found for their REPL mode equivalent and vice versa. This CL disables the compilation cache for REPL mode scripts. Performance is not really a concern as DevTools console inputs are usually very small. R=leszeks@chromium.org Bug: chromium:1108021 Change-Id: If396c7aa004188730762e4f6bd01dae2fc141181 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434333 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#70160}
-
Camillo Bruni authored
The tool has been outdated for a while and replaced by profview for most use-cases. The last version is still hosted under https://v8.github.io/tools/v8.4/profviz/profviz.html Bug: v8:9260, v8:10667 Change-Id: I54888640a627ee8e4d8ad2ab63bd91e04e6fb98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434335Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70159}
-
Michael Achenbach authored
This prepares moving the build directory on bots to out/build. For a smooth transition, the performance runner will dynamically check for the build in several locations. This prepares: https://crrev.com/c/2426643 NOTREECHECKS=true Bug: chromium:1132088 Change-Id: Ia12fcdedec0f4ac2bfe087e8154c0acb8771a43f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431364 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Dan Elphick authored
These tests were incorrectly declaring the number of parameters the generated function would take by omitting the receiver and PopAndReturnVariable was accessing the wrong parameter. Also updated a passed in parameter to not match the constant that was being returned in case that led to the test passing accidentally. Bug: v8:10933 Change-Id: Ia354e4e30b464a333039ab6bc54198acd16a4789 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434334Reviewed-by:
-
evih authored
Currently, the generic wrapper is used for i32, i64, f32 and f64 params and 0 or 1 i32, i64, f32, f64 return value. Bug: v8:10701 Change-Id: I3776de617aa4a384fdff5154ddad8ff405001a33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429266 Commit-Queue: Eva Herencsárová <evih@google.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70156}
-
Marja Hölttä authored
Incl. random handler-related cleanups. Change-Id: I0a80e515c44aaf57a1834ee8ffa9cd47a31ea7be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2398518 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#70155}
-
Dan Elphick authored
Fixes test-torque/TestBitFieldStore to read the Smi parameter passed in rather than the receiver which was always the global object. Change-Id: Ie6b343ad7ef9393c211b0e7c8e1b7c1427e0aeb4 Bug: v8:10933 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434327 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70154}
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: I2f62c74c3e435e05fd9e313af2f15925583872ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423716 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#70153}
-
Alex Kodat authored
When an Isolate in a multi-threaded environment is being debugged and a thread does a Step Over (StepNext internally) one-shot breaks are created in the code at the stack frame where the StepNext occurred. However, if the stepped-over statement had a function call and the called function (or some function that it called) unlocked the Isolate (via a C++ function call) and another thread then locked the Isolate, an ArchiveDebug would be done which would save the fact that a StepNext is active and the call frame depth of the StepNext. The one-shot breaks would then be cleared to avoid stopping the now running thread. When the original thread that did the StepNext relocks the Isolate, a RestoreDebug is done which, seeing that a StepNext was active calls PrepareDebug which assumes that the StepNext must be for the current JS frame which is usually correct, but not in this case. This results in the StepNext break actually occurring in the function that called the C++ function not in the function where the StepNext was originally done. In addition, the function where the break now happens must necessarily be deoptimized if optimized, and debug code and a source map table created if one doesn't already exists though this is largely invisible to the user. Occasionally, a crash/core dump also occurs because the stack guard is restored after the debugging environment is restored in the RestoreThread code which can prevent the compiler from being called to generate the source map table (for the incorrect function) since the stack guard is another thread's stack guard, and so might appear that the stack guard has been gone past so the compiler is not called, resulting in there being no source map table. But PrepareStep ends up calling the BreakIterator (via the DebugInfo constructor) which assumes there is a source map table so we get a crash. The fix is to have PrepareStep to skip to the frame where the StepNext was done before doing its thing. Since the only PrepareStepcaller that requires a frame other than the current frame, is RestoreDebug, a target frame parameter was added to PrepareStep that's set by RestoreDebug and defaults to -1 indicating to use the current frame for all other callers. While this made the order of the debug environment and stack guard no longer cause an obvious problem, it still felt wrong to defer restoration of the stack guard until after something as potentially complex as PrepareStep might be called, so the order of RestoreDebug and RestoreStackGuard calls were reversed. Bug: v8:10902 Change-Id: I174e254e72414c827e113aec142f1d329ebe73d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2405932 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
MemOperand's immediate offset is int32_t value, but some offsets in liftoff are uint32_t, we should load the offsets to registers. And assemble instructions like lw/sw/daddiu could't handle operand with large immediate value. So we should use macro assemble instrs like Lw/Sw/Daddu instead, unless we can make sure the operands are proper for those assemble instructions. Bug: v8:10925 Change-Id: I122d35a6857461791999b603f0150311bfc6343e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434985Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#70151}
-
Omer Katz authored
This reverts commit 2221f090. Reason for revert: fix in patchset 2 Original change's description: > Revert "cppgc: Provide jobs support through DefaultPlatform and TestPlatform" > > This reverts commit 22c0fc8f. > > Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20gcc/8712? > > Original change's description: > > cppgc: Provide jobs support through DefaultPlatform and TestPlatform > > > > This CL extends cppgc::DefaultPlatform and TestPlatform to emulate > > jobs using std::thread and v8::base::Thread respectively. > > Jobs using these platform do not yield unless the job as been > > cancelled. Additionally, the job priority is ignored. > > > > Bug: chromium:1056170 > > Change-Id: I72db1eef410d2be3d3e5ea7d4ece9e5584a451f2 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416378 > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#70139} > > TBR=mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org > > Change-Id: Ic29235e3ab78a1b515a5b14b808e116a1ccffc0f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1056170 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432087 > Reviewed-by: Francis McCabe <fgm@chromium.org> > Commit-Queue: Francis McCabe <fgm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70142} # Not skipping CQ checks because this is a reland. Bug: chromium:1056170 Change-Id: Iaa8312da759ab97f646a9fb6144462a115393b5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431666Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
- 25 Sep, 2020 20 commits
-
-
Ng Zhi An authored
64x2 nodes were already supported, we just didn't add the case for 64x2 load splat. Add that in and we pass simd_load_splat.js. Bug: v8:10507 Change-Id: If9145e1b3a4595f4707ca0fc3dcee466773c054f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432074Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70149}
-
Clemens Backes authored
Operations on locals are the most common wasm operations (especially local.get), and just computing the number of locals from the vector shows up with a few percent in the profile. Storing this number separately removes a few percent of execution time from the {DecodeLocalGet} method. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I9c12842c944e4ad2e602e05838948a33922ff438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429950Reviewed-by: -
Bill Budge authored
Bug: v8:10933 Change-Id: I4db540cf47ce5cfa25757d776a2bf988ce3ed554 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432072Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#70147}
-
Ng Zhi An authored
i8 and i16 nodes are stored in word32 nodes, when splat-ing them, we need to make sure to handle overflow values and also sign extend them correctly. This fix allows us to pass simd-splat.js. It still fails on ARM (non-simulator) due to a use of f32x4.min in the test. Bug: v8:10507 Change-Id: I1507637a7edb33a530c84c85ee8d4acb481293e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2430170Reviewed-by:
-
Almothana Athamneh authored
Add opt and noturbo inlining to these tests to ensure that they keep working. Bug: v8:10924 Change-Id: Icdb5ddffad11ea3c2eea723e339d450d8405b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426604 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70145}
-
Gus Caplan authored
This fixes the logic in the desugaring of destructuring assignments. In particular, a spread element would not check if previous `next` results had already been done, and would always call `next()` again. Change-Id: I1bd384678722e6cf51c5777fc3b0dd965360291a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2430488 Commit-Queue: Gus Caplan <snek@chromium.org> Reviewed-by:
-
Adam Klein authored
These instructions were changed from "s8x16" to "i8x16" prefixes in https://github.com/WebAssembly/simd/pull/321. This CL updates all V8 code, including arch-specific code, to match. Bug: v8:10946, v8:10933 Change-Id: I26ef9ad77571f94501d42c1d65f57380fd507f3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432068Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#70143}
-
Francis McCabe authored
This reverts commit 22c0fc8f. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20gcc/8712? Original change's description: > cppgc: Provide jobs support through DefaultPlatform and TestPlatform > > This CL extends cppgc::DefaultPlatform and TestPlatform to emulate > jobs using std::thread and v8::base::Thread respectively. > Jobs using these platform do not yield unless the job as been > cancelled. Additionally, the job priority is ignored. > > Bug: chromium:1056170 > Change-Id: I72db1eef410d2be3d3e5ea7d4ece9e5584a451f2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416378 > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70139} TBR=mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org Change-Id: Ic29235e3ab78a1b515a5b14b808e116a1ccffc0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432087Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70142}
-
Santiago Aboy Solanes authored
Bug: v8:9708, v8:6949 Change-Id: Ic219e0eb18648166a712493039f96e067ad47418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2395555Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#70141}
-
Victor Gomes authored
- InterpretedFrames are just StandardFrames with 2 extra values. - BuiltinExitFrames are ExitFrames with 4 extra expected arguments. Change-Id: I2c4e4a24185bfa0f23ff63616c8ef66780506796 Bug: v8:10933 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429948Reviewed-by:
-
Omer Katz authored
This CL extends cppgc::DefaultPlatform and TestPlatform to emulate jobs using std::thread and v8::base::Thread respectively. Jobs using these platform do not yield unless the job as been cancelled. Additionally, the job priority is ignored. Bug: chromium:1056170 Change-Id: I72db1eef410d2be3d3e5ea7d4ece9e5584a451f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416378 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Etienne Pierre-Doray authored
This reverts commit 92f815a8. Reason for revert: broke tests; see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/33395? Original change's description: > Reland "[Heap] ScavengerCollector use Jobs." > > This is a reland of 9e8c54f8 > Safe to reland as-is with fix in AcquireTaskId > https://chromium-review.googlesource.com/c/v8/v8/+/2401964 > > Additional changes are made in the reland: > -TRACE_GC is be split for background/foreground scope. > -New IndexGenerator is used for dynamic work assignement. > > Original change's description: > > [Heap] ScavengerCollector use Jobs. > > > > No yielding is necessary since the main thread Join()s. > > > > max concurrency is determined based on either > > remaining_memory_chunks_ or global pool size > > (copied_list_ + promotion_list_) > > > > Change-Id: Ie30fa86c44d3224b04df5d79569bce126ce7d96b > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354390 > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#69746} > > Change-Id: Id9d7a5bf3b2337ae4cf1e76770f4b14ebb8ca256 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2399041 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70135} TBR=ulan@chromium.org,etiennep@chromium.org Change-Id: I4823c642546b82a9a9c8955151cd8784e4b86bc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431551 Commit-Queue: Francis McCabe <fgm@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This is a reland of 64caf2b0 Original change's description: > [torque] refactor: use -tq only in filenames derived from .tq files > > This is to establish a naming rule for Torque-generated files: > - If the file is called foo/bar-tq..., then it is derived from a > file foo/bar.tq > - Otherwise it doesn't belong to a specific .tq file. > > So far, we attached -tq to all Torque-generated file names, where it > sometimes corresponded to a .tq file name and sometimes not. > It is not necessary to add -tq to file names to indicate that they are > Torque-generated, since they are already in a directory called > torque-generated, and we always refer to them as > "torque-generated/filename", so there is no confusion even though some > files now have the same name as a corresponding hand-written file, for > example factory.cc. > > TBR: hpayer@chromium.org > Bug: v8:7793 > Change-Id: Ie172babad1fc7422fd1059c48f5dafaa53e50c8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414218 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70060} Bug: v8:7793 TBR: hpayer@chromium.org jgruber@chromium.org Change-Id: I6c492bc64aee1ff167e7ef401825eca9097a7f38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431565 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Milad Fa authored
Change-Id: I92d4962354559990e346df7efae272ae1f74e528 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431467Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Etienne Pierre-doray authored
This is a reland of 9e8c54f8 Safe to reland as-is with fix in AcquireTaskId https://chromium-review.googlesource.com/c/v8/v8/+/2401964 Additional changes are made in the reland: -TRACE_GC is be split for background/foreground scope. -New IndexGenerator is used for dynamic work assignement. Original change's description: > [Heap] ScavengerCollector use Jobs. > > No yielding is necessary since the main thread Join()s. > > max concurrency is determined based on either > remaining_memory_chunks_ or global pool size > (copied_list_ + promotion_list_) > > Change-Id: Ie30fa86c44d3224b04df5d79569bce126ce7d96b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354390 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69746} Change-Id: Id9d7a5bf3b2337ae4cf1e76770f4b14ebb8ca256 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2399041Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#70135}
-
Andreas Haas authored
In atomic.wait we overwrote the register which stored the index, without checking if it was still in use or not. R=clemensb@chromium.org Bug: v8:10898 Change-Id: Iab6e1a84c71887af81d307c4ca795109ce2fdfc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428928 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Mythri A authored
CallOrConstructWithArrayLike and CallOrConstructWithSpread builtins expect only Smi in the array length field. This is true when we have fast elements kind, but for dictionary mode we can have HeapNumbers This cl fixes by moving the loading of length fields after the check on elements kind to avoid loading length fields on dictionary mode JSArrays. Change-Id: I838a260353efa25fb0357e6f03247d3075cebe3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431206 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10933 Change-Id: Ie2f1cdc1cad9e4e68ace0eedfd2456f5487b5107 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428586 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Andreas Haas authored
When stack slots are spilled after the register moves, some registers may get overwritten, e.g. by constants. R=clemensb@chromium.org Change-Id: Ie94aff0fd63cd9c271b90df34895818594cee3b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429032Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:10942 Change-Id: Icbb1d8e054ee924a77f1fbeb9e48cde604ef69b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422001Reviewed-by:
-
- 24 Sep, 2020 7 commits
-
-
Bill Budge authored
- Adds a --harmony-atomics feature to gate Atomics. This allows us to independently add SharedArrayBuffer and Atomics on the global object of Contexts, which is necessary for migration to a COOP+COEP site isolation requirement. Bug: chromium:923807 Change-Id: If80c12eb86dc0251a5e5fad62a6dd5ced3380b5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2340322 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70129}
-
Ng Zhi An authored
f32x4->16x8, 64x2->8x16, and 16x8->8x16. This allows us to pass more spec tests. Bug: v8:10507 Change-Id: I1810ce2d17f93529b2e69cf5c767cb7b480b4b49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429807Reviewed-by:
-
Milad Fa authored
Using the proper `add` operation assures the NAN value is properly propagated to the result register. Change-Id: Icb86193f85534604f2a4a583d177a6f319ca38c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429804Reviewed-by:
-
Dominik Inführ authored
PagedSpace::RefillFreeList() needs to invoke wasted_memory() while holding the lock. Otherwise this races with PagedSpace::FreeLinearAllocationArea() which uses add_wasted_memory() and already holds the lock. Bug: v8:10315 Change-Id: I3a57191529cdd81d75833ec334a57f84a9a59194 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428930Reviewed-by:
-
Andreas Haas authored
In atomic.notify we overwrote the register which stored the index, without checking if it was still in use or not. R=clemensb@chromium.org Bug: v8:10898 Change-Id: I59ed7a2c1f1342ff4252e3c4d33822111caee82c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426616Reviewed-by:
-
evih authored
When loading from the exported function data without pointer compression, wrong load was used before. Bug: v8:10701, chromium:1130385 Change-Id: If66913bcd5284eeb6fb7b795357f1512682a062f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426383 Commit-Queue: Eva Herencsárová <evih@google.com> Reviewed-by:
-
Junliang Yan authored
On ppc64 and s390x, Liftoff is not implemented yet, so if a Liftoff compilation unit finishes after all top-tier units (hence after the "top tier finished" callback), it will still increase the turbofan counter. R=clemensb@chromium.org, ecmziegler@chromium.org Bug: chromium:1092417 Change-Id: I0b99061f26851288f1abb8fcc3a30ca92a55164e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429564Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
