Commit 8ca2a7c8 authored by Ng Zhi An's avatar Ng Zhi An Committed by Commit Bot

[wasm-simd][scalar-lowering] Fix 64x2 load splat

64x2 nodes were already supported, we just didn't add the case for
64x2 load splat. Add that in and we pass simd_load_splat.js.

Bug: v8:10507
Change-Id: If9145e1b3a4595f4707ca0fc3dcee466773c054f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432074Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70149}
parent 65c15f4f
...@@ -360,6 +360,9 @@ void SimdScalarLowering::SetLoweredType(Node* node, Node* output) { ...@@ -360,6 +360,9 @@ void SimdScalarLowering::SetLoweredType(Node* node, Node* output) {
case LoadTransformation::kS32x4LoadSplat: case LoadTransformation::kS32x4LoadSplat:
replacements_[node->id()].type = SimdType::kInt32x4; replacements_[node->id()].type = SimdType::kInt32x4;
break; break;
case LoadTransformation::kS64x2LoadSplat:
replacements_[node->id()].type = SimdType::kInt64x2;
break;
case LoadTransformation::kI16x8Load8x8S: case LoadTransformation::kI16x8Load8x8S:
case LoadTransformation::kI16x8Load8x8U: case LoadTransformation::kI16x8Load8x8U:
replacements_[node->id()].type = SimdType::kInt16x8; replacements_[node->id()].type = SimdType::kInt16x8;
...@@ -587,6 +590,7 @@ void SimdScalarLowering::LowerLoadTransformOp(Node* node, SimdType type) { ...@@ -587,6 +590,7 @@ void SimdScalarLowering::LowerLoadTransformOp(Node* node, SimdType type) {
case LoadTransformation::kS8x16LoadSplat: case LoadTransformation::kS8x16LoadSplat:
case LoadTransformation::kS16x8LoadSplat: case LoadTransformation::kS16x8LoadSplat:
case LoadTransformation::kS32x4LoadSplat: case LoadTransformation::kS32x4LoadSplat:
case LoadTransformation::kS64x2LoadSplat:
load_rep = MachineTypeFrom(type); load_rep = MachineTypeFrom(type);
break; break;
default: default:
......
...@@ -42,7 +42,6 @@ ...@@ -42,7 +42,6 @@
# we finish the implementation, see v8:10507. # we finish the implementation, see v8:10507.
'proposals/simd/simd_conversions' : [PASS, FAIL], 'proposals/simd/simd_conversions' : [PASS, FAIL],
'proposals/simd/simd_lane' : [PASS, FAIL], 'proposals/simd/simd_lane' : [PASS, FAIL],
'proposals/simd/simd_load_splat' : [PASS, FAIL],
}], # ALWAYS }], # ALWAYS
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment