- 26 Jul, 2018 26 commits
-
-
Ivica Bogosavljevic authored
MIPS team has moved to new @wavecomp.com e-mail addresses. This CL is not actually changing owners, it only renames the owners to the new email addresses. No-Presubmit: true Change-Id: Ic334defa06a36d974de87e99ed6c30bdf021958f Reviewed-on: https://chromium-review.googlesource.com/1151349 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#54732}
-
Michael Starzinger authored
This reverts commit 53fe5c44. Reason for revert: Test can be re-enabled, a fix for the flake landed by now. Original change's description: > [wasm] Temporarily disable --wasm-shared-engine test. > > R=leszeks@chromium.org > > Change-Id: Ib037c43571cda0e2da3c6da3d763cfe27c797413 > Reviewed-on: https://chromium-review.googlesource.com/1150033 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54692} TBR=mstarzinger@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I406740898d896a18eef365cdd20581d5de84023a Reviewed-on: https://chromium-review.googlesource.com/1151407Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54731}
-
Sigurd Schneider authored
This is a reland of f5a8352b Original change's description: > [embedded-builtins] Enable on all arches except x86 for benchmarks > > This CL enables embedded builtins to get benchmark feedback. We need > this feedback to identify and address remaining performance problems. > > Bug: v8:6666 > Change-Id: I8f77f218e656b55ddabe1236eb2a1d14a5ac6233 > Reviewed-on: https://chromium-review.googlesource.com/1105834 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53836} Bug: v8:6666 Change-Id: Idd736f3ec06a7ea57e53a666fd5434e32ca316ad Reviewed-on: https://chromium-review.googlesource.com/1148100 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54730}
-
jgruber authored
This is a refactoring-only CL that packs builtin offsets and lengths into a metadata struct. The struct should make future modifications to metadata simpler. Bug: v8:6666 Change-Id: Iae8070c2aa24d7e803cd75da3dea09e437ef275e Reviewed-on: https://chromium-review.googlesource.com/1145069 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54729}
-
Stephan Herhut authored
This is a first step to make basic block profiling work in wasm. More is needed, including eventually making the profiler thread safe. Change-Id: Ic216c881a4ab5a633e147e5538bb405c32e687cd Reviewed-on: https://chromium-review.googlesource.com/1150234 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=cctest/test-wasm-shared-engine BUG=v8:7424 Change-Id: I32510f33fb88c2f1a79864e6033d3aa53ad9fe48 Reviewed-on: https://chromium-review.googlesource.com/1150149 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54727}
-
Clemens Hammacher authored
This ensures that tests actually abort on unimplemented opcodes instead of just printing them as "Unimplemented Instruction". If used to disassemble a code region though, we want to ignore unimplemented opcodes to keep printing remaining valid instructions. The tests were previously fixed by Deepti in 8fa509d3, but this got partly reverted on the "Address" refactoring in 2459046c. R=titzer@chromium.org Change-Id: I802dda2b0f45ee77c4f9b244ed984b1c4679bac3 Reviewed-on: https://chromium-review.googlesource.com/1146649 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54726}
-
Georg Neis authored
All we care about w.r.t FieldType is object identity. Moreover, FieldType does not have its own instance type. Hence it makes no sense to have the broker know about FieldType at all. Bug: v8:7790 Change-Id: I585e7e06826fae95890c1889ae2f4613479cbb32 Reviewed-on: https://chromium-review.googlesource.com/1151300 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL uses segfaulting instructions in embedded builtins, instead of a trap handler which require relocation and can hence not be used in embedded builtins. Bug: v8:7985, v8:6666 Change-Id: I87776785602f13d15f565d49b2332eb2adc62bd4 Reviewed-on: https://chromium-review.googlesource.com/1151192 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:838864 Change-Id: I02e38778ec4c33a20f4b2e93fb22615baa316883 Reviewed-on: https://chromium-review.googlesource.com/1151295 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54723}
-
Marja Hölttä authored
BUG=v8:7308 TBR=mlippautz@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic310ebcf0af2f3985cee9872f6e57a05652c4484 Reviewed-on: https://chromium-review.googlesource.com/1151197Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54722}
-
Théotime Grohens authored
This CL tries to reduce as much as possible the emission of Float64 operations in the inlining of DataView methods. It adds CheckSmi calls guarding the main variables that the methods use, and deopts back to the baseline when outside of Smi range. This should happen extremely rarely anyway, since we don't allow ArrayBuffers to be larger than that by default. Change-Id: I26fdd7b6884507a3a555dea114cf30da487dd34c Reviewed-on: https://chromium-review.googlesource.com/1151194Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#54721}
-
Toon Verwaest authored
Change-Id: I388f6a6c937b6897efe9e88b06ba4b56670fea4f Reviewed-on: https://chromium-review.googlesource.com/1151191 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This test uses assertOptimized and is not suitable for GC stress. Change-Id: If746c7980f93da2834deac879751d66c151e5aed Reviewed-on: https://chromium-review.googlesource.com/1151122 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Ivica Bogosavljevic authored
MIPS64 doesn't support 32-bit compare operations, instead it relies that values in registers are properly sign extended to 64-bit. Sign extending and then comparing is a costly operation that we want to avoid. We use costly compare only in those cases when one operand is signed and other is unsigned. This CL adds marks PoisonedLoad and ProtectedLoad of unsigned values as needing full compare instead of optimized one. TEST=mjsunit/empirical_max_arraybuffer Change-Id: I7e6599d7c6e6969b74301cf88f1e5f32ee7b18ce Reviewed-on: https://chromium-review.googlesource.com/1150536 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
-
Michael Lippautz authored
Instead of actually allocating an objects just test the corner cases around the page boundary by casting addresses. Bug: v8:7984 Change-Id: I27615cc193d6f85abc91cfe898719a4a9b761f23 Reviewed-on: https://chromium-review.googlesource.com/1151114Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54717}
-
Andreas Haas authored
Stack parameters on arm64 require padding. Since the stack areas for parameters and returns should not overlap, we have to pad the parameters already during the construction of the CallDescriptor so that we can set the correct stack offset for returns. R=mstarzinger@chromium.org Bug: chromium:838098 Change-Id: I23389dc35037054b750e61ea6b1bfdfc4c5bc868 Reviewed-on: https://chromium-review.googlesource.com/1150178Reviewed-by:
-
Dan Elphick authored
Add v8_deprecation_warnings and v8_imminent_deprecation_warnings to external_config so they can also control how embedders see deprecation warnings. Also defaults v8_deprecation_warnings to true. Change-Id: I267607d7b3e1ff6ee34a5555722118f9f22e0791 Reviewed-on: https://chromium-review.googlesource.com/1151110Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54715}
-
Andreas Haas authored
R=herhut@chromium.org Change-Id: I9c67227da8d304a805f7f25fa64862ee400530d7 Reviewed-on: https://chromium-review.googlesource.com/1149820Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54714}
-
Michael Lippautz authored
The test creates a new spaces without hooking it up into Heap, which makes allocations crash. Tbr: leszeks@chromium.org No-try: true Bug: v8:7984 Change-Id: I58c43eedd4fbbedfacfdee3a3bae99c4107404ec Reviewed-on: https://chromium-review.googlesource.com/1151112Reviewed-by:
-
Rodrigo Bruno authored
This CL depends on Reland^2 "Avoiding re-externalization of strings" (Idb1b6d1b29499f66bf8cd704977c40b027f99dbd).. Previously landed as Ied341ec6268000343d2a577b22f2a483460b01f5 and I3fe2b294f6e038d77787cf0870d244ba7cc20550 Previously reviewed at https://chromium-review.googlesource.com/1121736 and https://chromium-review.googlesource.com/1118164 Bug: chromium:845409 Change-Id: Ied50bbcaa22a90ecaf15dca19dbc9aaec1737223 Reviewed-on: https://chromium-review.googlesource.com/1147227Reviewed-by:
-
Georgia Kouveli authored
The tests were not flushing the i-cache before calling the generated code. Use Factory::NewCode to make sure that the i-cache is flushed instead. Bug: v8:7977 Change-Id: I9c7c6f0d0e31700634e50279e75858a5d74603d8 Reviewed-on: https://chromium-review.googlesource.com/1150165Reviewed-by:
-
Michael Lippautz authored
Move write barrier essentials into heap/heap-write-barrier-inl.h. Avoid including further heap inline headers by relying on constant to load flags from. Bug: v8:7490 Change-Id: I2891299f1b1ca2c3e2031cb9c63b583b1665e3f9 Reviewed-on: https://chromium-review.googlesource.com/1148448 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54710}
-
Frank Tang authored
Bug: v8:7960 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2ea86824e98d9c92a838b8c515e9ab238abe51d1 Reviewed-on: https://chromium-review.googlesource.com/1149616 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54709}
-
Frank Tang authored
Bug: v8:7979 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Idbda0c93f55fe8a9b560ee006a3ed7dcceb1a540 Reviewed-on: https://chromium-review.googlesource.com/1149442 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2c97c10..ad6fe7d Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/0dd5c6f..691bfec Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6cf86b3..c829a63 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/01ce059..ad463c9 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/9a5d7ce..12961e5 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I51ddd601160637e08f84500c0a9e92069bbdf247 Reviewed-on: https://chromium-review.googlesource.com/1150969 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54707}
-
- 25 Jul, 2018 14 commits
-
-
Caitlin Potter authored
Includes fixes for several ClusterFuzz regressions: 1) fix an invalid Handle-cast in ic.cc (chromium:866282) 2) fix for improper accounting of used/unused inobject fields, found by clusterfuzz (chromium:866357). 3) fix number of control outputs for the JSCloneObject operator to be used by IfSuccess and IfException nodes (chromium:866727). 4) fix property constness in out-of-object properties of fast-cloned object to be compatible with DCHECKs in StoreIC (chromium:866861). Also includes the fixups missing from the initial commit, and regression tests BUG=v8:7611, chromium:866282, chromium:866357, chromium:866727, chromium:866861 R=jkummerow@chromium.org, mvstanton@chromium.org TBR=rmcilroy@chromium.org Change-Id: I77220308482f16db2893c0dcebec36530d0f5540 Reviewed-on: https://chromium-review.googlesource.com/1146297 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#54706}
-
Ross Mcilroy authored
This means V8_DEPRECATE_SOON apis will cause warnings when building V8 standalone. BUG=v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I84d6ba4179a99a04ffedcfc093e50cea8b17e2a0 Reviewed-on: https://chromium-review.googlesource.com/1149606 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54705}
-
Jakob Kummerow authored
The test driver compares command-line arguments against test names it finds on disk. Using Python's "fnmatch" for this nicely handles wildcards, but is relatively slow. For given test names that don't contain any '*', we can use string equality testing, which is much faster. Example: the time to evaluate tools/run-tests.py --arch x64 --mode release \ $(grep 'object-spread' -l -r test/test262/data/test/ | \ sed -E 's|\.js$||' | \ sed -E 's|^test/test262/data/test/|test262/|') goes from "I gave up and killed the process after several minutes" to a couple of seconds with this patch. Change-Id: I9ec404b7516afd801fe6126347f6dff533d1977c Reviewed-on: https://chromium-review.googlesource.com/1149196 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: -
Rodrigo Bruno authored
Previously landed as 2c4c2ad6 / #54599 and f34158c9 / #54637 Previously reviewed at https://chromium-review.googlesource.com/1139056 and https://chromium-review.googlesource.com/1146583 Bug: chromium:845409, chromium:866208 Change-Id: Idb1b6d1b29499f66bf8cd704977c40b027f99dbd Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1148281Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Ross Mcilroy authored
Use the isolate version instead. BUG=v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5239192fe6d31e84028806127d21ac54ee0a8ef6 Reviewed-on: https://chromium-review.googlesource.com/1146181 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Ross McIlroy authored
This reverts commit 6755b956. Reason for revert: Causing test failures on gc-stress bot: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8940015537308234128/+/steps/Mjsunit_-_slow_path/0/logs/array-multiple-receiv../0 Original change's description: > [in-place weak refs] Use WeakArrayList in Heap::noscript_list. > > BUG=v8:7308 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ia53233a3a0ba13b8019f2fda4bc4876ebf4feb76 > Reviewed-on: https://chromium-review.googlesource.com/1149367 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54700} TBR=marja@chromium.org,mlippautz@chromium.org Change-Id: I5e9b916a910b812c3cb50be18416c9e9e8ac7b24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1150125Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54701}
-
Marja Hölttä authored
BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia53233a3a0ba13b8019f2fda4bc4876ebf4feb76 Reviewed-on: https://chromium-review.googlesource.com/1149367 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Marja Hölttä authored
This significantly reduces the build time when modifying wasm files: before touching all wasm headers required 684 steps to rebuild, now it's 216. BUG=v8:7754,v8:7490 TBR=clemensh@chromium.org, ulan@chromium.org, tebbi@chromium.org, verwaest@chromium.org, jgruber@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9003b5b73ac568a29688c5f97ec718c9de8aaaef Reviewed-on: https://chromium-review.googlesource.com/1150163 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Ivica Bogosavljevic authored
Fix `d324382e` Change-Id: I00d15869ab6ee150f458ecbc1688308ebd5a5819 Reviewed-on: https://chromium-review.googlesource.com/1150151Reviewed-by:
-
Sigurd Schneider authored
This check is likely unneeded. Change-Id: Ie2b39f64312c362aabcb7168d6f1f1312b82d40c Reviewed-on: https://chromium-review.googlesource.com/1146735 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: If0fb6e4a20c334610453e9fe648151abca681442 Reviewed-on: https://chromium-review.googlesource.com/1150154Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Change-Id: I2d8d07f048204874995dd4d349b6fb2b5b226630 Reviewed-on: https://chromium-review.googlesource.com/1150158Reviewed-by:
-
Georg Neis authored
Change-Id: I5cc5dc227a36ff38145df35b3afd067ebba2ad7c Reviewed-on: https://chromium-review.googlesource.com/1149361Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ivica Bogosavljevic authored
Change-Id: I3805bb04e2ae6b620d12b8b5e878fff0d27aa1f1 Reviewed-on: https://chromium-review.googlesource.com/1150027Reviewed-by:
-
