- 25 Mar, 2021 7 commits
-
-
Michael Achenbach authored
This reverts commit db16dce2. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux%20Debug/8771 Original change's description: > [api] Assign serial numbers when template infos are added to cache > > Instead of assigning serial numbers when the template infos are > created, this patch creates serial numbers only when they are added to > cache. > > This way only the ones that are first instantiated are allocated the > fast template cache. Previously, various accessors and methods that > would almost never get instantiated got assigned to the fast template > cache. > > Bug: v8:11284 > Change-Id: I6b633e56e59cbfc3fa5d4ee2db53ca2849eecdd7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621081 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73655} Bug: v8:11284 Change-Id: I382915b2c1be1d87d7a7a961d13e1dd5e3951a4f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786844 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73659}
-
Andreas Haas authored
The installation of conditional features in WebAssembly needs the context to be set in the isolate to fix https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/b8851955177753045904/overview. The context cannot be passed explicitly to all uses of the context, because Isolate::object_function() accesses the native_context through the isolate. Change-Id: I20334fd6779326e64825a15ba2aca3ae06a5c0d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784684Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73658}
-
Sam Parker authored
Add Float32Select and Float64Select as OptionalOperators and insert these, if supported, when handling a Select expression in the wasm graph builder. FlagsContinuation have been modified to support the select operation and code generation support has been added for arm64. This improves the 'Bullet' physics benchmark by ~2-3%. Change-Id: I928c3085c9136ad8baeeb34c71c47c1c8338844c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763871 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73657}
-
Patrick Thier authored
This is a reland of e3ccb538 No changes for the reland. This CL was speculatively reverted, but was not the cause of the problem. TBR=jgruber@chromium.org Original change's description: > Reland "[sparkplug][deoptimizer] Deoptimize to baseline." > > This is a reland of bdcd7d79 > > Handle lazy deopts when the current bytecode is JumpLoop. > Instead of advancing to the next bytecode, re-execute the JumpLoop. > > TBR=jgruber@chromium.org, neis@chromium.org > > Original change's description: > > [sparkplug][deoptimizer] Deoptimize to baseline. > > > > If we have baseline code, deoptimize to baseline instead of the > > interpreter. The process is similar to deopting to the interpreter. > > We just use different builtins > > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > > patch an interpreter frame to a baseline frame and continue execution in > > baseline code (based on the deopt type, at the current or next > > bytecode). > > > > Bug: v8:11420 > > Change-Id: Iabaefb36c05155a435c7b380906a86d9b9d549fa > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695591 > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#73609} > > Bug: v8:11420 > Change-Id: Ib8cac028121188ddc23ff29377760ed684eb7392 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783035 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73636} Bug: v8:11420 Change-Id: I7fbbb73a4fdaeab8b294862ee6ae952928c57994 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784695 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73656}
-
Sathya Gunasekaran authored
Instead of assigning serial numbers when the template infos are created, this patch creates serial numbers only when they are added to cache. This way only the ones that are first instantiated are allocated the fast template cache. Previously, various accessors and methods that would almost never get instantiated got assigned to the fast template cache. Bug: v8:11284 Change-Id: I6b633e56e59cbfc3fa5d4ee2db53ca2849eecdd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621081Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#73655}
-
Sathya Gunasekaran authored
This reverts commit c10aa432. Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/b8851806981073807856/overview Original change's description: > [sparkplug] Enable short builtin calls by default > > ... when they are enabled via the GN flag. > > Also disable this optimizaion for CFI builds for now. > > Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on > certain configurations and that's expected. This is a temporary fix > until the full solution is implemented. > See the design doc linked to the issue for details. > > Bug: v8:11527 > Change-Id: I7444c6878ea58d67ef580cf50cb550b3820c85c4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784690 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73650} Bug: v8:11527 Change-Id: I96ff92e3f5c1a1a7ebe68d7f9d2981b5cf9c0094 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784697Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#73654}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f628144..7b935eb Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/731dd85..f50df92 Rolling v8/third_party/aemu-linux-x64: oZxl99tyPs7o9Eq0hlPel1m4iyPu1Z92wj2Llb6HWwEC..wvBTICmOxqrOyqTGFXVMcKyHB3KmKkB4Xo6VVahwXs8C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/dbc2c42..4f773bc TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I11a315567cd12d4010a191f4b6e5fad8f9735c82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785805Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73653}
-
- 24 Mar, 2021 33 commits
-
-
Ng Zhi An authored
SharedTurboAssembler is shared between ia32 and x64. It contains shared functionality between these two backends. It derives from TurboAssemblerBase, and the backend-specific TurboAssembler derives from SharedTurboAssembler. That way, LiftoffAssembler does not need to change. As an example, we move a single member function I64x2SConvertI32x4High into SharedTurboAssembler. This function has the exact same implementation on ia32 and x64, and is now defined in a single place. Bug: v8:11589 Change-Id: I1c4a0628d61960e7398d458fb813561751e0614f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773609Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73652}
-
Frank Emrich authored
This CL adds: a) Allocation and Copy operations on the CSA side b) Helpers needed for that on both the CSA and Torque side Bug: v8:11330 Change-Id: I322c84e1762d2d3503a0d4809c6e1c0bc9d442e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2775563Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73651}
-
Igor Sheludko authored
... when they are enabled via the GN flag. Also disable this optimizaion for CFI builds for now. Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on certain configurations and that's expected. This is a temporary fix until the full solution is implemented. See the design doc linked to the issue for details. Bug: v8:11527 Change-Id: I7444c6878ea58d67ef580cf50cb550b3820c85c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784690 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Igor Sheludko authored
In particular Copy and EnumerationOrder. Tbr: emrich@google.com Change-Id: Iff3e67b1c51fc070672e1b041dea43339518b6c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784694Reviewed-by:
-
Milad Fa authored
Change-Id: I2fe3b9431fbb22ee045090ba199bfa3b6fd5e19d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785424Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73648}
-
Frank Emrich authored
This test is unnecessarily slow due to the CSA test suite for SwissNameDictionary doing excessive runtime calls at the moment. This causes timeouts on various bot configurations. Change-Id: Id872698f88f699982362e68da7e9c4a26333f233 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784691 Commit-Queue: Frank Emrich <emrich@google.com> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Ia163acfd04d287d33570374254b661becaf1cc67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782160Reviewed-by:
-
Ng Zhi An authored
We now canonicalize earlier in the pipeline, and don't need to worry about non-canonicalized shuffles. Bug: v8:11542,v8:11257 Change-Id: If9f5c44061465be339c98e479fd8c5a437bbd74b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2778673Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73645}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b43166a..f628144 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/4e07843..731dd85 Rolling v8/third_party/aemu-linux-x64: osbsa1Jjgk8WbE3Ckv8288sgvejWZeAN8DB42wp0YV8C..oZxl99tyPs7o9Eq0hlPel1m4iyPu1Z92wj2Llb6HWwEC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e46359d..dbc2c42 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/0964a78..6900bf4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/24cecab..84682eb Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I14ec8ad5ccca6d30ca5cc23e0145cb0cbed1f634 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785241Reviewed-by:
-
Deepti Gandluri authored
This reverts commit e3ccb538. Reason for revert: Speculative revert for ARM 64 CFI fails - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/5174? Original change's description: > Reland "[sparkplug][deoptimizer] Deoptimize to baseline." > > This is a reland of bdcd7d79 > > Handle lazy deopts when the current bytecode is JumpLoop. > Instead of advancing to the next bytecode, re-execute the JumpLoop. > > TBR=jgruber@chromium.org, neis@chromium.org > > Original change's description: > > [sparkplug][deoptimizer] Deoptimize to baseline. > > > > If we have baseline code, deoptimize to baseline instead of the > > interpreter. The process is similar to deopting to the interpreter. > > We just use different builtins > > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > > patch an interpreter frame to a baseline frame and continue execution in > > baseline code (based on the deopt type, at the current or next > > bytecode). > > > > Bug: v8:11420 > > Change-Id: Iabaefb36c05155a435c7b380906a86d9b9d549fa > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695591 > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#73609} > > Bug: v8:11420 > Change-Id: Ib8cac028121188ddc23ff29377760ed684eb7392 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783035 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73636} Bug: v8:11420 Change-Id: Icd797b4979a114a2a627e12c8bb7d2215df03182 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785074Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
This reverts commit 407ce2d9. Reason for revert: Speculative revert for Test262 failures on ARM 64 CFI - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/5174? Original change's description: > [sparkplug] Enable short builtin calls by default > > ... when they are enabled via the GN flag. > > Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on > certain configurations and that's expected. This is a temporary fix > until the full solution is implemented. > See the design doc linked to the issue for details. > > Bug: v8:11527 > Change-Id: Ie59f55050c02fe523e2be890e2a6f74ff3eca1ea > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784682 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73637} Bug: v8:11527 Change-Id: I1376bfeb9297ff4929e4fda00dc0ca2a54fb68c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785075Reviewed-by:
-
Frank Emrich authored
This is the second reland of https://chromium-review.googlesource.com/c/v8/v8/+/2744138. It shortens the runtime of further tests. Original description: This CL is part of a series that adds the C++ implementation of SwissNameDictionary, a deterministic property backing store based on Swiss Tables. This CL adds the actual tests for SwissNameDictionary, defined in test-swiss-name-dictionary-shared-tests.h, using the infrastructure in test-swiss-name-dictionary-infra.[h|cc]. Change-Id: I5b8a7cefb4115ade25b4f8ce032fab9aa10a7b04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784683Reviewed-by:
-
Andreas Haas authored
R=nicohartmann@chromium.org Change-Id: I48294d6944c32ad6b3ee00099c682cb63ad28442 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784685Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73640}
-
Ng Zhi An authored
Support the various combinations of arch-mode-target that gm.py understands, and also completion of cctests. Bug: v8:11567 No-Try: true Change-Id: I05285a93253f4225889e949890f5352bbc173c91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774708 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73639}
-
Santiago Aboy Solanes authored
We set the bit_field_2 fields at map construction. Bug: v8:7790, chromium:1150811 Change-Id: I673334d6900993b8a52e3b85d504cbc3f457c020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773053 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... when they are enabled via the GN flag. Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on certain configurations and that's expected. This is a temporary fix until the full solution is implemented. See the design doc linked to the issue for details. Bug: v8:11527 Change-Id: Ie59f55050c02fe523e2be890e2a6f74ff3eca1ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784682 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Patrick Thier authored
This is a reland of bdcd7d79 Handle lazy deopts when the current bytecode is JumpLoop. Instead of advancing to the next bytecode, re-execute the JumpLoop. TBR=jgruber@chromium.org, neis@chromium.org Original change's description: > [sparkplug][deoptimizer] Deoptimize to baseline. > > If we have baseline code, deoptimize to baseline instead of the > interpreter. The process is similar to deopting to the interpreter. > We just use different builtins > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > patch an interpreter frame to a baseline frame and continue execution in > baseline code (based on the deopt type, at the current or next > bytecode). > > Bug: v8:11420 > Change-Id: Iabaefb36c05155a435c7b380906a86d9b9d549fa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695591 > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73609} Bug: v8:11420 Change-Id: Ib8cac028121188ddc23ff29377760ed684eb7392 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783035Reviewed-by:
Patrick Thier <pthier@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73636}
-
Andreas Haas authored
LiftoffCompiler::ProcessParameter assumed that by processing parameters in the order of their index, register parameters get processed first, and that for processing stack parameters it can already use all registers as temp registers. This is not true with reference type parameters, because registers always first get assigned to value type parameters even when there is a reference type parameter with a lower index. Because of this incorrect assumption register parameters were overwritten by reference type parameters on the stack that got processed first. With this CL, only those registers get used as temp registers for reference type parameters that are not used for parameters. CC=jkummerow@chromium.org, clemensb@chromium.org R=thibaudm@chromium.org Bug: v8:11596 Change-Id: I30ed7f073147df0bd81b9ef4d2b2a54d7badc937 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784560 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73635}
-
Milad Fa authored
memcpy might need the above header included to prevent compilation errors on gcc. Change-Id: Idfc901f160e051effb322d7da6ecc682b0fedb11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782486Reviewed-by:
-
Andreas Haas authored
By accident a "w"-register was used to push references on the stack instead of an "x"-register. This CL fixes the bug. CC=jkummerow@chromium.org R=thibaudm@chromium.org Bug: v8:11596 Change-Id: I5e0b6bebdc763f8d30fd2891786f6c82b9c1e7ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783038Reviewed-by:
-
Igor Sheludko authored
... of physical memory, since builtins re-embedding comes with a memory overhead. Bug: v8:11527 Change-Id: I24b77c3ab63e1891bd4c6134c3f3456921cc2a01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784564Reviewed-by:
-
Camillo Bruni authored
- Handle sparkplug code - Handle regexp code-creation events in the tick-processor, which have no valid state marker in the maybe_func data - Remove calls to print() that break the tick-processor web version Change-Id: Ic726d1ae3a41cd46f42cf5498e8463564d3b6b83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784562Reviewed-by:
-
Milad Fa authored
This reverts commit 94272ea5. Reason for revert: original port was reverted Original change's description: > PPC/s390: [sparkplug][deoptimizer] Deoptimize to baseline. > > Port bdcd7d79 > > Original Commit Message: > > If we have baseline code, deoptimize to baseline instead of the > interpreter. The process is similar to deopting to the interpreter. > We just use different builtins > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > patch an interpreter frame to a baseline frame and continue execution in > baseline code (based on the deopt type, at the current or next > bytecode). > > R=pthier@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com > BUG= > LOG=N > > Change-Id: I3230f3f3c6506230b2751a3389f10b022dec61a3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783022 > Reviewed-by: Junliang Yan <junyan@redhat.com> > Commit-Queue: Milad Fa <mfarazma@redhat.com> > Cr-Commit-Position: refs/heads/master@{#73618} Change-Id: I903ad90099c4dc5f153d28aea9246933ac69972b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784002 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73630}
-
Sathya Gunasekaran authored
This reverts commit bc22fe45. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20GC%20Stress/b8851879177803719072/overview Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b43166a..23310ef > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/4e07843..731dd85 > > Rolling v8/third_party/aemu-linux-x64: osbsa1Jjgk8WbE3Ckv8288sgvejWZeAN8DB42wp0YV8C..oZxl99tyPs7o9Eq0hlPel1m4iyPu1Z92wj2Llb6HWwEC > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e46359d..dbc2c42 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/07f4869..1a8ecf1 > > Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/0964a78..6900bf4 > > Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b > > Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b > > Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Id531aa3cc66535dacac78b11fcf50b0269e3e71a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782609 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#73628} Change-Id: Ie710cc5ad17caf3ec4a5e38a48b938ef64cc1376 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784565 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73629}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b43166a..23310ef Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/4e07843..731dd85 Rolling v8/third_party/aemu-linux-x64: osbsa1Jjgk8WbE3Ckv8288sgvejWZeAN8DB42wp0YV8C..oZxl99tyPs7o9Eq0hlPel1m4iyPu1Z92wj2Llb6HWwEC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e46359d..dbc2c42 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/07f4869..1a8ecf1 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/0964a78..6900bf4 Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id531aa3cc66535dacac78b11fcf50b0269e3e71a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782609Reviewed-by:
-
Thibaud Michaud authored
Take into account that the implicit rethrow at the end of a try block might unpack the exception values, and reserve enough stack space for them. This is normally done for all throwing opcodes before the switch, but 'end' is not considered a throwing opcode, which is why it needs special handling. Also clean up by factorizing the rethrow logic. R=ahaas@chromium.org Bug: chromium:1186795 Change-Id: I6fde1b88085db95a9cab32c2c8e0ed1d28b64a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783024Reviewed-by:
-
Marja Hölttä authored
It needs to return the ToObject-converted receiver, not the original receiver. Bug: v8:11362 Change-Id: I6404122c91402ea58851238d074951f1b7f2a039 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783036Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73626}
-
Niek van der Maas authored
toString on JS Proxies are leaking, see this sample code: undefined[Function.prototype.toString] undefined[new Proxy(Function.prototype.toString, {})] This change fixes the behavior. Patch credits to Yusif <yusif.khudhur@gmail.com> Change-Id: Id82a0a5c245469973452a3e6609cb91978274b8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739980 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Mythri A authored
Recently we changed feedback vector allocation to be based on the bytecode size of the function. The threshold at which the feedback vectors are allocated was set to 12 * bytecode size of the function. This caused a couple of regressions on IC:duration and some regressions on other benchmarks. To avoid these regressions this cl reduces the scale factor to 8 instead of 12. Bug: chromium:1187733 Change-Id: I0553d368434499cc52a6e786b5de6d6b954e6546 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2778295 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#73624}
-
Omer Katz authored
Every page that can be accessed concurrently during marking needs to be synced to avoid data races with page alloation. TraceTrait for mixins uses the object start bitmap of a page and thus requires a sync. Bug: chromium:10561670 Change-Id: Ia26be973019dcd1d9f7650cc139b16369d515df6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783023Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73623}
-
Manos Koukoutos authored
We are disabling loop unrolling for wasm until we find a solution to some stability problems. Bug: v8:11298, chromium:1184929 Change-Id: I21c66d37b1606175a5ed44b6db0269651da1f3c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2780298 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
This reverts commit bdcd7d79. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Linux%20Future/7996/blamelist Original change's description: > [sparkplug][deoptimizer] Deoptimize to baseline. > > If we have baseline code, deoptimize to baseline instead of the > interpreter. The process is similar to deopting to the interpreter. > We just use different builtins > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > patch an interpreter frame to a baseline frame and continue execution in > baseline code (based on the deopt type, at the current or next > bytecode). > > Bug: v8:11420 > Change-Id: Iabaefb36c05155a435c7b380906a86d9b9d549fa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695591 > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73609} Bug: v8:11420 Change-Id: Ie8b936df343b9194c0a6e50e0c44b67c0d9a012d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783030 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73621}
-
Sathya Gunasekaran authored
This reverts commit 0980c8da. Reason for revert: breaks mac64 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b43166a..cb055e2 > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/4e07843..731dd85 > > Rolling v8/third_party/aemu-linux-x64: osbsa1Jjgk8WbE3Ckv8288sgvejWZeAN8DB42wp0YV8C..oZxl99tyPs7o9Eq0hlPel1m4iyPu1Z92wj2Llb6HWwEC > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e46359d..25699ba > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/07f4869..1a8ecf1 > > Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 > > Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 > > Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I099d7793c63d11280691927b559065c96411a697 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782606 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#73619} Change-Id: Ia59bf8d0786058114f70381342939fc9d623b7cb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783029Reviewed-by:
-
