Commit 30bf932f authored by Deepti Gandluri's avatar Deepti Gandluri Committed by Commit Bot

Revert "[sparkplug] Enable short builtin calls by default"

This reverts commit 407ce2d9.

Reason for revert: Speculative revert for Test262 failures on ARM 64 CFI - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/5174?

Original change's description:
> [sparkplug] Enable short builtin calls by default
>
> ... when they are enabled via the GN flag.
>
> Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on
> certain configurations and that's expected. This is a temporary fix
> until the full solution is implemented.
> See the design doc linked to the issue for details.
>
> Bug: v8:11527
> Change-Id: Ie59f55050c02fe523e2be890e2a6f74ff3eca1ea
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784682
> Commit-Queue: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#73637}

Bug: v8:11527
Change-Id: I1376bfeb9297ff4929e4fda00dc0ca2a54fb68c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785075Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73642}
parent 8d671de1
......@@ -1546,7 +1546,7 @@ DEFINE_BOOL(experimental_flush_embedded_blob_icache, false,
#define V8_SHORT_BUILTIN_CALLS_BOOL false
#endif
DEFINE_BOOL(short_builtin_calls, V8_SHORT_BUILTIN_CALLS_BOOL,
DEFINE_BOOL(short_builtin_calls, false,
"Put embedded builtins code into the code range for shorter "
"builtin calls/jumps if system has >=4GB memory")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment