• Andreas Haas's avatar
    [wasm][liftoff] Fix reftype parameter handling · 7d844bdb
    Andreas Haas authored
    LiftoffCompiler::ProcessParameter assumed that by processing parameters
    in the order of their index, register parameters get
    processed first, and that for processing stack parameters it can already
    use all registers as temp registers. This is not true with reference
    type parameters, because registers always first get assigned to value
    type parameters even when there is a reference type parameter with a
    lower index. Because of this incorrect assumption register parameters
    were overwritten by reference type parameters on the stack that got
    processed first.
    
    With this CL, only those registers get used as temp registers for
    reference type parameters that are not used for parameters.
    
    CC=jkummerow@chromium.org, clemensb@chromium.org
    R=thibaudm@chromium.org
    
    Bug: v8:11596
    Change-Id: I30ed7f073147df0bd81b9ef4d2b2a54d7badc937
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784560
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73635}
    7d844bdb
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...