- 03 Aug, 2018 22 commits
-
-
Predrag Rudic authored
In order to enable PIC code in builtins we need to have BranchLong position independent. Change-Id: I374134ff540b515f3cf385a8b936487b47c55762 Reviewed-on: https://chromium-review.googlesource.com/1152810Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#54901}
-
Théotime Grohens authored
This CL fixes a bug found by Clusterfuzz, in which the functions LoadDataViewByteOffset and -ByteLength incorrectly had a return type of TNode<Smi> instead of TNode<Number>. This caused a CAST() call to fail when the requested byte offset or byte length did not fit inside a Smi, i.e. when the underlying ArrayBuffer of the DataView had a length longer than 2^30 on 32-bit platforms. The CL also includes a new test in mjsunit to test against this. Bug: chromium:869313 Change-Id: Ibb7d29bda5782a12c4b506c070bb03fef8c3ec70 Reviewed-on: https://chromium-review.googlesource.com/1158582 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54900}
-
Clemens Hammacher authored
Move them to builtins-utils-inl.h instead. R=titzer@chromium.org Bug: v8:8015, v8:7965 Change-Id: I692e5871e320896923bed5cc6a2efc609c793446 Reviewed-on: https://chromium-review.googlesource.com/1160845 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54899}
-
Sigurd Schneider authored
We have two constants for the PC load delta; this CL consolidates them into one. The CL does not change MIPS as the two constants are defined to different values there. Bug: v8:6666 Change-Id: If207a59dea3ef33756a5d7330217ab8a176bdf63 Reviewed-on: https://chromium-review.googlesource.com/1161926Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54898}
-
Georg Neis authored
After the recent bugfix, the special case for 'undefined' is no longer needed. Bug: v8:7813 Change-Id: Iee3fccd72c525ac86a6fa6b3c55bcd2ce8159852 Reviewed-on: https://chromium-review.googlesource.com/1161906Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54897}
-
Georg Neis authored
This became obsolete when I rewrote CompilationDependencies. R=jarin@chromium.org Change-Id: Ifc567fafccd33e98be9d1bdf6264c680be3149e4 Reviewed-on: https://chromium-review.googlesource.com/1161919Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54896}
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:7790 Change-Id: Iad9380ac6c6035a731db2e0b2b9abbc9f8570cc2 Reviewed-on: https://chromium-review.googlesource.com/1161915 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I62027d97c40276b5dfa9579fc4e903ee21a55b54 Reviewed-on: https://chromium-review.googlesource.com/1160539 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:8012 v8:7793 Change-Id: Idc5d685d021fd107974b4415f7b855397004cb53 Reviewed-on: https://chromium-review.googlesource.com/1160841Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54893}
-
Peter Marshall authored
FixedArray max size is currently 1024 MB on 64 bit and 512 MB on 32 bit. Update the max size of FixedDoubleArray to match. This doubles the max size for arrays of doubles. Bug: chromium:814599 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3ac1b4caaf5b6428fe8a8c848fffdf84af8a9ae9 Reviewed-on: https://chromium-review.googlesource.com/1160235Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Reason: flaky wasm crashes. This leaves WeakArrayList::RemoveOne (+ tests for it) in place. BUG=v8:7308, v8:8014 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1195d061ae7d3c82f921f94f50df3f09a55de5ca Reviewed-on: https://chromium-review.googlesource.com/1161904Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54891}
-
Clemens Hammacher authored
On all architectures except for arm64 (which has a limit of 128 MB), we increase the maximum wasm code space from 256 MB to 512 MB. This generally allows for bigger WebAssembly modules and tolerates the code size increase because of Liftoff. R=titzer@chromium.org Bug: chromium:840292, v8:6600 Change-Id: I999cc0c96740ad3da15cc70114d7835354d67fbf Reviewed-on: https://chromium-review.googlesource.com/1160702Reviewed-by:
-
Clemens Hammacher authored
arguments.h used methods only defined in objects-inl.h and handles-inl.h. These uses are now moved to arguments-inl.h. Since builtins-utils.h used these methods, it also needs to be split to have an inl header now. R=titzer@chromium.org Bug: v8:7754, v8:7965 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I21db7a86f7c15776eccf060f81f2bde000b92a40 Reviewed-on: https://chromium-review.googlesource.com/1160647Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54889}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:7918 Change-Id: Ida8bec40acc349fe6f4de5316cc9a42f5b5c6e16 Reviewed-on: https://chromium-review.googlesource.com/1161905Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54888}
-
Hai Dang authored
Also add more test cases of Array lastIndexOf with proxy, inspired by test262. In the path for sparse arrays, no changes are needed because element accesses are not observable there (thanks to UseSparseVariant). Bug: v8:7813 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifd47149f654e92f56d0a1ed6b3debc93718702be Reviewed-on: https://chromium-review.googlesource.com/1160307 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54887}
-
Michael Achenbach authored
This reverts commit 12c81480. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3967 Original change's description: > Update GetCurrentStackPosition to use built-in > > By using a built-in this functions works with SafeStack and doesn't > require an attribute disabling ASan. > > BUG=chromium:864705 > > Change-Id: I20cc818f1a0724a017a4f7f9ae3cd8fedb6245ee > Reviewed-on: https://chromium-review.googlesource.com/1141045 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54884} TBR=clemensh@chromium.org,vtsyrklevich@chromium.org Change-Id: I779091eb7e98f6a8920e274df60e35693bfdc512 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:864705 Reviewed-on: https://chromium-review.googlesource.com/1161881Reviewed-by:
-
Michael Achenbach authored
This also removes the config for a non-existing builder. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8009 Change-Id: Ic6d65bce46db9807ffcbeb51d507b51ca5311cfe Reviewed-on: https://chromium-review.googlesource.com/1161802 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
By using a built-in this functions works with SafeStack and doesn't require an attribute disabling ASan. BUG=chromium:864705 Change-Id: I20cc818f1a0724a017a4f7f9ae3cd8fedb6245ee Reviewed-on: https://chromium-review.googlesource.com/1141045 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54884}
-
Michael Lippautz authored
This enables direct uses in e.g. unique_ptr<v8::EmbedderHeapTracer> Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I11f86c916dca5c31413866d9972178fccda7df9c Reviewed-on: https://chromium-review.googlesource.com/1160538Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54883}
-
Clemens Hammacher authored
There is a proposal to make this defined behaviour, so remove the deprecation comment for now. R=jkummerow@chromium.org Bug: v8:3770 Change-Id: Iff50ec544473bed844c586ed242bd062e8d530d8 Reviewed-on: https://chromium-review.googlesource.com/1160238Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54882}
-
Michael Achenbach authored
This skips two tests in TSAN with stress mode only. The tests are particularly slow with isolates testing, but they're also the two lowest hanging fruits in normal TSAN testing. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8009 Change-Id: Ic262fc39dee8ee0d8d1fdad10beced0e8f9c87a0 Reviewed-on: https://chromium-review.googlesource.com/1160860 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cc35cac..641e460 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2acd8e0..eae13a4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6f812e1..29b7b99 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/e4f38ff..c8d8248 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/bb4cc1a..2175972 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifce98c452f5b852a19a967b98620a0d07d6032b1 Reviewed-on: https://chromium-review.googlesource.com/1161611Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54880}
-
- 02 Aug, 2018 18 commits
-
-
Jungshik Shin authored
Etc/GMT* time zones are listed in the INAN time zone database and they should be accepted as valid. This CL will be followed by a CL for moving time zone name checks to C++ that will accept all the time zone names (e.g. EST5EDT, Hongkong, ROK, Zulu). Bug: chromium:364374 Test: intl/date-format/timezone.js Test: mjsunit/regress/regress-crbug-364374 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If0e5327d7e980504a9cb3d2b641e907ebce61180 Reviewed-on: https://chromium-review.googlesource.com/1159546 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
While working on crrev.com/c/1141045 I caused 3 assertThrows() tests under the 'Deeply nested target' tests to fail. The tests for defineProperty, isExtensible, and preventExtensions began to fail under a couple build configurations because my change modified the stack check code such that it no longer inhibited tail call optimization. Under some build configurations the methods responsible for causing a stack oveflow for those 3 methods were tail call optimized and the tests no longer threw an exception. Other built-in implementations of proxy handler methods could also fail in the future due to refactors moving variables off the stack. Change the test to ensure v8 doesn't crash but don't rely on stack overflow exceptions being thrown for the 'deeply nested target' test. BUG=chromium:864705 Change-Id: Iefeaa1d5402986c1831d0f259f83025452756387 Reviewed-on: https://chromium-review.googlesource.com/1159356Reviewed-by:
-
Toon Verwaest authored
Change-Id: Iaad8bc94e9222d309749491df9a500544b5b37da Reviewed-on: https://chromium-review.googlesource.com/1158687 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54877}
-
Adam Klein authored
When TypedArray builtin code was still in JS, we used to completely elide IterableToList when passed an array. This meant that it was possible for the builtins to observe side-effects which mutated the array when that should have been impossible. When IterableToList was ported to CSA, it changed to clone the passed-in array instead of passing it through. This means that there's now no need to guard against side-effects due to ToNumber conversions, so we can simply return the result of Object::IterationHasObservableEffects. Though no test changes are included here, this code is covered by the regression tests added previously when this runtime function was added (and later modified). This still leaves a future TODO to port IterationHasObservableEffects to CSA. Change-Id: If913c035b124ecb59a5f647344b653429a162a2b Reviewed-on: https://chromium-review.googlesource.com/1159733Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#54876}
-
Marja Hölttä authored
Previously, removing an element in the middle made it consume space forever. This fixes that, without changing the complexity of removal / addition. The trade-off is that RemoveOne will shuffle indices (which should be OK for the current users). BUG=v8:7308 Change-Id: I0373e30f2d9d1ffb93a78d383d41b500dbbf3429 Reviewed-on: https://chromium-review.googlesource.com/1159371 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Trampolines to off-heap targets may get inlined. In this case, it is hard to tell where the trampoline is going to; this CL adds code comments which identify the target builtin by name. Bug: v8:6666 Change-Id: Ib085ad118ad64551af2522f9187b4faaad6ce315 Reviewed-on: https://chromium-review.googlesource.com/1160536 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5751 Change-Id: Iabf1310f98d675f86ee7923715cb3fc754da7c8f Reviewed-on: https://chromium-review.googlesource.com/1160650Reviewed-by:
-
Andreas Haas authored
This reverts commit b556c9ea. Reason for revert: Flakes in layout tests: https://crbug.com/870187 Original change's description: > [wasm] Implement the new API for WebAssembly.instantiateStreaming > > This is the second V8 CL to refactor WebAssembly.instantiateStreaming to > make it spec compliant again. The design doc where the whole change is > discussed is available in the tracking bug. The tracking bug also > references prototype implementations of the whole change, which includes > the changes in this CL. > > R=mstarzinger@chromium.org > > Bug: chromium:860637 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I776c0f24959ab5663727d3dfee0248a9b0642a42 > Reviewed-on: https://chromium-review.googlesource.com/1143187 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54834} TBR=mstarzinger@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:860637 Change-Id: Icbf2603143068a49c61de162aa7185a753703e5d Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1160261Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54872}
-
Michael Starzinger authored
This is a reland of c5c447d4 Original change's description: > [wasm] Enable --wasm-shared-engine by default. > > R=titzer@chromium.org > BUG=v8:7424 > > Change-Id: I3bb3be92b6c1bf855904cf0bf334ad98dce74dd4 > Reviewed-on: https://chromium-review.googlesource.com/1156310 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54855} Bug: v8:7424 Change-Id: I58153f05bd1eb764f5e58968de1daaaed79215dc Reviewed-on: https://chromium-review.googlesource.com/1160361Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54871}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8009 Change-Id: I044fffd027f76ad8d76b6546af508e7df7486a61 Reviewed-on: https://chromium-review.googlesource.com/1160522Reviewed-by:
-
Sigurd Schneider authored
This adds two tests that generate calls to embedded builtins, one test inlines the trampoline, and the other uses an indirect load from the roots array. Bug: v8:6666, v8:7997 Change-Id: I077f4e9ed311021edb8ee74db625ebb048fdf66b Reviewed-on: https://chromium-review.googlesource.com/1160237 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I3453dbc7aa8be25730672a11b818d7fff01a987b Reviewed-on: https://chromium-review.googlesource.com/1156695Reviewed-by:
-
Georg Neis authored
R=sigurds@chromium.org Change-Id: I9d07847ef92ff7a512c1624b492b37b6991e3c56 Reviewed-on: https://chromium-review.googlesource.com/1160304Reviewed-by:
-
Michael Starzinger authored
R=yangguo@chromium.org BUG=v8:8009 Change-Id: I20f911efc1ec1ee229e827d88d78cecc168c82f3 Reviewed-on: https://chromium-review.googlesource.com/1160231Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: v8:8009 Change-Id: Ie779b21a488d8a542faa78ffaa625c90058adc35 Reviewed-on: https://chromium-review.googlesource.com/1160489Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54865}
-
Michael Achenbach authored
The TSAN builder will be split into builder and tester. This adds the config for the builder, but keeps the configs for the testers to be removed after the infra side switch. This also cleans up redundant concurrent-marking configs, since concurrent marking is on by default. This also removes a config of a builder that no longer exists. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8009 Change-Id: Ic7b146505b5059a2508da94d01d156d5e5e2b997 Reviewed-on: https://chromium-review.googlesource.com/1160308 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Florian Sattler authored
This is a reland of baa055c7 Original change's description: > Applied noexcept to all mctors and massigns > > Refactoring the code base to use noexcept for their move constructors and move > assignment operators. > > Bug: v8:7999 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I13d24eddba3bfa601cff26fd680a040cf4e71426 > Reviewed-on: https://chromium-review.googlesource.com/1152817 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Florian Sattler <sattlerf@google.com> > Cr-Commit-Position: refs/heads/master@{#54841} Bug: v8:7999 Change-Id: I72394e326a4f8da462ee6285511d721440ceb21d Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1158646Reviewed-by:
-
Ben L. Titzer authored
The wasm/ directory is inconsistent in many places, often within the same file. For all code that exists in a v8::internal::wasm namespace, this CL removes any wasm:: qualifiers, which is especially helpful since most types are already Wasm-named, such as WasmCode, WasmModule, etc. Namespace qualifiers are redundant inside the wasm:: namespace and thus go against the main point of using namespaces. Removing the qualifiers for non Wasm-named classes also makes the code somewhat more future-proof, should we move some things that are not really WASM-specific (such as ErrorThrower and Decoder) into a higher namespace. R=clemensh@chromium.org,mstarzinger@chromium.org Change-Id: Ibff3e1e93c64c12dcb53c46c03d1bfb2fb0b7586 Reviewed-on: https://chromium-review.googlesource.com/1160232 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
