• Vlad Tsyrklevich's avatar
    Refactor unreliable Proxy tests · 7a75d582
    Vlad Tsyrklevich authored
    While working on crrev.com/c/1141045 I caused 3 assertThrows() tests
    under the 'Deeply nested target' tests to fail. The tests for
    defineProperty, isExtensible, and preventExtensions began to fail under
    a couple build configurations because my change modified the stack check
    code such that it no longer inhibited tail call optimization. Under some
    build configurations the methods responsible for causing a stack oveflow
    for those 3 methods were tail call optimized and the tests no longer
    threw an exception.
    
    Other built-in implementations of proxy handler methods could also fail
    in the future due to refactors moving variables off the stack. Change
    the test to ensure v8 doesn't crash but don't rely on stack overflow
    exceptions being thrown for the 'deeply nested target' test.
    
    BUG=chromium:864705
    
    Change-Id: Iefeaa1d5402986c1831d0f259f83025452756387
    Reviewed-on: https://chromium-review.googlesource.com/1159356Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54878}
    7a75d582
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...