- 05 Nov, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/02bef0a..9088cd6 Rolling v8/third_party/aemu-linux-x64: hys6gk1KOHMz9nURGWen255HiLIaVd3e4eZfa-w6l7oC..Ce6sqxwYi8DOFfwlCOP0MURltjjH-QIsgAsJ1p7--KIC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b939095..429f4e0 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8a0d05d..1c179b5 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/3c149f5..7dab69f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b2ffe54..af96b7b TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ie305f81bb17aabb539976e30057152e18e1df4c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3262141Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77717}
-
- 04 Nov, 2021 23 commits
-
-
Camillo Bruni authored
This is a reland of 0446ab7c Additional fix: Manually set the host-defined options on deserialised scripts in d8. Original change's description: > [d8] Verify host-defined options > > d8 never checked what the actual value of the host-defined options are. > We now properly very that the host-defined options is a specific object > so we we don't end up accidentally ignoring a wrong options object. > > Drive-by-fix: > - Convert %AbortJS argument to string > > Bug: chromium:1244145 > Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77699} Bug: chromium:1244145 Change-Id: I8ddfdba27d84c36862323ab9e1aba14b2ff932a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259539 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77716}
-
Andreas Haas authored
The wasm serialization format only contains TurboFan code. All other functions are only represented by placeholders. With this CL serialization fails if the serialized module does not contain any TurboFan functions and would therefore consist only of placeholders. This is a defense in depth approach, because ideally serialization only gets triggered when TurboFan code is available. However, in some scenarios like debugging it can happen that modules without TurboFan code get serialized. Bug: v8:12281 Change-Id: Ib05430ff89eb2317da80fc0d086ce1d7ab0e919d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212510 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77715}
-
Dominik Inführ authored
Change-Id: I68935a96ac674965cf12079daa0aae35be042a97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260523 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77714}
-
Michael Lippautz authored
Adjust WATCHLISTS to only send out updates to those testfiles as part of notifying oilpan-reviews+v8@. Change-Id: Ib877f0353ea2b2d1ac06c93d450145dbeb6fcc66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260517 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77713}
-
Leszek Swirski authored
Remove the concept of JobId from LazyCompileDispatcher, and make SFIs the canonical id for these jobs. This has several consequences: * We no longer split enqueing a job and registering a SFI with that job. We did this previously because we could not allocate SFIs in the Parser -- now with LocalHeap we can, so we do. * We remove the separate Job vector, and make the SFI IdentityMap hold pointers to Jobs directly. This requires a small amount of extra care to deallocate Jobs when removing them from the map, but it means not having to allocate new global handles for jobs. * The SFI is passed into the BackgroundCompileTask instead of the script, so our task finalization doesn't need the SFI anymore. * We no longer need to iterate ParallelTasks after compiling (to register SFIs), so we can get rid of ParallelTasks entirely and access the dispatcher directly from the parser. There are a few drive-bys since we're touching this code: * Jobs are move to have a "state" variable rather than a collection of bools, for stricter DCHECKing. * There's no longer a set of "currently running" jobs, since this was only used to check if a job is running, we can instead inspect the job's state directly. * s/LazyCompilerDispatcher/LazyCompileDispatcher/g Change-Id: I85e4bd6db108f5e8e7fe2e919c548ce45796dd50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259647 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77712}
-
Lutz Vahl authored
R=hablich@chromium.org, vahl@chromium.org Change-Id: I33783822bf8131910ff9840a58b07da5086a92d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260521Reviewed-by: Lutz Vahl <vahl@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#77711}
-
Michael Lippautz authored
LayoutDescriptor has been removed some time ago. Change-Id: I8aa16fcd82be098c9bfd439decef8147514587d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260515 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77710}
-
Michael Lippautz authored
Add CHECK ensuring that the young generation is indeed empty for pointers updating. This is necessary as otherwise iterating an object may race with updating a slot in a Map for WasmStruct. Bug: v8:12185 Change-Id: Id590cf267fedf95d97df2464a638352696ad53db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260514Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77709}
-
Tim van der Lippe authored
This reverts commit f9ebad01. Reason for revert: suspected root cause of crbug.com/1257806 Additionally, this patch might actually be incorrect as we eagerly evaluate native accessors, which can only happen if the debugger is running. Original change's description: > [inspector] Use side-effect free debug evaluate for inherited accessors. > > Replace the hard-coded blocklist ("Response.body" and "Request.body") in > the V8 inspector with proper side-effect free debug evaluate. This is > otherwise a non-functional change and in particular preserves the > behavior of reporting accessors as (own) data properties. That will be > tackled in a follow-up CL. > > This CL is possible because with https://crrev.com/c/3056879 Blink now > properly marks accessors as side-effect free consistently with what the > V8 inspector had done before. > > Doc: http://doc/1gLyyOlssS5zyCSEyybVC-5sp0UnNJj2hBoFyf6ryrTc > Bug: chromium:829571, chromium:1076820, chromium:1119900 > Change-Id: Idb256accaf4cfb5db5982b3eb06ddcef588be635 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3062573 > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> > Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#76019} Bug: chromium:829571, chromium:1076820, chromium:1119900, chromium:1257806 Fixed: chromium:1265372 Change-Id: Ia31a3022aaa9ddeae1f01eaa90e345f8bdbb21c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259653 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#77708}
-
Jakob Kummerow authored
The old "gc-safe" implementation to get the off-heap type information wasn't quite as gc-safe as it needs to be. Due to parallel compaction, we shouldn't check for forwarding pointers; instead we should rely on the old location of the Foreign, but make sure not to look at its Map (which might be a forwarding pointer). Bug: v8:12185 Change-Id: I4570b00a5300a0d7ed8c042fa21d355373e0e691 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260513 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77707}
-
Jakob Gruber authored
- Add an inline fast path for flat strings. - Efficient shape queries. - Add constants for seq/external one/two-byte string tags. Bug: v8:12195 Change-Id: Ia2c3d3c9207ab56bc4f0b425d21c7c93ad98aef4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259530 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77706}
-
Leszek Swirski authored
This reverts commit 0446ab7c. Reason for revert: Lots of failures https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/37355/overview Original change's description: > [d8] Verify host-defined options > > d8 never checked what the actual value of the host-defined options are. > We now properly very that the host-defined options is a specific object > so we we don't end up accidentally ignoring a wrong options object. > > Drive-by-fix: > - Convert %AbortJS argument to string > > Bug: chromium:1244145 > Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77699} Bug: chromium:1244145 Change-Id: I267f4bdbd8afce81934f4e813dbe1ec09ebdc1ae No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259538 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77705}
-
Shu-yu Guo authored
This runtime function behaves like StoreDataPropertyInLiteral, except it can throw, since it's also used for defining public class fields. Unlike the literal use case, class field can end up throwing due to field initializers doing things like freezing the instance. Bug: chromium:1264828 Change-Id: I3ea4d15ad9b906c26763f022c8e22b757fa80b6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3252558 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77704}
-
Corentin Pescheloche authored
The goal of the PR is to add to telemetry a metric estimating the space occupied by the codemap retained by a CpuProfiler and its underlying CodeObserver. This change is motivated by the addition of kEagerLogger to CpuProfiler which when enabled let a CpuProfiler build a CodeMap without an active session. This metric will help us understand better the space consumed by a profiler in that scenario and will also help detect memory leaks. Bug: chromium:1241491 Change-Id: Iadb1ed52b4c1ac70bc554942b4fa795cdf1212f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3224567Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com> Cr-Commit-Position: refs/heads/main@{#77703}
-
Leszek Swirski authored
Some post-compile flag setting was unnecessary, since those flags originally came from the SFI they were being set on. Also, DontOptimizeReason was never actually set, so we can remove it entirely. Change-Id: Ic07821fc20ba4e16a2bd8b9e8ac8c1b266aa4067 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260510 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77702}
-
Jakob Gruber authored
- Use a StringShape instead of repeatedly querying type. - Add a shortcut for already-flat strings. - Unhandlify where possible (all except SlowFlatten). - Mark String::Flatten and StringShape methods V8_INLINE. - Add a specialized ConsString::IsFlat overload. Drive-by: Various (add const, remove this->, helper methods). Bug: v8:12195 Change-Id: If20df12bc29c29cff2005fdc9bd826ed9f303463 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259527 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77701}
-
Leszek Swirski authored
This reverts commit 92edf9a1. Reason for revert: Breaks mjsunit/es6/proxies-json on GCStress https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/39619/overview Original change's description: > [runtime] Optimise paired instance type checks > > Clang doesn't optimise over handle derefs. Change the ValueSerializer > and the JsonStringifier to use InstanceType directly for checks. > This CL squeezes another 1.5% of JSON.stringify in local benchmarks. > > Drive-by-fix: > - Avoid a few more derefs in the JsonStringifier > - Make JsonStringifier::SerializeJSArray a bit more readable > > Change-Id: I37626a6d92a8d9275611a4e6d1d908f2e0c6d43b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247637 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77697} Change-Id: I127dd5832b9caceb0d5b74631eede274551405e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260511 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77700}
-
Camillo Bruni authored
d8 never checked what the actual value of the host-defined options are. We now properly very that the host-defined options is a specific object so we we don't end up accidentally ignoring a wrong options object. Drive-by-fix: - Convert %AbortJS argument to string Bug: chromium:1244145 Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77699}
-
Al Muthanna Athamina authored
Bug: v8:12185 Change-Id: I32518ad88d98f68934a1b3c12b1559e31f0df628 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259528 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77698}
-
Camillo Bruni authored
Clang doesn't optimise over handle derefs. Change the ValueSerializer and the JsonStringifier to use InstanceType directly for checks. This CL squeezes another 1.5% of JSON.stringify in local benchmarks. Drive-by-fix: - Avoid a few more derefs in the JsonStringifier - Make JsonStringifier::SerializeJSArray a bit more readable Change-Id: I37626a6d92a8d9275611a4e6d1d908f2e0c6d43b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247637 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#77697}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/4f31803..8aae0a4 [cleanup] Change `== ""` to `.empty()` on string to avoid clang-tidy warnings (#1271) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/8aae0a4 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I4edce04c4cbc33019942b05ae1fdb094571f0694 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260155Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77696}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cf32591..02bef0a Rolling v8/buildtools/linux64: git_revision:8926696a4186279489cc2b8d768533e61bba73d7..git_revision:90294ccdcf9334ed25a76ac9b67689468e506342 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/75c4ea8..b939095 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/57c928c..8a0d05d Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/16f637f..bf0701d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/21baac0..b2ffe54 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I8f7d055b78dc6db357a4dcfe761e17728ae53b65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260153Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77695}
-
Zhao Jiazhong authored
Currently, the safepoint is last call instruction's return address on mips and loongarch64 platform. But in `CallCFunction`, there are some other instructions after calling, which leading to a wrong safepoint record on mips and loongarch64. So I record the pc for safepoint at the end of `CallCFunction` function, and change `last_call_pc_` to `pc_for_safepoint_`. Besides, commit 48b2b891 introduced a typo on loong64 platform, I also fixed it in this CL. Change-Id: Ia3ea77ae2f6f1c8c604e35f420a7632a78c9725a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3258875 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77694}
-
- 03 Nov, 2021 16 commits
-
-
Anton Bikineev authored
Currently, in the following struct struct LayoutObject : GarbageCollected<>, MixinA, MixinB {}; the subobject that corresponds to the first base GarbageCollected<> always takes up some space (one word). The empty-base-optimization doesn't happen because the second base (MixinA) has the same subobject as the first base (GarbageCollected), which is the most parent class GarbageCollectedBase. The compiler can't "merge" them because it must guarantee that distinct objects of the same type have distinct addresses. The attribute [[no_unique_address]] doesn't work for base classes, unfortunately (but is a good idea for a Standard proposal). As a solution, the CL simply removes GarbageCollectedBase. Bug: chromium:1260797 Change-Id: I415b10a5fbcebce3d6ee97b8870ea9ae90f383a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259654 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77693}
-
Dominik Inführ authored
When a GC happens during context deserialization, NativeContext::retained_maps might be uninitialized and not store a WeakArrayList but Smi 0. Bug: v8:12198 Change-Id: I03c1dfaa013c47907af67bb13b9277d67ca5ffae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259662Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77692}
-
Milad Fa authored
Port 4de20cb1 Original Commit Message: This CL adds a minor change to the arm/arm64 simulators to support up to 20 arguments in a C function call. This change is necessary for an upcoming CL which adds float support to the simulator and tests with more than 20 arguments, see https://chromium-review.googlesource.com/c/v8/v8/+/3060486 R=mslekova@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ic3dabdcaa4982840466190003c56cfe82e91316b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259652Reviewed-by: Junliang Yan <junyan@redhat.com> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77691}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/ba82d462..42e21582f Bug: v8:7834 Change-Id: Icaa556ec606908fb8c0cd110285e054e9f6b0254 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3258874Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#77690}
-
Nico Hartmann authored
This reverts commit a3480b55. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20debug%20-%20header%20includes/22234/overview Original change's description: > Reland "[torque] Don't generate k(?:Start|End)Of\w+FieldsOffset constants" > > This is a reland of 7366f6e2 > > The test that failed after the initial commit was just flaky and has > been fixed; see https://bugs.chromium.org/p/v8/issues/detail?id=12341 > > Original change's description: > > [torque] Don't generate k(?:Start|End)Of\w+FieldsOffset constants > > > > Torque currently generates constants like kStartOfWeakFieldsOffset and > > kEndOfStrongFieldsOffset, which can be used when writing custom > > BodyDescriptors. However, these offsets have some potentially confusing > > behaviors: > > > > * They don't take inheritance into account and describe only the fields > > defined by the current class itself, so there might be (for example) > > strong fields before kStartOfStrongFieldsOffset if they were defined > > by a superclass. > > * kStartOfWeakFieldsOffset points to the first field defined in Torque > > using the keyword `weak`, which indicates fields with *custom* > > weakness semantics (those that should be visited with > > IterateCustomWeakPointers), not those that may contain standard weak > > pointers (visited with IterateMaybeWeakPointers). (As a follow-up, I'd > > like to also rename `weak` to `@customWeak`.) > > > > Given that these constants have very low usage and somewhat bizarre > > semantics, I propose that we remove them. This change does so, and > > updates the existing usages to either define the required constants > > directly in C++ or not use them. I know that defining these constants in > > C++ is more brittle, but I think that brittle and clear is better than > > automatic and incomprehensible. > > > > Bug: v8:7793 > > Change-Id: I87f8c85ccae4027f61ac73d4e7e4e2820e92003b > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199731 > > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > > Cr-Commit-Position: refs/heads/main@{#77411} > > Bug: v8:7793 > Change-Id: Iefdd4014ce4b85b48c19ead79a0316774a5ecd45 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3258082 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#77688} Bug: v8:7793 Change-Id: I7b9667268901b7aef85a95832d40860056e61050 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259656Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77689}
-
Seth Brenith authored
This is a reland of 7366f6e2 The test that failed after the initial commit was just flaky and has been fixed; see https://bugs.chromium.org/p/v8/issues/detail?id=12341 Original change's description: > [torque] Don't generate k(?:Start|End)Of\w+FieldsOffset constants > > Torque currently generates constants like kStartOfWeakFieldsOffset and > kEndOfStrongFieldsOffset, which can be used when writing custom > BodyDescriptors. However, these offsets have some potentially confusing > behaviors: > > * They don't take inheritance into account and describe only the fields > defined by the current class itself, so there might be (for example) > strong fields before kStartOfStrongFieldsOffset if they were defined > by a superclass. > * kStartOfWeakFieldsOffset points to the first field defined in Torque > using the keyword `weak`, which indicates fields with *custom* > weakness semantics (those that should be visited with > IterateCustomWeakPointers), not those that may contain standard weak > pointers (visited with IterateMaybeWeakPointers). (As a follow-up, I'd > like to also rename `weak` to `@customWeak`.) > > Given that these constants have very low usage and somewhat bizarre > semantics, I propose that we remove them. This change does so, and > updates the existing usages to either define the required constants > directly in C++ or not use them. I know that defining these constants in > C++ is more brittle, but I think that brittle and clear is better than > automatic and incomprehensible. > > Bug: v8:7793 > Change-Id: I87f8c85ccae4027f61ac73d4e7e4e2820e92003b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199731 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#77411} Bug: v8:7793 Change-Id: Iefdd4014ce4b85b48c19ead79a0316774a5ecd45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3258082Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#77688}
-
Andreas Haas authored
R=manoskouk@chromium.org Bug: v8:12281 Change-Id: I7f5c231683c45e7c87c649246759f76464f4e835 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259646 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77687}
-
Junliang Yan authored
Change-Id: Ie46687a1af834b9c1a6c8fa5bcf5badb61cc1647 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259645Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77686}
-
Thibaud Michaud authored
We only expect the "wasm_exception_values_symbol" property to be a fixed array if the property actually exists. If the property is not found, JSReceiver::GetProperty returns "undefined", so skip the check in this case. R=clemensb@chromium.org Bug: chromium:1262582 Change-Id: I28d7891064bdd7632ff1a4c94ba021163401fd88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3244416 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77685}
-
Al Muthanna Athamina authored
Bug: v8:12185 No-Try: true Change-Id: Ib8296171d8101594949deddbf0a7c2a24ee5c7f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257717 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77684}
-
Jakob Kummerow authored
If index > JSObject::kMaxElementIndex, we have to perform a prototype chain lookup for a named property. The corresponding check was missing for string receivers. Fixed: chromium:1265043 Change-Id: Ibccd058a4bd108eeee235762bea0bc4163aaa0b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257704 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77683}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: Iffebca251d18d5637884b2181acdfb3e6c5496a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257715Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77682}
-
Jakob Gruber authored
Happy hunting. Bug: chromium:1262676 Change-Id: I0f3a5519cb9ed3dc4787acd61cb437ee8c2bf2d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257716 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77681}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: Ib0997ca8cedaf1065fc6803d5297c30621b49949 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257714Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77680}
-
Georgia Kouveli authored
`UseScratchRegisterScope` should be used in a block scope, to avoid keeping the scratch register in use for longer than it's needed. Spotted when experimenting with the `v8_enable_heap_sandbox` and `v8_enable_external_code_space` flags. Change-Id: I34330f3e4dbd114aa75efb0ebdcf557f0bd45f11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256997Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/main@{#77679}
-
Igor Sheludko authored
In order to avoid some of the unnecessary Code <-> CodeDataContainer conversions in builtins we need to be able to embed CodeDataContainer references to builtins. This CL makes it possible by introducing a table of builtins' CDCs. Eventually, usages of the builtins table containing Code objects will be replaced by usages of this table. Bug: v8:11880 Change-Id: Iffffd1507d5c7b38af34c42071a4577a8d18e8eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257710Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77678}
-