• Seth Brenith's avatar
    Reland "[torque] Don't generate k(?:Start|End)Of\w+FieldsOffset constants" · a3480b55
    Seth Brenith authored
    This is a reland of 7366f6e2
    
    The test that failed after the initial commit was just flaky and has
    been fixed; see https://bugs.chromium.org/p/v8/issues/detail?id=12341
    
    Original change's description:
    > [torque] Don't generate k(?:Start|End)Of\w+FieldsOffset constants
    >
    > Torque currently generates constants like kStartOfWeakFieldsOffset and
    > kEndOfStrongFieldsOffset, which can be used when writing custom
    > BodyDescriptors. However, these offsets have some potentially confusing
    > behaviors:
    >
    > * They don't take inheritance into account and describe only the fields
    >   defined by the current class itself, so there might be (for example)
    >   strong fields before kStartOfStrongFieldsOffset if they were defined
    >   by a superclass.
    > * kStartOfWeakFieldsOffset points to the first field defined in Torque
    >   using the keyword `weak`, which indicates fields with *custom*
    >   weakness semantics (those that should be visited with
    >   IterateCustomWeakPointers), not those that may contain standard weak
    >   pointers (visited with IterateMaybeWeakPointers). (As a follow-up, I'd
    >   like to also rename `weak` to `@customWeak`.)
    >
    > Given that these constants have very low usage and somewhat bizarre
    > semantics, I propose that we remove them. This change does so, and
    > updates the existing usages to either define the required constants
    > directly in C++ or not use them. I know that defining these constants in
    > C++ is more brittle, but I think that brittle and clear is better than
    > automatic and incomprehensible.
    >
    > Bug: v8:7793
    > Change-Id: I87f8c85ccae4027f61ac73d4e7e4e2820e92003b
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199731
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/main@{#77411}
    
    Bug: v8:7793
    Change-Id: Iefdd4014ce4b85b48c19ead79a0316774a5ecd45
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3258082Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#77688}
    a3480b55
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...