• Anton Bikineev's avatar
    cppgc: Force EBO to always work with GCed · 92eae6d1
    Anton Bikineev authored
    Currently, in the following struct
    
    struct LayoutObject : GarbageCollected<>, MixinA, MixinB {};
    
    the subobject that corresponds to the first base GarbageCollected<>
    always takes up some space (one word). The empty-base-optimization
    doesn't happen because the second base (MixinA) has the same subobject
    as the first base (GarbageCollected), which is the most parent class
    GarbageCollectedBase. The compiler can't "merge" them because it must
    guarantee that distinct objects of the same type have distinct
    addresses.
    
    The attribute [[no_unique_address]] doesn't work for base classes,
    unfortunately (but is a good idea for a Standard proposal). As a
    solution, the CL simply removes GarbageCollectedBase.
    
    Bug: chromium:1260797
    Change-Id: I415b10a5fbcebce3d6ee97b8870ea9ae90f383a8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259654
    Commit-Queue: Anton Bikineev <bikineev@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77693}
    92eae6d1
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...