- 07 Dec, 2020 24 commits
-
-
Zhi An Ng authored
In instruction selector for this opcode, when AVX is supported, we don't require the second operand to be a register, so it can be an operand. Bug: v8:1155497,v8:9198 Change-Id: I609deb69b826e686dddc237dcf2ab6129424e761 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575787Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71650}
-
Daniel Clark authored
Although every Primitive is a Data, the Cast operations for the subclasses of Primitive do not allow casting directly from Data to the subclasses without first going through Value. Because of this, Primitives extracted from a V8::FixedArray require two casts to get to the "real" type. Thus, as a convenience to embedders, this change makes it possible to cast directly from Data to all the subtypes of Primitive. Also, this change makes the parameter names in the declarations match those in the definitions, though there does not seem to be a universally followed convention regarding these. Bug: v8:10958 Change-Id: I18dc3fbb9a9bccb2cb3b75efd829af64d46d8eb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573816Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#71649}
-
Dominik Inführ authored
ReduceToString performs heap access on the background thread. Change-Id: Ic93ee21d6eeb96fe1dbd2b98043e6ccff0eefa64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2577458 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#71648}
-
Milad Fa authored
Some wasm interpreter tests are failing since instructions generated by gcc such as *multiply and and* (fmadds) create intermediate results bigger than 8 bytes which doesn't match other architectures, hence the resulting output differs. Change-Id: I9c745c6be1b2b7a22085a230cc3f66ff756e0b62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2577460Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71647}
-
cjihrig authored
This commit updates the gen-postmortem-metadata.py script to incorporate changes in V8 8.4. This removes the need to float a patch to the script in Node.js. Change-Id: I69da40e792f22748b0eee2952b9009b2f03d13f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565275Reviewed-by:
Joyee Cheung <joyee@igalia.com> Reviewed-by:
-
Clemens Backes authored
Import wrappers were only logged if logging was enabled during compilation. If the profiler is enabled later, and regular wasm code is logged via {NativeModule::LogWasmCodes}, the import wrappers were missing. This CL fixes the long-standing TODO, and adds tests which triggered that code path. Those tests were hanging before because the expected functions did never appear in the profile. Drive-by: If {WasmEngine::LogOutstandingCodesForIsolate} detects that code logging is disabled by now, it should still clear the {code_to_log} vector. R=thibaudm@chromium.org Bug: chromium:1125986, chromium:1141787 Change-Id: I2566ef369bb61a09488f2d932b6c10d92e4cb12f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2574696Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71645}
-
Bill Budge authored
- Adds an AlignedSlotAllocator class and tests, to unify slot allocation. This attempts to use alignment holes for smaller values. - Reworks Frame to use the new allocator for stack slots. - Reworks LinkageAllocator to use the new allocator for stack slots and for ARMv7 FP register aliasing. - Fixes the RegisterAllocator to align spill slots. - Fixes InstructionSelector to align spill slots. Bug: v8:9198 Change-Id: Ida148db428be89ef95de748ec5fc0e7b0358f523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512840 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71644}
-
Michael Achenbach authored
No-Try: true Bug: v8:11233 Change-Id: I391bbd22b4415e9a669795b62b4933fb4b3e9eef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575124Reviewed-by:
-
Clemens Backes authored
For logging existing functions, currently walk the heap four times: 1) For getting the number of JS Code objects, 2) for getting the actual JS Code objects, 3) for getting the number of wasm code objects, 4) for getting the actual wasm code objects. This CL refactors this to do only two heap walks (one for JS, one for wasm). It also avoids the use of the brittle {ScopedVector} and uses a {std::vector} instead. R=thibaudm@chromium.org Bug: chromium:1125986 Change-Id: I47e3c41ed65f4011ad8826f5e115db6459680807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2571121 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Benedikt Meurer authored
Previously V8 would wrap the WebAssembly.Memory backing stores into Uint8Arrays and report that as memories, but that's confusing to the developer, since that's not what's really being used. The way that DevTools presents the backing stores of memories, it's still perfectly possible to get hold of an Uint8Array if that's what the developer is looking for. To make it possible to easily identify the WebAssembly.Memory objects in the DevTools front-end (in particular for the memory inspector) we add a 'webassemblymemory' subtype to the Chrome DevTools Protocol. We also improve the description for the memories to include the number of active pages. Fixed: chromium:1155566 Screenshot: https://imgur.com/8enx57u.png Change-Id: I63dbabe0e372e9ad6dcc8e6642cdb743147a620c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2574699Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#71641}
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: Ic8514d33938a60ff5513463d4754fb7fc5f85491 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2569564Reviewed-by:
-
Mythri A authored
Dependent code deopts were only printed with --trace-deopt-verbose earlier. These just print one line and are helpful with --trace-deopt. If we don't print these with --trace-deopt, it appears as if we are optimizing without any deopts in between which is a bit confusing. Change-Id: I29b0f2ebbaac2a1ffc498e93c8433c986e429ef3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573485Reviewed-by:
-
Mythri A authored
This cl extends profview to 1. Show Turboprop ticks in a different color in timeline panel 2. In summary panel, show Turboprop optimizations and TurboFan optimizations as two different entries 3. Fix deopts in summary panel after the rename to deopts 4. Also show information about bailouts (happen only with Turboprop) Bug: v8:9684 Change-Id: I028b12a55741c789ecc1d212d1517a57496379dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573477 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Ross McIlroy authored
BUG=chromium:1155499,chromium:1154961 Change-Id: I29948a63e477ef28b7599eb53db17b127662a641 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2574697 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#71637}
-
Mythri A authored
Change-Id: I4afb695505d145221feca3ff365e0f96b097a6ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573483 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I82d84f03a8a9361cc1299a28cd9e4ba757930dd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2569560 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#71635}
-
Yahan Lu authored
About https://chromium-review.googlesource.com/c/v8/v8/+/2557988 On https://chromium-review.googlesource.com/c/v8/v8/+/2557988/7/src/objects/string.h#476 It add a template, but not define it on https://chromium-review.googlesource.com/c/v8/v8/+/2557988/7/src/objects/string.h#576 It lead to build failed on g++ 10.0.1. https://bugs.chromium.org/p/v8/issues/detail?id=11228 Bug: v8:11228 Change-Id: I81103143a995cc5225a990672094adaa7a3a934d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573643 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Liu Yu authored
Port commit 4765c70f Change-Id: I1149eb3317613627e2cef4e6c9ad38f044e96fe0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576444Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71633}
-
Zhi An Ng authored
Bug: v8:11217 Change-Id: I4a02af1b9b07470134ea893d532c545da63b26d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568922 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/83e2334..b7fc8c9 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9cde52ff7a44cc90f129fc393fa3f24bd7277d1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576617Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71631}
-
Zhi An Ng authored
Stick more closely to the decoding guide laid out in the manual, and also take the chance to remove some duplicate code. Drive-by fix a clang-tidy warning for bool literal. Bug: v8:11074 Change-Id: I91aa8db7cd3db30b250e8bfc9bb146c8bb56dcd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567530 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71630}
-
Zhi An Ng authored
Bug: v8:11008 Change-Id: Ic7be8370e3e820d225558995a9ad2295811e98a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567531Reviewed-by:
-
Zhi An Ng authored
Prototype v128.{load,store}{8,16,32,64}_lane on arm. Bug: v8:10975 Change-Id: I649f567f39f8a5ba6992a86b761f93f62619c139 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565079 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: -
Zhi An Ng authored
This is a reland of 716dae3a Original change's description: > [wasm-simd][ia32] Prototype sign select > > The implementation is the same as on x64. > > Bug: v8:10983 > Change-Id: I2654ce4a627ca5cc6c759051ab9034c528d9f25a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567194 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71606} Bug: v8:10983 Change-Id: I05af92ec2d3531dd2e0d27353cc665967fb5c387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2574001 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 06 Dec, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7ac6aae..83e2334 Rolling v8/third_party/aemu-linux-x64: FMtthcz6qGrAgLXdxXJ6pP0iueMVqTXO6-6_LOrvTZUC..ZgEt2vZQcebeMBnTVKemE7gxtLtigVkD5iHfrp1QkDsC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e6a6233..e602c60 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie61fff611a4f3817f9e34f874d7e1fc10e56d648 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576441Reviewed-by:
-
- 05 Dec, 2020 3 commits
-
-
Junliang Yan authored
Pair Ops are for 31-bit support. We had drop 31-bit support long time ago so don't need them anymore. Change-Id: Iff1f8df19433fd1431316888d0c5276b9710b1fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576003 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71625}
-
Camillo Bruni authored
- Clean up entry selection code - Add source positions for code and deopt events - Fix log entry selection from script - Improve log parsing speed Bug: v8:10644 Change-Id: Ie466679132b8ce24506ecf75223118b32275f931 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2569756 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71624}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/acf4f5e..7ac6aae Rolling v8/third_party/aemu-linux-x64: Ld6Ho8txe7fnUwYDIgKsMmU0e2gBZ9Zx1n43O83aofUC..FMtthcz6qGrAgLXdxXJ6pP0iueMVqTXO6-6_LOrvTZUC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d1cf5db..88efddc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b2c18f2..e6a6233 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/9893e50..c29ee8c TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7eb12442d93f225caf74d58546e1967b33bd5a0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576004Reviewed-by:
-
- 04 Dec, 2020 12 commits
-
-
Shu-yu Guo authored
Bug: v8:7367 Change-Id: I4240f6683945c0f60b30afe563f8f735563e4367 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568230Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71622}
-
Junliang Yan authored
Replace LoadW/lW/LogicalHalfWordP/HalfWordP/B/lB/Float32/Double as LoadS32/U32/S16/U16/S8/U8/F32/F64 Change-Id: I2a41dee0168fb17eb4043ce78f857e1fd898ea8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575139Reviewed-by:
-
Thibaud Michaud authored
R=jkummerow@chromium.org Bug: chromium:1155319 Change-Id: Iea99b5caaee1fc2ea4a6ed846badd2f1be57ae19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2574698Reviewed-by:
-
Shu-yu Guo authored
I2S with LGTMs: https://groups.google.com/a/chromium.org/g/blink-dev/c/I8S78w7aFmE/m/qLHAcjhRCQAJ v8: 10961 Change-Id: If0440c0595823c61352f144c1fc29c54a1175623 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2574716Reviewed-by:
-
Dominik Inführ authored
VerifyNewSpaceTop() assumes that original_top_ and allocation_info_.start() always match. PublishPendingAllocations() violates this invariant by only updating original_top_ in the NewSpace. Fix this by using MarkLabStartInitialized() for NewSpace. Alternatively we could loosen the DCHECK in VerifyNewSpaceTop(). The fix doesn't matter too much since Ulan's LAB refactoring will get rid of that code anyways. Bug: v8:11224 Change-Id: I26267ac9dd78cc5d2a2a6fefca3b69f4582c094f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2569769 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Improve the performance of gcmole by * Precompiling the regexes in GCSuspectsCollector.Resolve * Merging those regexes into a single regex, using '|' * Changing multiprocess clang plugin invocation to threaded (running the plugin releases the GIL so this can efficiently thread). This uses a simple worker pool with a single work queue. * Change clang plugin invocation loop to yield after each invocation. This pipelines the dump-callees plugin and GCSuspectsCollector Parse/Resolve, so that the parse can happen while waiting for other callee dumps to finish. Change-Id: Ib9fca70dbcfd2f9d1aebc8bd11aa1d1f7d34e24a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562242Reviewed-by:Maya Lekova <mslekova@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#71617}
-
Clemens Backes authored
We currently do not report a script ID for wasm code, i.e. the script id is 0. We cannot just print the script ID itself, as it is considered unstable. Thus this CL only makes us print whether it is set or not. In a follow-up CL where we fix setting script IDs for wasm code events the output will change. R=thibaudm@chromium.org Bug: chromium:1125986 Change-Id: Ibc52829ea8a5a5c9506e36390eb4c608bcab4624 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2571120 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Andreas Haas authored
The implementation is follows the implementation of table.copy, aside from the table-index being passed as an intptr instead of a Smi. The builtins of table.get/set and table.copy are different in that regard. R=thibaudm@chromium.org Bug: v8:7581 Change-Id: Ifde788b230083dc6633ce6b41e6acfb8b503b781 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414211 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Milad Fa authored
f64x2min/max need to canonicalize the output only if both inputs are also canonicalized, otherwise any arithmetic NaN (from either lane) can be placed into the result register. We also need to make sure the output value is a QNAN. Change-Id: I363f88528674014cd92828d429a61442406025b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573484Reviewed-by:
-
Clemens Backes authored
This makes sure that the code tested by fuzzers is the same as running on native hardware. R=ahaas@chromium.org Bug: v8:11041 Change-Id: I1005b2de3a22d88a6bdf164338633bbb7991bc1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573481Reviewed-by:
-
Junliang Yan authored
Change-Id: I982c0040b95a1495630034871389843e5248b221 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2572961 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Tobias Tebbi authored
Port String::Flatten to Torque (using a fast C call for the non-allocating part) and provide fast and easy access to sequential string data in Torque: GetStringData() flattens if necessary and computes slices that allow direct access. Applications: String.prototype.replaceAll, String.prototype.endsWith, and String.prototype.beginsWith now use GetStringData() and direct slice access instead of the slow StringCharCodeAt and they no longer bail out to the runtime for flattening. Drive-by changes: - Expose String instance type bits as bitfields and enums in Torque. - Fix method lookup in Torque to include superclass methods. - Use char8 and char16 types in more places. - Allow fast C calls with void return type. - Add Torque macros to create subslices. - Add no-GC scopes to runtime functions loading external string data. Bug: v8:7793 Change-Id: I763b9b24212770307c9b2fe9f070f21f65d68d58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565515 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71611}
-
