• Daniel Clark's avatar
    Allow casting to Primitive types from Data · a8f6c061
    Daniel Clark authored
    Although every Primitive is a Data, the Cast operations for the
    subclasses of Primitive do not allow casting directly from Data to the
    subclasses without first going through Value.  Because of this,
    Primitives extracted from a V8::FixedArray require two casts to get to
    the "real" type.
    
    Thus, as a convenience to embedders, this change makes it possible to
    cast directly from Data to all the subtypes of Primitive.
    
    Also, this change makes the parameter names in the declarations match
    those in the definitions, though there does not seem to be a universally
    followed convention regarding these.
    
    Bug: v8:10958
    Change-Id: I18dc3fbb9a9bccb2cb3b75efd829af64d46d8eb9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573816Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Dan Clark <daniec@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#71649}
    a8f6c061
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...