- 11 Jan, 2022 16 commits
-
-
Igor Sheludko authored
Windows requires additional writable page to be allocated in front of the code range, but at the same time the code range must not cross 4 GB boundary in order to make Code pointer compression work for Code pointers. All these constraints make the logic of hint calculation too dependent on what VirtualMemoryCage::InitReservation() would do with the provided hint. This CL simplifies the hint calculation and fully relies on VirtualMemoryCage::InitReservation() to do the right thing. On Linux the implementation of OS::GetFreeMemoryRangesWithin() doesn't work when Chromium sandbox is enabled, so we use the beginning of the preferred short builtin calls region as a hint. It should be at least as good as the fallback hint but with higher chances to point to free address space location. Bug: v8:11880 Change-Id: I0b6ebec98dd0cf483f67e6ba8a919deb9ce7cc25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380585Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78568}
-
Piotr Sikora authored
Signed-off-by:
Piotr Sikora <piotrsikora@google.com> Change-Id: Ib4dc67fcb58d7d8f7e48752c579468229c23de52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3375469Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78567}
-
Milad Fa authored
This CL takes advantage of the P9 `vector byte-reverse` instructions to add to support to BE platforms. Change-Id: Ia022e056ca61373b7f8f7754ec76e94774b80af3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3378922Reviewed-by:
-
Manos Koukoutos authored
We introduce a type arrayref, which is a supertype of all array types and a subtype of dataref. We change array.len to accept values of type (ref null array). Drive-by: Fix kEq/kData case in TypecheckJSObject. Bug: v8:7748 Change-Id: I47c6a4487ddf5e7280c1427f43abe87a97c896bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3368105Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78565}
-
Andreas Haas authored
The original CL introduced a test that does not work when it is executed concurrently on multiple isolates. This CL skips this test configuration. Original change's description: > [wasm] Lazy compilation after deserialization > > The serialization format contains one boolean flag per function which > specifies whether the function code exists in the serialized module or > not. With this CL, this boolean flag is extended to a three-value flag > which indicates whether the function exists, and if not, whether the > function was executed before serialization. This information can then be > used upon deserialization to compile only those functions that were > executed before serialization. > > Design doc: https://docs.google.com/document/d/1U3uqq4njqLqFhr1G2sU_bmpQxY-3bvfG55udSb-DvA4/edit?usp=sharing > > Bug: v8:12281 Change-Id: I36ce90b37736172aa01c47ab04e154ec8ea2d8aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380590Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78564}
-
JianxiaoLuIntel authored
Change-Id: I443d6e84fb3ca9d27456300b777105319ec0fe25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3352457Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78563}
-
Victor Gomes authored
No-Try: true Change-Id: If4d72836d40ee994ea5b7f7f1f2a98092d7b4079 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380599 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Piotr Sikora authored
This leads to a noticable performance improvements, and this flag is flipped to "is_debug" by the V8 Autoroller in release branches for the GN builds, so this change matches that behavior. Signed-off-by:
-
Thibaud Michaud authored
- Add Suspender.suspendOnReturnedPromise method - Extend the WasmApiFunctionRef data with the suspender - Detect wrapped WasmJSFunctions when we resolve the import For now the generated wrapper is still a regular wasm-to-js wrapper, but this sets the ground for generating specific wrappers for functions wrapped by suspendOnReturnedPromise, and to access the suspender from the wrapper code. R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: I81cbec6b023507e47e6e1463b5f9b912f807da6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3345000Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#78560}
-
Piotr Sikora authored
Signed-off-by:
-
Aleksei Koziatinskii authored
BaseSpace classes. So BaseSpace should have a virtual destructor for memory to be freed properly. cppgc: :internal::RawHeap maintains a std::vector of std: :unique_ptr<BaseSpace> and stores there different derived from Change-Id: Id9f59817799303bf62aafb66b3a29770bbd2af1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379228Reviewed-by:
-
Benedikt Meurer authored
The methods in the v8::internal::Factory deal with creating the objects described in src/objects, so there's no point in having different sets of owners for them. Bug: none Change-Id: I05b48535bd81d37796e3f741156a059be8554759 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359634Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/3b3de69..0d98dba Creating release commit for v1.6.1 (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/0d98dba Destructor not returning is expected in some cases (#1316) (staffantj) https://chromium.googlesource.com/external/github.com/google/benchmark/+/0e78738 Address c4267 warning on MSVC (#1315) (staffantj) https://chromium.googlesource.com/external/github.com/google/benchmark/+/6dfe7af R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I484073c46b839f7ba8d8c8abac6e6c28da79b1ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379826 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78556}
-
Frank Tang authored
Bug: v8:11544 Change-Id: If0a6eeb6591538a969efaac9d148d019300b4113 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3374067Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78555}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/12badc1..3803b80 Rolling v8/buildtools/linux64: git_revision:f1b1412521b41e47118b29863224171e434a27a2..git_revision:80a40b07305373617eba2d5878d353532af77da3 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/58d1647..14da6e7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aa0e8d0..dc12138 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d3cc7ad..0f5a4de Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6e330f7..f5a2da5 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ie20d091b4fd5b69d68a9b6f0e69ea3403abbce0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379824 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78554}
-
Lu Yahan authored
enable simd on riscv64 Change-Id: I446d6b14e4f89164b49a66367340d904ba104911 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347493Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
-
- 10 Jan, 2022 24 commits
-
-
Piotr Sikora authored
This simplifies integration with Bazel workspaces that already have those libraries imported under different repository names. Signed-off-by:
-
Piotr Sikora authored
This allows other Bazel projects to use their existing zlib import, and only pull compression utils from Chromium's zlib. Signed-off-by:
-
Piotr Sikora authored
This allows other Bazel projects to fetch those dependencies without relying on a full "gclient" checkout. Added "com_googlesource_chromium" prefix to repository names to indicate that those are Chromium forks and not official releases. Signed-off-by:
-
Corentin Pescheloche authored
For consistency with the other enums values, avoid gaps between EmbedderState values. Bug: chromium:1263871 Change-Id: I22c58700f292b007ced7c12db219f578f82d77d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3370081 Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com> Reviewed-by:
-
Adenilson Cavalcanti authored
The enablement of PAC in Chromium will have two phases where support will first be enabled on C++ code (e.g. Blink/Chrome/etc) and its dependencies, followed next by support for dynamic code generated by V8. This change will allow enable PAC support for C++ code when V8 is built with Chromium. Bug: chromium:919548 Change-Id: I8ebcbcfe3c2a3a38807b814f936272ac09625795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372162Reviewed-by:
-
Alexander Timin authored
Add the new disabled-by-default-v8.inspector category (added by [1]) to the category list to ensure that v8 can be built with perfetto client library (example failure [2]). [1] https://chromium-review.googlesource.com/c/v8/v8/+/3364085 [2] https://ci.chromium.org/ui/p/chromium/builders/try/linux-perfetto-rel/5926/overview Change-Id: I7b187a18d2f996148fbfd42f9039f9a2012537bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3370121 Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit fbcdb281. Reason for revert: New test fails for multiple (concurrent) isolates: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux/45152/overview Original change's description: > [wasm] Lazy compilation after deserialization > > The serialization format contains one boolean flag per function which > specifies whether the function code exists in the serialized module or > not. With this CL, this boolean flag is extended to a three-value flag > which indicates whether the function exists, and if not, whether the > function was executed before serialization. This information can then be > used upon deserialization to compile only those functions that were > executed before serialization. > > Design doc: https://docs.google.com/document/d/1U3uqq4njqLqFhr1G2sU_bmpQxY-3bvfG55udSb-DvA4/edit?usp=sharing > > Bug: v8:12281 > Change-Id: I465e31e5422fa45163256be0e6594045865f0174 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364089 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78545} Bug: v8:12281 Change-Id: If0e327d02e8257a4d1cfcf8b82381af11f28e91c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3377126 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78546}
-
Andreas Haas authored
The serialization format contains one boolean flag per function which specifies whether the function code exists in the serialized module or not. With this CL, this boolean flag is extended to a three-value flag which indicates whether the function exists, and if not, whether the function was executed before serialization. This information can then be used upon deserialization to compile only those functions that were executed before serialization. Design doc: https://docs.google.com/document/d/1U3uqq4njqLqFhr1G2sU_bmpQxY-3bvfG55udSb-DvA4/edit?usp=sharing Bug: v8:12281 Change-Id: I465e31e5422fa45163256be0e6594045865f0174 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364089Reviewed-by:
-
Milad Fa authored
This CL takes advantage of the P9 `vector byte-reverse` instruction to implement Simd LoadSplat opcodes. We will need to implement the rest of the `load transform` ops before enabling this from wasm-compiler on BE machines. Change-Id: I094e37d3b15e0dc04484eb2a701cb479f18e2f9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3371790Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:12538 Change-Id: I4f1d4bc33846c158044da76b882d54469ff031a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3377124 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
When creating a new JSError object (or using the non-standard API `Error.captureStackTrace`) V8 would previously capture the "simple stack trace" (as FixedArray of CallSiteInfo instances) to be used for the non- standard `error.stack` property, and if the inspector was active also capture the "detailed stack trace" (as FixedArray of StackFrameInfo instances). This turns out to be quite a lot of overhead, both in terms of execution time as well as memory pressure, especially since the information needed for the inspector is a proper subset of the information needed by `error.stack`. So this CL addresses the above issue by capturing only the "simple stack trace" (in the common case) and computing the "detailed stack trace" from the "simple stack trace" when on demand. This is accomplished by introducing a new ErrorStackData container that is used to store the stack trace information on JSErrors when the inspector is active. When capturing stack trace for a JSError object while the inspector is active, we take the maximum of the program controlled stack trace limit and the inspector requested stack trace limit, and memorize the program controlled stack trace limit for later formatting (to ensure that the presence of the inspector is not observable by the program). On the `standalone.js` benchmark from crbug.com/1283162 (with the default max call stack size of 200) we reduce execution time by around 16% compared to ToT. And compared to V8 9.9.4 (the version prior to the regression in crbug.com/1280831), we are 6% faster now. Doc: https://bit.ly/v8-cheaper-inspector-stack-traces Bug: chromium:1280831, chromium:1278650, chromium:1258599 Bug: chromium:1280803, chromium:1280832, chromium:1280818 Fixed: chromium:1283162 Change-Id: I57dac73e0ecf7d50ea57c3eb4981067deb28133e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3366660Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
XiangYang authored
Modify the wrong code annotation. Change-Id: Ied592d7066f394581ba36480eb91221f1ba53bbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359104Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#78541}
-
Romain Pokrzywka authored
LocalFactory::AllocateRaw() only allows the kOld and kSharedOld allocation types, but NewArrayList() calls NewFixedArray() without an explicit allocation argument, which then defaults to kYoung. Add an allocation argument to NewArrayList() with the same default value as for NewFixedArray() and pass kOld when calling it from NewScriptWithId() to avoid tripping the DCHECK with LocalFactory. Follow-up to https://crrev.com/c/3211575 Bug: chromium:1244145 Change-Id: I88d394bda250c45bf49141b78c09f6ca4a61dbe3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3354087Reviewed-by:
-
Benedikt Meurer authored
The special symbols defined in heap-symbols.h were extracted out of src/heap/heap.{cc,h} a long time ago because they logically belong to the objects and not to the implementation of the GC/heap, so they should have the same ownership as the objects that use them in src/objects. Bug: none Change-Id: I9a87c1600dc26b0fc5e620a13d409fb9116235e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3375546Reviewed-by:Hannes Payer <hpayer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78539}
-
Shu-yu Guo authored
Bug: v8:11708 Change-Id: Ibf0f91b9e63646f226a2e70ec4a1733820e968ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3373135 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Piotr Sikora authored
Signed-off-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Liviu Rau authored
Bug: v8:12538 Change-Id: I57496ee0f50df92000c445c07acc8d6ee763d4e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3377123Reviewed-by:
-
Piotr Sikora authored
Signed-off-by:
-
Piotr Sikora authored
Signed-off-by:
-
Piotr Sikora authored
Signed-off-by:
-
Clemens Backes authored
We should only check the "SIMD sibling" register if we are handling a SIMD register. This avoids unneeded spills, and in this particular case ran into a DCHECK because there are only 29 registers, but we tried checking #29. R=thibaudm@chromium.org Bug: v8:12330, v8:1285007 Change-Id: Ife8b295ac958990611ca8816bbfbfb5124a4297d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372916Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78532}
-
Piotr Sikora authored
Tested with both GCC and Clang on s390x (under QEMU). Signed-off-by:
-
Al Muthanna Athamina authored
Bug: v8:12538 Change-Id: I89e7fcde7226d680f3385f527cb2e456829a476d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3376962Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#78530}
-
Manos Koukoutos authored
This is a reland of be6bd4f4. The reason for revert was two bots timing out. On further inspection, the timeouts seem unrelated. Original change's description: > [wasm] Fast paths in EvaluateInitExpression > > We add fast paths for the most common types of expressions in > {EvaluateInitExpression} to improve instantiation time. We fall back to > full expression decoding for less common operators, or for expressions > with operands. > > Bug: chromium:1284557 > Change-Id: I39a1816176974058b801cdad6eaaa6da156cea04 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3367627 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78497} Bug: chromium:1284557 Change-Id: I209458c1fa36ae41899434b90759ebe3fe5e2a57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3375545Reviewed-by:
-
