cppgc: added missing virtual BaseSpace destructor

BaseSpace classes. So BaseSpace should have a virtual destructor
for memory to be freed properly.

cppgc: :internal::RawHeap maintains a std::vector of
std: :unique_ptr<BaseSpace> and stores there different derived from
Change-Id: Id9f59817799303bf62aafb66b3a29770bbd2af1f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3379228Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78558}

src/heap/cppgc/heap-space.cc

@@ -20,6 +20,8 @@ BaseSpace::BaseSpace(RawHeap* heap, size_t index, PageType type,
   USE(is_compactable_);
 }
 
+BaseSpace::~BaseSpace() = default;
+
 void BaseSpace::AddPage(BasePage* page) {
   v8::base::LockGuard<v8::base::Mutex> lock(&pages_mutex_);
   DCHECK_EQ(pages_.cend(), std::find(pages_.cbegin(), pages_.cend(), page));

src/heap/cppgc/heap-space.h

@@ -28,6 +28,7 @@ class V8_EXPORT_PRIVATE BaseSpace {
 
   BaseSpace(const BaseSpace&) = delete;
   BaseSpace& operator=(const BaseSpace&) = delete;
+  virtual ~BaseSpace();
 
   iterator begin() { return pages_.begin(); }
   const_iterator begin() const { return pages_.begin(); }